mbox series

[V2,00/12] remoteproc: qcom: q6v5-wcss: Add support for secure pil

Message ID 1568375771-22933-1-git-send-email-gokulsri@codeaurora.org
Headers show
Series remoteproc: qcom: q6v5-wcss: Add support for secure pil | expand

Message

Gokul Sriram Palanisamy Sept. 13, 2019, 11:55 a.m. UTC
IPQ8074 needs support for secure pil as well.
Also, currently only unified firmware is supported.
IPQ8074 supports split firmware for q6 and m3, so
adding support for that.

 Also, this series is based on Govind’s,
 “[v4] Add non PAS wcss Q6 support for QCS404”
 https://www.spinics.net/lists/linux-remoteproc/msg03612.html

[V2] Fixed all comments

Gokul Sriram Palanisamy (12):
  remoteproc: qcom: Add PRNG proxy clock
  remoteproc: qcom: Add secure PIL support
  remoteproc: qcom: Add support for split q6 + m3 wlan firmware
  remoteproc: qcom: Add ssr subdevice identifier
  remoteproc: qcom: Update regmap offsets for halt register
  dt-bindings: clock: qcom: Add reset for WCSSAON
  clk: qcom: Add WCSSAON reset
  dt-bindings: mailbox: qom: Add ipq8074 APPS compatible
  mailbox: qcom: Add support for IPQ8074 APCS
  dt-bindings: firmware: qcom: Add compatible for IPQ8074 SoC
  arm64: dts: Add support for scm on IPQ8074 SoCs
  arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC

 .../devicetree/bindings/firmware/qcom,scm.txt      |   1 +
 .../bindings/mailbox/qcom,apcs-kpss-global.txt     |   1 +
 arch/arm64/boot/dts/qcom/ipq8074.dtsi              | 132 +++++++++++++++++
 drivers/clk/qcom/gcc-ipq8074.c                     |   1 +
 drivers/mailbox/qcom-apcs-ipc-mailbox.c            |   1 +
 drivers/remoteproc/qcom_q6v5_wcss.c                | 158 +++++++++++++++++----
 include/dt-bindings/clock/qcom,gcc-ipq8074.h       |   1 +
 7 files changed, 265 insertions(+), 30 deletions(-)

Comments

Stephen Boyd Sept. 17, 2019, 4:15 p.m. UTC | #1
Quoting Gokul Sriram Palanisamy (2019-09-13 04:56:11)
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 6a61a63..0ea026e 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -431,6 +485,78 @@
>                                       "axi_m_sticky";
>                         status = "disabled";
>                 };
> +
> +               apcs: syscon@b111000 {
> +                       compatible = "syscon";
> +                       reg = <0x0b111000 0x1000>;
> +               };
> +
> +               tcsr_q6: syscon@1945000 {
> +                       compatible = "syscon";
> +                       reg = <0x01945000 0xe000>;
> +               };
> +
> +               tcsr_mutex_regs: syscon@193d000 {
> +                       compatible = "syscon";
> +                       reg = <0x01905000 0x8000>;
> +               };
> +
> +               apcs_glb: mailbox@b111000 {

This is the same as the syscon above. What's going on?

> +                       compatible = "qcom,ipq8074-apcs-apps-global";
> +                       reg = <0x0b111000 0x1000>;
> +
> +                       #mbox-cells = <1>;
> +               };
Stephen Boyd Sept. 17, 2019, 4:16 p.m. UTC | #2
Quoting Gokul Sriram Palanisamy (2019-09-13 04:56:06)
> Add WCSSAON reset required for Q6v5 on IPQ8074 SoC.
> 
> Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Nikhil Prakash V <nprakash@codeaurora.org>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>
Gokul Sriram Palanisamy Nov. 27, 2019, 3:03 p.m. UTC | #3
On 2019-09-17 21:45, Stephen Boyd wrote:
> Quoting Gokul Sriram Palanisamy (2019-09-13 04:56:11)
>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi 
>> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> index 6a61a63..0ea026e 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> @@ -431,6 +485,78 @@
>>                                       "axi_m_sticky";
>>                         status = "disabled";
>>                 };
>> +
>> +               apcs: syscon@b111000 {
>> +                       compatible = "syscon";
>> +                       reg = <0x0b111000 0x1000>;
>> +               };
>> +
>> +               tcsr_q6: syscon@1945000 {
>> +                       compatible = "syscon";
>> +                       reg = <0x01945000 0xe000>;
>> +               };
>> +
>> +               tcsr_mutex_regs: syscon@193d000 {
>> +                       compatible = "syscon";
>> +                       reg = <0x01905000 0x8000>;
>> +               };
>> +
>> +               apcs_glb: mailbox@b111000 {
> 
> This is the same as the syscon above. What's going on?
> 
>> +                       compatible = "qcom,ipq8074-apcs-apps-global";
>> +                       reg = <0x0b111000 0x1000>;
>> +
>> +                       #mbox-cells = <1>;
>> +               };
  Sorry for the delayed response. Will have this addressed and post a v3.

  Regards,
  Gokul