| Message ID | 1559737395-28542-1-git-send-email-open.sudheer@gmail.com |
|---|---|
| Headers | show |
| Series | *** Cover Letter: patch submission for AST2500 UART driver *** | expand |
On Wed, Jun 05, 2019 at 05:53:11PM +0530, sudheer.v wrote: > From: sudheer Kumar veliseti <sudheer.open@gmail.com> > > Signed-off-by: sudheer veliseti <sudheer.open@gmail.com> > --- I can not take a patch without any changelog text at all, especially for one that is 1928 lines long :( Please provide a proper changelog and I will be glad to review it. thanks, greg k-h
On Wed, Jun 05, 2019 at 05:53:11PM +0530, sudheer.v wrote: > + > +#define CONFIG_UART_DMA_DEBUG > + > +#ifdef CONFIG_UART_DMA_DEBUG > +#define UART_DBG(fmt, args...) pr_debug("%s() " fmt, __func__, ## args) > +#else > +#define UART_DBG(fmt, args...) > +#endif > + > +#define CONFIG_UART_TX_DMA_DEBUG 1 > + > +#ifdef CONFIG_UART_TX_DMA_DEBUG > +#define UART_TX_DBG(fmt, args...) pr_debug("%s()"fmt, __func__, ## args) > +#else > +#define UART_TX_DBG(fmt, args...) > +#endif Why have you left debugging on here? Why does your tiny driver have custom debug macros? Please always use the in-kernel standard ones so you can dynamically enable/disable them as needed without having to rebuild the code. I stopped reading here, sorry. greg k-h
From: sudheer Kumar veliseti <sudheer.open@gmail.com> Hi, The below mentioned patches are for AST2500 UART driver. AST2500 has dedicated Uart DMA controller which has 12 sets of Tx and RX channels connected to UART controller directly. Since the DMA controller have dedicated buffers and registers, there would be little benifit in adding DMA framework overhead. So the software for DMA controller is included within the UART driver itself. Thanks and Regards Sudheer.V sudheer veliseti (5): AST2500 DMA UART driver build configuration for AST2500 DMA UART driver DT nodes for AST2500 DMA UART driver defconfig and MAINTAINERS updated for AST2500 DMA UART driver Documentation: DT bindings AST2500 DMA UART driver .../bindings/serial/ast2500-dma-uart.txt | 40 + MAINTAINERS | 13 + arch/arm/boot/dts/aspeed-ast2500-evb.dts | 21 + arch/arm/boot/dts/aspeed-g5.dtsi | 71 +- arch/arm/configs/aspeed_g5_defconfig | 1 + .../tty/serial/8250/8250_ast2500_uart_dma.c | 1928 +++++++++++++++++ drivers/tty/serial/8250/Kconfig | 35 +- drivers/tty/serial/8250/Makefile | 1 + 8 files changed, 2105 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/serial/ast2500-dma-uart.txt create mode 100644 drivers/tty/serial/8250/8250_ast2500_uart_dma.c