| Message ID | 1543571742-17995-1-git-send-email-p.paillet@st.com |
|---|---|
| Headers | show |
| Series | Introduce STPMIC1 PMIC Driver | expand |
On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > STMicroelectronics. > The STPMIC1 regulators supply power to an application processor as well as > to external system peripherals such as DDR, Flash memories and system > devices. It also features onkey button input and an hardware watchdog. > The STPMIC1 is controlled via I2C. > > Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > as parent. > > STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > > Pascal Paillet (7): > changes in v7: > * rebase on regul/for-next > > dt-bindings: mfd: document stpmic1 > mfd: stpmic1: add stpmic1 driver > dt-bindings: input: document stpmic1 pmic onkey > input: stpmic1: add stpmic1 onkey driver > dt-bindings: watchdog: document stpmic1 pmic watchdog > watchdog: stpmic1: add stpmic1 watchdog driver > regulator: stpmic1: fix regulator_lock usage > > .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 +++ > .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ++++++ > .../bindings/watchdog/st,stpmic1-wdt.txt | 11 ++ > drivers/input/misc/Kconfig | 11 ++ > drivers/input/misc/Makefile | 2 + > drivers/input/misc/stpmic1_onkey.c | 198 +++++++++++++++++++ > drivers/mfd/Kconfig | 16 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/stpmic1.c | 213 +++++++++++++++++++++ > drivers/regulator/stpmic1_regulator.c | 2 +- Is it just Mark you're waiting on now? > drivers/watchdog/Kconfig | 12 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/stpmic1_wdt.c | 139 ++++++++++++++ > include/dt-bindings/mfd/st,stpmic1.h | 50 +++++ > include/linux/mfd/stpmic1.h | 212 ++++++++++++++++++++ > 15 files changed, 956 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt > create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt > create mode 100644 drivers/input/misc/stpmic1_onkey.c > create mode 100644 drivers/mfd/stpmic1.c > create mode 100644 drivers/watchdog/stpmic1_wdt.c > create mode 100644 include/dt-bindings/mfd/st,stpmic1.h > create mode 100644 include/linux/mfd/stpmic1.h >
Hi Lee, Le 12/03/2018 08:11 AM, Lee Jones a écrit : > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > >> The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from >> STMicroelectronics. >> The STPMIC1 regulators supply power to an application processor as well as >> to external system peripherals such as DDR, Flash memories and system >> devices. It also features onkey button input and an hardware watchdog. >> The STPMIC1 is controlled via I2C. >> >> Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and >> irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd >> as parent. >> >> STPMIC1 MFD and regulator drivers maybe mandatory at boot time. >> >> Pascal Paillet (7): >> changes in v7: >> * rebase on regul/for-next >> >> dt-bindings: mfd: document stpmic1 >> mfd: stpmic1: add stpmic1 driver >> dt-bindings: input: document stpmic1 pmic onkey >> input: stpmic1: add stpmic1 onkey driver >> dt-bindings: watchdog: document stpmic1 pmic watchdog >> watchdog: stpmic1: add stpmic1 watchdog driver >> regulator: stpmic1: fix regulator_lock usage >> >> .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 +++ >> .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ++++++ >> .../bindings/watchdog/st,stpmic1-wdt.txt | 11 ++ >> drivers/input/misc/Kconfig | 11 ++ >> drivers/input/misc/Makefile | 2 + >> drivers/input/misc/stpmic1_onkey.c | 198 +++++++++++++++++++ >> drivers/mfd/Kconfig | 16 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/stpmic1.c | 213 +++++++++++++++++++++ >> drivers/regulator/stpmic1_regulator.c | 2 +- > Is it just Mark you're waiting on now? It is ok now, Mark has applied the patch. Evrey thing has been acked now. What is the nex step ? >> drivers/watchdog/Kconfig | 12 ++ >> drivers/watchdog/Makefile | 1 + >> drivers/watchdog/stpmic1_wdt.c | 139 ++++++++++++++ >> include/dt-bindings/mfd/st,stpmic1.h | 50 +++++ >> include/linux/mfd/stpmic1.h | 212 ++++++++++++++++++++ >> 15 files changed, 956 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt >> create mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt >> create mode 100644 drivers/input/misc/stpmic1_onkey.c >> create mode 100644 drivers/mfd/stpmic1.c >> create mode 100644 drivers/watchdog/stpmic1_wdt.c >> create mode 100644 include/dt-bindings/mfd/st,stpmic1.h >> create mode 100644 include/linux/mfd/stpmic1.h >>
On Tue, 04 Dec 2018, Pascal PAILLET-LME wrote: > Le 12/03/2018 08:11 AM, Lee Jones a écrit : > > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > > > >> The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > >> STMicroelectronics. > >> The STPMIC1 regulators supply power to an application processor as well as > >> to external system peripherals such as DDR, Flash memories and system > >> devices. It also features onkey button input and an hardware watchdog. > >> The STPMIC1 is controlled via I2C. > >> > >> Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > >> irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > >> as parent. > >> > >> STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > >> > >> Pascal Paillet (7): > >> changes in v7: > >> * rebase on regul/for-next > >> > >> dt-bindings: mfd: document stpmic1 > >> mfd: stpmic1: add stpmic1 driver > >> dt-bindings: input: document stpmic1 pmic onkey > >> input: stpmic1: add stpmic1 onkey driver > >> dt-bindings: watchdog: document stpmic1 pmic watchdog > >> watchdog: stpmic1: add stpmic1 watchdog driver > >> regulator: stpmic1: fix regulator_lock usage > >> > >> .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 +++ > >> .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ++++++ > >> .../bindings/watchdog/st,stpmic1-wdt.txt | 11 ++ > >> drivers/input/misc/Kconfig | 11 ++ > >> drivers/input/misc/Makefile | 2 + > >> drivers/input/misc/stpmic1_onkey.c | 198 +++++++++++++++++++ > >> drivers/mfd/Kconfig | 16 ++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/stpmic1.c | 213 +++++++++++++++++++++ > >> drivers/regulator/stpmic1_regulator.c | 2 +- > > Is it just Mark you're waiting on now? > It is ok now, Mark has applied the patch. > Evrey thing has been acked now. What is the nex step ? Mark has applied patch 7? Why don't I see that? Should you have removed it from this set?
pascal paillet (p.paillet@st.com) Le Mans / France Microcontrollers and Digital ICs Group | Application Development TEL: +33.(0)2.44.02.74.69 | TINA: 166 7469 Le 12/05/2018 10:36 AM, Lee Jones a écrit : > On Tue, 04 Dec 2018, Pascal PAILLET-LME wrote: >> Le 12/03/2018 08:11 AM, Lee Jones a écrit : >>> On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: >>> >>>> The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from >>>> STMicroelectronics. >>>> The STPMIC1 regulators supply power to an application processor as well as >>>> to external system peripherals such as DDR, Flash memories and system >>>> devices. It also features onkey button input and an hardware watchdog. >>>> The STPMIC1 is controlled via I2C. >>>> >>>> Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and >>>> irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd >>>> as parent. >>>> >>>> STPMIC1 MFD and regulator drivers maybe mandatory at boot time. >>>> >>>> Pascal Paillet (7): >>>> changes in v7: >>>> * rebase on regul/for-next >>>> >>>> dt-bindings: mfd: document stpmic1 >>>> mfd: stpmic1: add stpmic1 driver >>>> dt-bindings: input: document stpmic1 pmic onkey >>>> input: stpmic1: add stpmic1 onkey driver >>>> dt-bindings: watchdog: document stpmic1 pmic watchdog >>>> watchdog: stpmic1: add stpmic1 watchdog driver >>>> regulator: stpmic1: fix regulator_lock usage >>>> >>>> .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 +++ >>>> .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ++++++ >>>> .../bindings/watchdog/st,stpmic1-wdt.txt | 11 ++ >>>> drivers/input/misc/Kconfig | 11 ++ >>>> drivers/input/misc/Makefile | 2 + >>>> drivers/input/misc/stpmic1_onkey.c | 198 +++++++++++++++++++ >>>> drivers/mfd/Kconfig | 16 ++ >>>> drivers/mfd/Makefile | 1 + >>>> drivers/mfd/stpmic1.c | 213 +++++++++++++++++++++ >>>> drivers/regulator/stpmic1_regulator.c | 2 +- >>> Is it just Mark you're waiting on now? >> It is ok now, Mark has applied the patch. >> Evrey thing has been acked now. What is the nex step ? > Mark has applied patch 7? > > Why don't I see that? Should you have removed it from this set? Hi Lee, I have received an email from Mark telliing that the regulator patch is applied on https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git I can see it on the branch regul/for-next. thank you, pascal >
On Wed, 05 Dec 2018, Pascal PAILLET-LME wrote: > > pascal paillet (p.paillet@st.com) Le Mans / France > Microcontrollers and Digital ICs Group | Application Development > TEL: +33.(0)2.44.02.74.69 | TINA: 166 7469 > > Le 12/05/2018 10:36 AM, Lee Jones a écrit : > > On Tue, 04 Dec 2018, Pascal PAILLET-LME wrote: > >> Le 12/03/2018 08:11 AM, Lee Jones a écrit : > >>> On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > >>> > >>>> The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > >>>> STMicroelectronics. > >>>> The STPMIC1 regulators supply power to an application processor as well as > >>>> to external system peripherals such as DDR, Flash memories and system > >>>> devices. It also features onkey button input and an hardware watchdog. > >>>> The STPMIC1 is controlled via I2C. > >>>> > >>>> Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > >>>> irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > >>>> as parent. > >>>> > >>>> STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > >>>> > >>>> Pascal Paillet (7): > >>>> changes in v7: > >>>> * rebase on regul/for-next > >>>> > >>>> dt-bindings: mfd: document stpmic1 > >>>> mfd: stpmic1: add stpmic1 driver > >>>> dt-bindings: input: document stpmic1 pmic onkey > >>>> input: stpmic1: add stpmic1 onkey driver > >>>> dt-bindings: watchdog: document stpmic1 pmic watchdog > >>>> watchdog: stpmic1: add stpmic1 watchdog driver > >>>> regulator: stpmic1: fix regulator_lock usage > >>>> > >>>> .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 +++ > >>>> .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ++++++ > >>>> .../bindings/watchdog/st,stpmic1-wdt.txt | 11 ++ > >>>> drivers/input/misc/Kconfig | 11 ++ > >>>> drivers/input/misc/Makefile | 2 + > >>>> drivers/input/misc/stpmic1_onkey.c | 198 +++++++++++++++++++ > >>>> drivers/mfd/Kconfig | 16 ++ > >>>> drivers/mfd/Makefile | 1 + > >>>> drivers/mfd/stpmic1.c | 213 +++++++++++++++++++++ > >>>> drivers/regulator/stpmic1_regulator.c | 2 +- > >>> Is it just Mark you're waiting on now? > >> It is ok now, Mark has applied the patch. > >> Evrey thing has been acked now. What is the nex step ? > > Mark has applied patch 7? > > > > Why don't I see that? Should you have removed it from this set? > Hi Lee, I have received an email from Mark telliing that the regulator > patch is applied on > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > I can see it on the branch regul/for-next. Mark, Does your patch tracker only reply to the author? Any reason why I don't see it?
On Fri, Dec 07, 2018 at 07:31:32AM +0000, Lee Jones wrote: > On Wed, 05 Dec 2018, Pascal PAILLET-LME wrote: > > Hi Lee, I have received an email from Mark telliing that the regulator > > patch is applied on > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > I can see it on the branch regul/for-next. > Does your patch tracker only reply to the author? > Any reason why I don't see it? It gets sent to anyone in patchwork. It is possible there was some problem talking to patchwork, or that your mail system has filtered the mail.
On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > STMicroelectronics. > The STPMIC1 regulators supply power to an application processor as well as > to external system peripherals such as DDR, Flash memories and system > devices. It also features onkey button input and an hardware watchdog. > The STPMIC1 is controlled via I2C. > > Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > as parent. > > STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > > Pascal Paillet (7): > changes in v7: > * rebase on regul/for-next > > dt-bindings: mfd: document stpmic1 > mfd: stpmic1: add stpmic1 driver > dt-bindings: input: document stpmic1 pmic onkey > input: stpmic1: add stpmic1 onkey driver > dt-bindings: watchdog: document stpmic1 pmic watchdog > watchdog: stpmic1: add stpmic1 watchdog driver > regulator: stpmic1: fix regulator_lock usage Could you please remove any patches which have been applied and [RESEND]? Also, is Dmitry planning on Acking: dt-bindings: input: document stpmic1 pmic onkey ... or is Rob's Ack enough?
Hello Lee, Le 12/14/2018 01:47 PM, Lee Jones a écrit : > changes in v7: > * rebase on regul/for-next > > dt-bindings: mfd: document stpmic1 > mfd: stpmic1: add stpmic1 driver > dt-bindings: input: document stpmic1 pmic onkey > input: stpmic1: add stpmic1 onkey driver > dt-bindings: watchdog: document stpmic1 pmic watchdog > watchdog: stpmic1: add stpmic1 watchdog driver > regulator: stpmic1: fix regulator_lock usage > Could you please remove any patches which have been applied and > [RESEND]? DONE, I have resent a V8 without the regulator patch. > Also, is Dmitry planning on Acking: > > dt-bindings: input: document stpmic1 pmic onkey > > ... or is Rob's Ack enough? > thank you, pascal
On Fri, Dec 14, 2018 at 12:47:01PM +0000, Lee Jones wrote: > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > > > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > > STMicroelectronics. > > The STPMIC1 regulators supply power to an application processor as well as > > to external system peripherals such as DDR, Flash memories and system > > devices. It also features onkey button input and an hardware watchdog. > > The STPMIC1 is controlled via I2C. > > > > Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > > irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > > as parent. > > > > STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > > > > Pascal Paillet (7): > > changes in v7: > > * rebase on regul/for-next > > > > dt-bindings: mfd: document stpmic1 > > mfd: stpmic1: add stpmic1 driver > > dt-bindings: input: document stpmic1 pmic onkey > > input: stpmic1: add stpmic1 onkey driver > > dt-bindings: watchdog: document stpmic1 pmic watchdog > > watchdog: stpmic1: add stpmic1 watchdog driver > > regulator: stpmic1: fix regulator_lock usage > > Could you please remove any patches which have been applied and > [RESEND]? > > Also, is Dmitry planning on Acking: > > dt-bindings: input: document stpmic1 pmic onkey > > ... or is Rob's Ack enough? For bindings I normally defer to Rob (unless I see something that really bugs me and then I'll speak up). Thanks.
On Mon, 14 Jan 2019, dmitry.torokhov@gmail.com wrote: > On Fri, Dec 14, 2018 at 12:47:01PM +0000, Lee Jones wrote: > > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > > > > > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > > > STMicroelectronics. > > > The STPMIC1 regulators supply power to an application processor as well as > > > to external system peripherals such as DDR, Flash memories and system > > > devices. It also features onkey button input and an hardware watchdog. > > > The STPMIC1 is controlled via I2C. > > > > > > Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and > > > irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd > > > as parent. > > > > > > STPMIC1 MFD and regulator drivers maybe mandatory at boot time. > > > > > > Pascal Paillet (7): > > > changes in v7: > > > * rebase on regul/for-next > > > > > > dt-bindings: mfd: document stpmic1 > > > mfd: stpmic1: add stpmic1 driver > > > dt-bindings: input: document stpmic1 pmic onkey > > > input: stpmic1: add stpmic1 onkey driver > > > dt-bindings: watchdog: document stpmic1 pmic watchdog > > > watchdog: stpmic1: add stpmic1 watchdog driver > > > regulator: stpmic1: fix regulator_lock usage > > > > Could you please remove any patches which have been applied and > > [RESEND]? > > > > Also, is Dmitry planning on Acking: > > > > dt-bindings: input: document stpmic1 pmic onkey > > > > ... or is Rob's Ack enough? > > For bindings I normally defer to Rob (unless I see something that really > bugs me and then I'll speak up). I usually do the opposite. Seeing as Rob is pretty heavily laden with DT patches, I tend to review/apply patches which do not add new DT properties and/or are obvious/trivial and leave Rob to the rest. Your train-set though of course, your decision.