| Message ID | 1539172376-19269-1-git-send-email-govinds@codeaurora.org |
|---|---|
| Headers | show |
| Series | Enable ath10k wcn3990 wifi driver support on sdm845 | expand |
On Wed, Oct 10, 2018 at 05:22:53PM +0530, Govind Singh wrote: > This series enables ath10k wifi driver support for WCN3990 target > on sdm845 SOC. This series also updates the missing dt binding documentation > and adds optional iommu property. For the series: Reviewed-by: Brian Norris <briannorris@chromium.org> Tested-by: Brian Norris <briannorris@chromium.org> Thanks!
Hi, On Wed, Oct 10, 2018 at 4:53 AM Govind Singh <govinds@codeaurora.org> wrote: > > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on SDM845 soc. > > Signed-off-by: Govind Singh <govinds@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 ++++++++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 26 ++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index eedfaf8..b89b8dd 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts nit: it's usually considered nicer to split the patch into two: one which adds the node to the SoC file and one which enables it in a board file. > + wlan_msa_mem: reserved-memory@96700000 { Everything else calls this "memory@", not "reserved-memory@". Presumably someone (like Rob H?) thought that it should be "memory". Please follow the pattern. > + no-map; > + reg = <0 0x96700000 0 0x100000>; nit: though it doesn't really matter, it'd be nice to follow the pattern and put "reg" above "no-map" like all the other nodes in this section. > + }; > }; > > cpus { > @@ -1403,5 +1408,26 @@ > status = "disabled"; > }; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + status = "disabled"; > + reg = <0x18800000 0x800000>; > + reg-names = "membase"; > + memory-region = <&wlan_msa_mem>; > + interrupts = > + <0 413 0 /* CE0 */ >, > + <0 414 0 /* CE1 */ >, > + <0 415 0 /* CE2 */ >, > + <0 416 0 /* CE3 */ >, > + <0 417 0 /* CE4 */ >, > + <0 418 0 /* CE5 */ >, > + <0 420 0 /* CE6 */ >, > + <0 421 0 /* CE7 */ >, > + <0 422 0 /* CE8 */ >, > + <0 423 0 /* CE9 */ >, > + <0 424 0 /* CE10 */ >, > + <0 425 0 /* CE11 */ >; Please change all the above to look like: <GIC_SPI num IRQ_TYPE_LEVEL_HIGH> ...specifically: * GIC_SPI is 0, but GIC_SPI is more documenting. * having 0 for the final element means 'IRQ_TYPE_NONE'. On newer kernels commit 6ef6386ef7c1 ("irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONE") will cause loud yells if you do this. * I don't see what the comments about "/* CE# */ buy you. Remove them. -Doug
Quoting Govind Singh (2018-10-10 04:52:55) > @@ -1403,5 +1408,26 @@ > status = "disabled"; > }; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + status = "disabled"; > + reg = <0x18800000 0x800000>; > + reg-names = "membase"; > + memory-region = <&wlan_msa_mem>; > + interrupts = > + <0 413 0 /* CE0 */ >, Please specify these as GIC_SPI and give trigger types (level high I guess?). I'd also drop the comment and add interrupt-names to match the comment. It's self documenting that way. > + <0 414 0 /* CE1 */ >, > + <0 415 0 /* CE2 */ >, > + <0 416 0 /* CE3 */ >, > + <0 417 0 /* CE4 */ >, > + <0 418 0 /* CE5 */ >, > + <0 420 0 /* CE6 */ >, > + <0 421 0 /* CE7 */ >, > + <0 422 0 /* CE8 */ >, > + <0 423 0 /* CE9 */ >, > + <0 424 0 /* CE10 */ >, > + <0 425 0 /* CE11 */ >;
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property. Changes since v2: dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module device node patch from the series as dependent patch is not yet merged. Enabled status flag from sdm845-mtp.dts. Changes since v1: Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi. Govind Singh (3): dt: bindings: add missing dt properties for WCN3990 wifi node dts: arm64/sdm845: Add WCN3990 WLAN module device node dt: bindings: add bindings for wifi iommu node .../bindings/net/wireless/qcom,ath10k.txt | 33 +++++++++++++++++----- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 ++++++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 26 +++++++++++++++++ 3 files changed, 60 insertions(+), 7 deletions(-)