diff mbox

[rebase] binutils: Fix elf2flt compile on more modern systems

Message ID 1417789393-10413-1-git-send-email-pizza@shaftnet.org
State Accepted
Headers show

Commit Message

Solomon Peachy Dec. 5, 2014, 2:23 p.m. UTC
Without this fix, elf2flt will blow up complaining that it can't resolve
dlopen() and friends.  One has to explicitly pass '-ldl' on the final
linking command line, because the system linker is not resolving
indirect dependent shared libraries.

I've needed to this patch for several years on Fedora systems.

Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
---
 scripts/build/binutils/binutils.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Bryan Hundven Dec. 5, 2014, 9:10 p.m. UTC | #1
Solomon,

On Fri, Dec 5, 2014 at 6:23 AM, Solomon Peachy <pizza@shaftnet.org> wrote:
> Without this fix, elf2flt will blow up complaining that it can't resolve
> dlopen() and friends.  One has to explicitly pass '-ldl' on the final
> linking command line, because the system linker is not resolving
> indirect dependent shared libraries.
>
> I've needed to this patch for several years on Fedora systems.
>
> Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
> ---
>  scripts/build/binutils/binutils.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
> index b6207be..c935f8d 100644
> --- a/scripts/build/binutils/binutils.sh
> +++ b/scripts/build/binutils/binutils.sh
> @@ -291,6 +291,7 @@ do_elf2flt_backend() {
>      CT_DoExecLog CFG                                            \
>      CFLAGS="${cflags}"                                          \
>      LDFLAGS="${ldflags}"                                        \
> +    LIBS="-ldl"                                                 \
>      "${CT_SRC_DIR}/elf2flt-${CT_ELF2FLT_VERSION}/configure"     \
>          --build=${CT_BUILD}                                     \
>          --host=${host}                                          \
> --
> 1.9.3

Accepted!

Thanks,

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq
diff mbox

Patch

diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
index b6207be..c935f8d 100644
--- a/scripts/build/binutils/binutils.sh
+++ b/scripts/build/binutils/binutils.sh
@@ -291,6 +291,7 @@  do_elf2flt_backend() {
     CT_DoExecLog CFG                                            \
     CFLAGS="${cflags}"                                          \
     LDFLAGS="${ldflags}"                                        \
+    LIBS="-ldl"                                                 \
     "${CT_SRC_DIR}/elf2flt-${CT_ELF2FLT_VERSION}/configure"     \
         --build=${CT_BUILD}                                     \
         --host=${host}                                          \