From patchwork Mon Jul 2 08:33:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 168721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id A2A122C00E5 for ; Tue, 3 Jul 2012 17:40:25 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0F4168D868; Tue, 3 Jul 2012 07:40:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PA2XAoT4Z8ER; Tue, 3 Jul 2012 07:40:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 8F0598D706; Tue, 3 Jul 2012 07:40:13 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BA28B8F753 for ; Tue, 3 Jul 2012 07:40:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B7B5BA00B4 for ; Tue, 3 Jul 2012 07:40:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YlslF3FmlwTt for ; Tue, 3 Jul 2012 07:40:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by hemlock.osuosl.org (Postfix) with ESMTPS id E85C5A003A for ; Tue, 3 Jul 2012 07:40:10 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SlxiP-0002EL-MS for buildroot@uclibc.org; Tue, 03 Jul 2012 09:40:05 +0200 Received: from ram94-11-88-187-113-157.fbx.proxad.net ([88.187.113.157]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 03 Jul 2012 09:40:05 +0200 Received: from romain.izard.pro by ram94-11-88-187-113-157.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 03 Jul 2012 09:40:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: buildroot@uclibc.org From: Romain Izard Date: Mon, 2 Jul 2012 08:33:24 +0000 (UTC) Lines: 35 Message-ID: References: <1340654541-10427-1-git-send-email-spdawson@gmail.com> X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ram94-11-88-187-113-157.fbx.proxad.net User-Agent: slrn/pre1.0.0-18 (Linux) Subject: Re: [Buildroot] [PATCH] Add /var/www to device table X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On 2012-06-25, spdawson@gmail.com wrote: > From: Simon Dawson > > The /var/www directory is listed in /etc/passwd in the skeleton target > filesystem as the home directory of the www-data user (uid 33). > > In the final target filesystem, /var/www should be owned by www-data. This > is important for the lighttpd package, for example. > > Signed-off-by: Simon Dawson Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable, instead of modifying the common device table ? This makes the relationship more evident. See the following example: diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk index b8aa310..34f59b2 100644 --- a/package/lighttpd/lighttpd.mk +++ b/package/lighttpd/lighttpd.mk @@ -62,4 +62,9 @@ define LIGHTTPD_UNINSTALL_TARGET_CMDS rm -rf $(TARGET_DIR)/usr/lib/lighttpd endef +# +define LIGHTTPD_PERMISSIONS +var/www d 755 33 33 - - - - - +endef + $(eval $(call AUTOTARGETS))