From patchwork Fri Mar 11 18:41:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 596468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 8E75E140180 for ; Sat, 12 Mar 2016 05:41:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=tui/Dzrj; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7EB1895F18; Fri, 11 Mar 2016 18:41:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CBYzBBSmNw4Q; Fri, 11 Mar 2016 18:41:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5CC3295F1B; Fri, 11 Mar 2016 18:41:53 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 56D911CF1DC for ; Fri, 11 Mar 2016 18:41:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5311E33C9A for ; Fri, 11 Mar 2016 18:41:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tCarNQkOsFcZ for ; Fri, 11 Mar 2016 18:41:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by silver.osuosl.org (Postfix) with ESMTPS id 23E6833C93 for ; Fri, 11 Mar 2016 18:41:48 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id n205so3953845wmf.2 for ; Fri, 11 Mar 2016 10:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=hB3tg4lPLbLUIXW0I1KcGV4BdSc+IRNyG44kRPPqCq4=; b=tui/Dzrj6YsjCUEu4II/3tj/wGhmEizRMj2Hps6tOGA35ct+V08c5rz4PTGpBUQKDq sAnkWULMPiePPgAV6A5F94xUV6aOBRvgq9O+H4OZSgrs9Vq4bAA6HHWdmnx5zBEQEp8Q RUYlBbkAq9XmrYEVFSh6NWY5XPC96F46hdHEMH70aN1SibuNRfFS1tlJwcskrULGZ35K /RXFQ1XdHTnJQs3+N7hLUz6uLGLpdLQIZuinqmGODDwY0mh8K07IIo+GRubdJCEt9YXj 5VdsTJ//G9LGfNomPBHs0QoKuanNhtM4Ni6WBHLzBkBF1AUnfHYEIAJNNizLvBn8lQsi mpEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=hB3tg4lPLbLUIXW0I1KcGV4BdSc+IRNyG44kRPPqCq4=; b=WpRZoXRBP8ktcAmXzU17lfjc7kam3TpZhZhwNK5pLbOcyrYOtZypMXWPpc13CS8mbT oDTi89BmeiSE2VLSFQeBdm53B4Une1Tnn6K0wqdAycJue5tVaLtteGWydU2S6V7oF8U2 AySYi2RkBUyewheZcSYaD8+BXyyQUNBLSxgCzt/KsweCMZ0PHPqS06YIPm+k+io8Zozt HRok2QO/66ZPMV4F6jfg8CH5QZGBO/JYc03IcQrs4tBFp3aYg6JQy8oTPM3BvNdFU7PB t7ZhsZkfSylu1VphNORy+VJ/rCIJpA/X9ZGnFuVnp62hS4MiVySM0j6xx+5GnUU/jcZu a3jg== X-Gm-Message-State: AD7BkJIaKsAomVeIOA8VH9u0IYe3V0smCupof+TnAEHfE8GZhwinVYcbcwojNL8plsX7Fw== X-Received: by 10.28.96.197 with SMTP id u188mr4652508wmb.26.1457721706769; Fri, 11 Mar 2016 10:41:46 -0800 (PST) Received: from gourin.bzh.lan (ns304657.ip-46-105-103.eu. [46.105.103.66]) by smtp.gmail.com with ESMTPSA id i5sm9705436wjx.15.2016.03.11.10.41.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Mar 2016 10:41:45 -0800 (PST) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Fri, 11 Mar 2016 19:41:34 +0100 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Cc: Thomas Petazzoni , "Yann E. MORIN" Subject: [Buildroot] [PATCH 5/9 v2] fs/ext2: use a post-gen hook rather than a post-target rule X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" post-target rules are probably not resilient to parallel builds, given that they do not depend on the image being generated first. Beside, we already have a mechanism for running stuff after the filesystem is generated, and that's called post-gen hooks. Use those hooks. Note: this basically reverts 75b6303 (rootfs-ext2: make the symlink as a _POST_TARGET) since we've now re-introduced post-gen hooks. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Reviewed-by: Romain Naour --- fs/ext2/ext2.mk | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk index 7417f81..afe44c7 100644 --- a/fs/ext2/ext2.mk +++ b/fs/ext2/ext2.mk @@ -34,13 +34,11 @@ define ROOTFS_EXT2_CMD PATH=$(BR_PATH) mke2img -d $(TARGET_DIR) $(EXT2_OPTS) -o $@ endef -rootfs-ext2-symlink: - ln -sf rootfs.ext2$(ROOTFS_EXT2_COMPRESS_EXT) $(BINARIES_DIR)/rootfs.ext$(BR2_TARGET_ROOTFS_EXT2_GEN)$(ROOTFS_EXT2_COMPRESS_EXT) - -.PHONY: rootfs-ext2-symlink - ifneq ($(BR2_TARGET_ROOTFS_EXT2_GEN),2) -ROOTFS_EXT2_POST_TARGETS += rootfs-ext2-symlink +define ROOTFS_EXT2_SYMLINK + ln -sf rootfs.ext2$(ROOTFS_EXT2_COMPRESS_EXT) $(BINARIES_DIR)/rootfs.ext$(BR2_TARGET_ROOTFS_EXT2_GEN)$(ROOTFS_EXT2_COMPRESS_EXT) +endef +ROOTFS_EXT2_POST_GEN_HOOKS += ROOTFS_EXT2_SYMLINK endif $(eval $(call ROOTFS_TARGET,ext2))