From patchwork Fri May 21 14:44:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1482254 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=HSSkBSyz; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FmqBw1B4Kz9sVt for ; Sat, 22 May 2021 00:44:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7A2EE607D5; Fri, 21 May 2021 14:44:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HGk-mqGOFVY0; Fri, 21 May 2021 14:44:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C803160725; Fri, 21 May 2021 14:44:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9B4941BF292 for ; Fri, 21 May 2021 14:44:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 88C16606F6 for ; Fri, 21 May 2021 14:44:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rmQIWGFM6NWw for ; Fri, 21 May 2021 14:44:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3DABF6059C for ; Fri, 21 May 2021 14:44:40 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id c14so19553429wrx.3 for ; Fri, 21 May 2021 07:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k1TXVnYKFffUn+8/WywPOEIOyiYaG8fmmDZOJtQ0I4o=; b=HSSkBSyzDRJq5mzr14KJ5mlLp6szDlLRbjPn8iVjJjV+MCG97ufHLYUAiaQNmi4Muk mCzUzMIHl2j7hX9W2Kllbjw5HTgGhbyI71B9WqoAkMsyE4f4xf9Kj00kSF05m8GIigop fUmBKfqNBZoinsDyO1RpMJlmbgaRKaPAMjRP19OApxGwPpp5lENRjhmR8ndraIzMcQsU RcyDIBiZLsg1C0KpnL//mEqt0XKIOpPmsocZ0tqhOZ3xYFA/ZDKmdGMh0cuV0Yxy6NTN dc1tgPy73xVfqdOGT0+ZfX0uxG7JPLncDUzppQWE/3sU9EcjjkFO0pvgMOlllFSEAkJn +sNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=k1TXVnYKFffUn+8/WywPOEIOyiYaG8fmmDZOJtQ0I4o=; b=VYiNzHz8F1cwImatMOXenXSDHAHNB+e4/jHeJlBVAb/S0NePv6PvdWa5uXypgbbvoA 7H6vzFchAFqp4JUEEW1rPAmVfHfLFn4esJEiu0/DJQLWc9KA8oSnkjQ9Fo+zxMIYBh+P YrA3Ke7HhH8iMECMcpbO3krT4fT1k7bOPd4gzyXCG6cX3vjw1vLrTXD4N4m76qvq+H1O x8R3KDwm9NaMDZ15o36Y1SPyz6HgzzSx+W2soJu5+Q9p35imgkBOSxkGGsju2UtOb6Y8 WnZHw+/WBHwRFo5VmFu4u4NGbtYvmlEk8xcgSP4qSgMrnqjsH9BO9VnPXaivI47KxcFE iwwg== X-Gm-Message-State: AOAM533w0KAhR2/92qXHpsarZzhqwBNN0yw3mn7Tn4n9PvOpVXz1rdP2 WOZZ8PHX2oarsjlbYVIuu8G7lJIAakI= X-Google-Smtp-Source: ABdhPJw74/AMjbVoXNv9dY1RYXC3Vj/4uWL9DrK9qPGHhkvjwwDhZWKlgwUgKNN4UPkjhMpCanYCxw== X-Received: by 2002:a05:6000:1865:: with SMTP id d5mr6261431wri.126.1621608278547; Fri, 21 May 2021 07:44:38 -0700 (PDT) Received: from scaer.home ([2a01:cb19:8b51:cb00:345f:578a:38f6:59a1]) by smtp.gmail.com with ESMTPSA id v11sm2899736wrs.9.2021.05.21.07.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 07:44:38 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Fri, 21 May 2021 16:44:35 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/2] package/lvm2: fix inverted logic that is confusing X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Pascal de Bruijn Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Commit ff0f55e38197 (lvm2: replace !BR2_PACKAGE_LVM2_DMSETUP_ONLY by BR2_PACKAGE_LVM2_STANDARD_INSTALL) changed a negative-logic option to a positive-logic option. However, it kept the ordering of the conditional block, which became a negatice-logic condition. This is confusing; let's fix that. Reported-by: Pascal de Bruijn Signed-off-by: Yann E. MORIN --- package/lvm2/lvm2.mk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk index 224dbf5d54..00baa50a86 100644 --- a/package/lvm2/lvm2.mk +++ b/package/lvm2/lvm2.mk @@ -46,13 +46,13 @@ else LVM2_CONF_OPTS += --disable-selinux endif -ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),) +ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y) +LVM2_INSTALL_STAGING_OPTS += install +LVM2_INSTALL_TARGET_OPTS += install +else LVM2_MAKE_OPTS = device-mapper LVM2_INSTALL_STAGING_OPTS += install_device-mapper LVM2_INSTALL_TARGET_OPTS += install_device-mapper -else -LVM2_INSTALL_STAGING_OPTS += install -LVM2_INSTALL_TARGET_OPTS += install endif ifeq ($(BR2_INIT_SYSTEMD),y)