From patchwork Mon Jul 13 10:31:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 494491 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id EC1011402AE for ; Mon, 13 Jul 2015 20:32:14 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=t6RwPaY/; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 21A2E917DC; Mon, 13 Jul 2015 10:32:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nVuDkkFZX9qw; Mon, 13 Jul 2015 10:32:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 58312917DA; Mon, 13 Jul 2015 10:32:11 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4CAA51C0361 for ; Mon, 13 Jul 2015 10:32:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 480CD95150 for ; Mon, 13 Jul 2015 10:32:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HgGF8dD62YPT for ; Mon, 13 Jul 2015 10:32:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by hemlock.osuosl.org (Postfix) with ESMTPS id CFDCA8B0A7 for ; Mon, 13 Jul 2015 10:32:08 +0000 (UTC) Received: by wicmv11 with SMTP id mv11so57880641wic.1 for ; Mon, 13 Jul 2015 03:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1yx+Yvj4uwu/UNibWUN9j+pdtm43gF4BKnwYXFGJcVM=; b=t6RwPaY/Ssv60bQ2xpHGzqVQRFLV5hjCm25XdbRN6O9njB+U9u4DjQQeN6S6D/vXtb Qi3UK9Xm87J7pJN8DXD6Me97xKBcw4FIVYWW/Ta9gG1XSGKlW8PNiAUnl21UDLRrK42v KIHOo2wsA3xfI/+/RyAujnCoyN0SLKV+xWBZJ/JxmY49HR5jVFvuhp+b7/3o6uc1ZQcg LyOXuvJKxt2jA1N4jmcN24moAFbRsQyMwxquZMBsMqsH3kcVJwXe8zPIN742OpTHU0Yj 0NHtKklOYeYYEhKCvmYyMWmN0ld4CcXEU5XNCRgyUME7ECq72/3oWSMHAPXCpAQnh4V+ WfEA== X-Received: by 10.194.83.70 with SMTP id o6mr64304781wjy.44.1436783527547; Mon, 13 Jul 2015 03:32:07 -0700 (PDT) Received: from gourin.home (ns304657.ip-46-105-103.eu. [46.105.103.66]) by smtp.gmail.com with ESMTPSA id ju2sm13811469wid.12.2015.07.13.03.32.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Jul 2015 03:32:06 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Mon, 13 Jul 2015 12:31:58 +0200 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH 1/7 v2] core/pkg-kconfig: don't enforce check for config file when not building X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Currently, this is triggering the error message: make randconfig make source Only limit the check to enforce a config file being set to when we are actually building, like is done in the various kconfig-using packages. Signed-off-by: "Yann E. MORIN" --- Changes v1 -> v2: - use BR_BUILDING in its own ifeq, do not coalesce with the existing ifeq (Thomas) - use $$ instead of $ to evaluate BR_BUILDING --- package/pkg-kconfig.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk index c86c340..f708875 100644 --- a/package/pkg-kconfig.mk +++ b/package/pkg-kconfig.mk @@ -90,9 +90,11 @@ $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done ifeq ($$($$($(2)_KCONFIG_VAR)),y) # FOO_KCONFIG_FILE is required +ifeq ($$(BR_BUILDING),y) ifeq ($$($(2)_KCONFIG_FILE),) $$(error Internal error: no value specified for $(2)_KCONFIG_FILE) endif +endif # Configuration editors (menuconfig, ...) #