diff mbox series

[next] package/libcurl: make sure openssl supports DES

Message ID d358be700aa4dcfe0df4ba7f15832d4721f718ba.1621450908.git.baruch@tkos.co.il
State Accepted
Headers show
Series [next] package/libcurl: make sure openssl supports DES | expand

Commit Message

Baruch Siach May 19, 2021, 7:01 p.m. UTC
DES support in openssl is optional since commit a83d41867c8d
("package/libopenssl: add option to enable some features"). curl uses
DES support in openssl when enabled. Select DES support to avoid build
failure.

Fixes:
http://autobuild.buildroot.net/results/8931fd2b71eb2490cdc041b47eff58377ac823da/
http://autobuild.buildroot.net/results/f159195adf05c375d7d314a270afd3a55d43ebdd/
http://autobuild.buildroot.net/results/e143c75bccd7bcd4216954b76099404a38cf9bc1/

Cc: Erwan GAUTRON <erwan.gautron@bertin.fr>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libcurl/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Voss, Samuel M Collins via buildroot May 19, 2021, 8:03 p.m. UTC | #1
Baruch,

> From: Baruch Siach <baruch@tkos.co.il>
> Sent: Wednesday, May 19, 2021 2:01 PM
> To: buildroot@busybox.net <buildroot@busybox.net>
> Cc: Weber, Matthew L Collins <Matthew.Weber@collins.com>; Baruch Siach <baruch@tkos.co.il>; Erwan GAUTRON <erwan.gautron@bertin.fr>
> Subject: [External] [PATCH next] package/libcurl: make sure openssl supports DES
>  
> DES support in openssl is optional since commit a83d41867c8d
> ("package/libopenssl: add option to enable some features"). curl uses
> DES support in openssl when enabled. Select DES support to avoid build
> failure.
>
> Fixes:
> https://urldefense.com/v3/__http://autobuild.buildroot.net/results/8931fd2b71eb2490cdc041b47eff58377ac823da/__;!!MvWE!UmmU9q2BBP6QgUqCoJpck8B7DmzN-ei9QwOYrMj6DeAe2jpT3oKVDmRmO5OH6awGw02G$
> https://urldefense.com/v3/__http://autobuild.buildroot.net/results/f159195adf05c375d7d314a270afd3a55d43ebdd/__;!!MvWE!UmmU9q2BBP6QgUqCoJpck8B7DmzN-ei9QwOYrMj6DeAe2jpT3oKVDmRmO5OH6RjpJmrT$
> https://urldefense.com/v3/__http://autobuild.buildroot.net/results/e143c75bccd7bcd4216954b76099404a38cf9bc1/__;!!MvWE!UmmU9q2BBP6QgUqCoJpck8B7DmzN-ei9QwOYrMj6DeAe2jpT3oKVDmRmO5OH6cOXd9jD$
>
> Cc: Erwan GAUTRON <erwan.gautron@bertin.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Matthew Weber <matthew.weber@collins.com>
Yann E. MORIN May 19, 2021, 8:14 p.m. UTC | #2
Baruch, All,

On 2021-05-19 22:01 +0300, Baruch Siach spake thusly:
> DES support in openssl is optional since commit a83d41867c8d
> ("package/libopenssl: add option to enable some features"). curl uses
> DES support in openssl when enabled. Select DES support to avoid build
> failure.
> 
> Fixes:
> http://autobuild.buildroot.net/results/8931fd2b71eb2490cdc041b47eff58377ac823da/
> http://autobuild.buildroot.net/results/f159195adf05c375d7d314a270afd3a55d43ebdd/
> http://autobuild.buildroot.net/results/e143c75bccd7bcd4216954b76099404a38cf9bc1/
> 
> Cc: Erwan GAUTRON <erwan.gautron@bertin.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcurl/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcurl/Config.in b/package/libcurl/Config.in
> index b89c46f5eff7..466f9ee3a1c7 100644
> --- a/package/libcurl/Config.in
> +++ b/package/libcurl/Config.in
> @@ -51,6 +51,7 @@ choice
>  config BR2_PACKAGE_LIBCURL_OPENSSL
>  	bool "OpenSSL"
>  	depends on BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
>  
>  config BR2_PACKAGE_LIBCURL_BEARSSL
>  	bool "BearSSL"
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/libcurl/Config.in b/package/libcurl/Config.in
index b89c46f5eff7..466f9ee3a1c7 100644
--- a/package/libcurl/Config.in
+++ b/package/libcurl/Config.in
@@ -51,6 +51,7 @@  choice
 config BR2_PACKAGE_LIBCURL_OPENSSL
 	bool "OpenSSL"
 	depends on BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
 
 config BR2_PACKAGE_LIBCURL_BEARSSL
 	bool "BearSSL"