diff mbox

[12/20,RFC] package/libcec: needs libudev, not a udev daemon

Message ID d063b08a5cb278d84fcdd031906cd9f2faf3ac8f.1402699915.git.yann.morin.1998@free.fr
State Changes Requested
Headers show

Commit Message

Yann E. MORIN June 13, 2014, 11:02 p.m. UTC 
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

libcec is happy enough with just a libudev, which it uses to
enumerate CEC devices, and does not require a udev daemon.

Propagate the new dependency to XBMC.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libcec/libcec.mk | 4 ++--
 package/xbmc/Config.in   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Bernd Kuhls July 11, 2014, 8:20 p.m. UTC | #1 
Hi,

"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in news:d063b08a5cb278d84fcdd031906cd9f2faf3ac8f.1402699915.git.yann.morin.1998@free.fr:

> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> libcec is happy enough with just a libudev, which it uses to
> enumerate CEC devices, and does not require a udev daemon.
> 
> Propagate the new dependency to XBMC.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---

[...]

> -comment "hdmi cec support needs udev /dev management and a toolchain w/ dynamic library"
> -     depends on BR2_PREFER_STATIC_LIB || !BR2_PACKAGE_HAS_UDEV
> +comment "hdmi cec support needs a toolchain w/ dynamic library"
> +     depends on BR2_PREFER_STATIC_LIB

I would like to keep a comment to inform users that an udev provider is
needed to have cec support in xbmc.

Besides that:
Acked-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Regards, Bernd
diff mbox

Patch

diff --git a/package/libcec/libcec.mk b/package/libcec/libcec.mk
index ad919fc..49e4dbd 100644
--- a/package/libcec/libcec.mk
+++ b/package/libcec/libcec.mk
@@ -18,8 +18,8 @@  ifeq ($(BR2_PACKAGE_LOCKDEV),y)
 LIBCEC_DEPENDENCIES += lockdev
 endif
 
-ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
-LIBCEC_DEPENDENCIES += udev
+ifeq ($(BR2_PACKAGE_HAS_LIBUDEV),y)
+LIBCEC_DEPENDENCIES += libudev
 endif
 
 ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
diff --git a/package/xbmc/Config.in b/package/xbmc/Config.in
index 592fdc1..db888ac 100644
--- a/package/xbmc/Config.in
+++ b/package/xbmc/Config.in
@@ -99,14 +99,14 @@  comment "libbluray support needs a toolchain w/ dynamic library"
 config BR2_PACKAGE_XBMC_LIBCEC
 	bool "hdmi cec"
 	depends on !BR2_PREFER_STATIC_LIB # libcec
-	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_PACKAGE_HAS_LIBUDEV # libcec
 	select BR2_PACKAGE_LIBCEC
 	help
 	  Enable CEC (Consumer Electronics Control) support.
 	  Select this if you want XBMC to support HDMI CEC.
 
-comment "hdmi cec support needs udev /dev management and a toolchain w/ dynamic library"
-	depends on BR2_PREFER_STATIC_LIB || !BR2_PACKAGE_HAS_UDEV
+comment "hdmi cec support needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
 
 config BR2_PACKAGE_XBMC_LIBMICROHTTPD
 	bool "web server"