diff mbox series

[3/4,v2] support/docker: allow the br-user to becone root

Message ID c0ad050e8feddfcabfe5711eec297a71d2923da0.1589751688.git.yann.morin.1998@free.fr
State Changes Requested
Headers show
Series [1/4,v2] support/docker: rename the Dockerfile and its accompanying file | expand

Commit Message

Yann E. MORIN May 17, 2020, 9:41 p.m. UTC
When our Dockerfiles (and images) get reused by users, they might need
to locally add new packages or tweak the iamge to heir local needs.

As such, register the br-user to become root by running (exactly!):
    $ sudo su -

This will allow acutally becoing root without prompting for a password,
but no other command will be accepted, and no other paramter will be
accepted either.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc; Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 support/docker/Dockerfile.debian-stretch | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Romain Naour June 14, 2020, 7:57 p.m. UTC | #1
Le 17/05/2020 à 23:41, Yann E. MORIN a écrit :
> When our Dockerfiles (and images) get reused by users, they might need
> to locally add new packages or tweak the iamge to heir local needs.
> 
> As such, register the br-user to become root by running (exactly!):
>     $ sudo su -
> 
> This will allow acutally becoing root without prompting for a password,
> but no other command will be accepted, and no other paramter will be
> accepted either.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc; Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain


> ---
>  support/docker/Dockerfile.debian-stretch | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/support/docker/Dockerfile.debian-stretch b/support/docker/Dockerfile.debian-stretch
> index 0d2ce2aa79..7ce9f406c6 100644
> --- a/support/docker/Dockerfile.debian-stretch
> +++ b/support/docker/Dockerfile.debian-stretch
> @@ -49,6 +49,7 @@ RUN apt-get install -y --no-install-recommends \
>          qemu-system-x86 \
>          rsync \
>          subversion \
> +        sudo \
>          unzip \
>          wget \
>          && \
> @@ -60,7 +61,9 @@ RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen && \
>      /usr/sbin/locale-gen
>  
>  RUN useradd -ms /bin/bash br-user && \
> -    chown -R br-user:br-user /home/br-user
> +    chown -R br-user:br-user /home/br-user && \
> +    printf 'br-user ALL=NOPASSWD: /bin/su -\n' >/etc/sudoers.d/br-user && \
> +    chmod 0440 /etc/sudoers.d/br-user
>  
>  USER br-user
>  WORKDIR /home/br-user
>
diff mbox series

Patch

diff --git a/support/docker/Dockerfile.debian-stretch b/support/docker/Dockerfile.debian-stretch
index 0d2ce2aa79..7ce9f406c6 100644
--- a/support/docker/Dockerfile.debian-stretch
+++ b/support/docker/Dockerfile.debian-stretch
@@ -49,6 +49,7 @@  RUN apt-get install -y --no-install-recommends \
         qemu-system-x86 \
         rsync \
         subversion \
+        sudo \
         unzip \
         wget \
         && \
@@ -60,7 +61,9 @@  RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen && \
     /usr/sbin/locale-gen
 
 RUN useradd -ms /bin/bash br-user && \
-    chown -R br-user:br-user /home/br-user
+    chown -R br-user:br-user /home/br-user && \
+    printf 'br-user ALL=NOPASSWD: /bin/su -\n' >/etc/sudoers.d/br-user && \
+    chmod 0440 /etc/sudoers.d/br-user
 
 USER br-user
 WORKDIR /home/br-user