From patchwork Sun Mar 2 12:59:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 325564 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id C8AFC2C007E for ; Sun, 2 Mar 2014 23:59:32 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2BF8DE846; Sun, 2 Mar 2014 12:59:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lanHeoLcTBiN; Sun, 2 Mar 2014 12:59:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8AFF1E691; Sun, 2 Mar 2014 12:59:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D0A3B1BF9DB for ; Sun, 2 Mar 2014 12:59:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CD2ECE6C7 for ; Sun, 2 Mar 2014 12:59:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id svAkSmmyhCFj for ; Sun, 2 Mar 2014 12:59:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by fraxinus.osuosl.org (Postfix) with ESMTPS id ED1D6E775 for ; Sun, 2 Mar 2014 12:59:28 +0000 (UTC) Received: by mail-ee0-f49.google.com with SMTP id b57so3347695eek.8 for ; Sun, 02 Mar 2014 04:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:content-transfer-encoding:subject :message-id:user-agent:date:from:to; bh=5IAHVnlqcp9tcyzinDCmimGod3T71wZeiWuUCNYSdxI=; b=uP1HQlEZOOVR/5/l1MaoHVYYF9V8jli+PodDqOwlDSuezsXk5KVmEPS2BwdBkIEtk3 jfFxUGOv47riklEQN8wRZaSecxGy3t+7/mMEptqjlnum3DBK0qQjsR+dQrd4Y+3SOCpr 8frTDtGz+A0eGnyTxYYScPRqxdXM4tSK5FDOcqE7YoLVDuGfBzNmrr3l9qWjm231htY8 pp3Qg7CItt7f1QVVHV0ubzHjYec2pQt5TzR7PgJfg5Gzu3n8uo7PV/eMRsJQKizuIe7N PtGYo39m011EqW1cD93sk3RqnH7qrGh+IgANGYA28sH+V/+YI+0/cOVE416Gs1wpevXE tDVA== X-Received: by 10.15.41.140 with SMTP id s12mr33742923eev.4.1393765167479; Sun, 02 Mar 2014 04:59:27 -0800 (PST) Received: from [127.0.1.1] (d54c62eeb.access.telenet.be. [84.198.46.235]) by mx.google.com with ESMTPSA id j41sm36320766eeg.10.2014.03.02.04.59.26 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 02 Mar 2014 04:59:26 -0800 (PST) MIME-Version: 1.0 X-Mercurial-Node: bce317fee03f949a279afb43e0938ed882e1e5af Message-Id: User-Agent: Mercurial-patchbomb/2.2.2 Date: Sun, 02 Mar 2014 13:59:16 +0100 From: Thomas De Schampheleire To: buildroot@buildroot.org Subject: [Buildroot] [PATCH] manual: clarify Tested-by/Reviewed-by/Acked-by tags X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net This patch updates the manual with more clarified descriptions of tags Tested-by, Reviewed-by, and Acked-by, as discussed on the Buildroot developer days in February 2014. Signed-off-by: Thomas De Schampheleire --- docs/manual/contribute.txt | 43 +++++++++++++++++++++++++++++++++++++++-- 1 files changed, 40 insertions(+), 3 deletions(-) diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt --- a/docs/manual/contribute.txt +++ b/docs/manual/contribute.txt @@ -145,10 +145,47 @@ submissions. Some tags are used to help following the state of any patch posted on the mailing-list: -Acked-by:: Indicates that the patch can be committed. +Tested-by:: Indicates that the patch has been tested in one way or + another. You are encouraged to specify what kind of testing you + performed (compile-test on architecture X and Y, runtime test on + target A, ...). This additional information helps other testers and + the maintainer. -Tested-by:: Indicates that the patch has been tested. It is useful - but not necessary to add a comment about what has been tested. +Reviewed-by:: Indicates that you code-reviewed the patch and did your + best in spotting problems, but you are not sufficiently familiar with + the area touched to provide an Acked-by tag. This means that there + may be remaining problems in the patch that would be spotted by + someone with more experience in that area. Should such problems be + detected, your Reviewed-by tag remains appropriate and you cannot + be blamed. + +Acked-by:: Indicates that you code-reviewed the patch and you are +familiar enough with the area touched to feel that the patch can be +committed as-is (no additional changes required). In case it later turns +out that something is wrong with the patch, your Acked-by could be +considered inappropriate. The difference between Acked-by and Tested-by +is thus mainly that you are prepared to take the blame on Acked patches, +but not on Reviewed ones. + +If you reviewed a patch and have comments on it, you should simply reply +to the patch stating these comments, without providing a Reviewed-by or +Acked-by tag. These tags should only be provided if you judge the patch +to be good as it is. + +It is important to note that neither Reviewed-by nor Acked-by imply +that testing has been performed. To indicate that you both reviewed and +tested the patch, provide two separate tags (Reviewed/Acked-by and +Tested-by). + +Note also that _any developer_ can provide Tested/Reviewed/Acked-by +tags, without exception, and we encourage everyone to do this. Buildroot +does not have a defined group of _core_ developers, it just so happens +that some developers are more active than others. The maintainer will +value tags according to the track record of their submitter. Tags +provided by a regular contributor will naturally be trusted more than +tags provided by a newcomer. As you provide tags more regularly, your +'trustworthiness' (in the eyes of the maintainer) will go up, but _any_ +tag provided is valuable. Buildroot's Patchwork website can be used to pull in patches for testing purposes. Please see xref:apply-patches-patchwork[] for more