From patchwork Sun Aug 17 10:53:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Kuhls X-Patchwork-Id: 380574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 567B014011B for ; Sun, 17 Aug 2014 20:55:23 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 78E3720142; Sun, 17 Aug 2014 10:55:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tFBz2-0x1gAL; Sun, 17 Aug 2014 10:55:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D51ED261BE; Sun, 17 Aug 2014 10:55:20 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id AA2781BF83B for ; Sun, 17 Aug 2014 10:55:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A216126268 for ; Sun, 17 Aug 2014 10:55:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k2MjqZoeXDht for ; Sun, 17 Aug 2014 10:55:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by silver.osuosl.org (Postfix) with ESMTPS id A77CA20142 for ; Sun, 17 Aug 2014 10:55:17 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XIy7D-0005eW-Oi for buildroot@uclibc.org; Sun, 17 Aug 2014 12:55:11 +0200 Received: from p4ff7a60d.dip0.t-ipconnect.de ([79.247.166.13]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 17 Aug 2014 12:55:11 +0200 Received: from bernd.kuhls by p4ff7a60d.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 17 Aug 2014 12:55:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: buildroot@uclibc.org From: Bernd Kuhls Date: Sun, 17 Aug 2014 12:53:00 +0200 Lines: 46 Message-ID: References: <1408227494-20770-1-git-send-email-bernd.kuhls@t-online.de> <20140817093621.664fad88@free-electrons.com> X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p4ff7a60d.dip0.t-ipconnect.de User-Agent: Xnews/2009.05.01 X-Antivirus: avast! (VPS 140817-0, 17.08.2014), Outbound message X-Antivirus-Status: Clean Subject: Re: [Buildroot] [PATCH] package/lame: Fix compile on 32bit Intel with gcc-4.9.x X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Thomas Petazzoni wrote in news:20140817093621.664fad88@free- electrons.com: > Dear Bernd Kuhls, > > On Sun, 17 Aug 2014 00:18:14 +0200, Bernd Kuhls wrote: > >> +# http://lists.linuxfromscratch.org/pipermail/blfs-dev/2014- April/027259.html >> +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56145 >> +ifeq ($(BR2_i386)$(BR2_GCC_VERSION_4_9_X),yy) >> +define LAME_COMPILE_FIX >> + $(SED) '/xmmintrin\.h/d' $(@D)/configure >> +endef >> +LAME_PRE_CONFIGURE_HOOKS += LAME_COMPILE_FIX >> +endif > > Unfortunately, this sort of check is not really acceptable, because it > doesn't work with external toolchains: BR2_GCC_VERSION_* symbols are > defined only for internal toolchains. Hi Thomas, I understand, but removing the gcc version check, which would remove support for xmmintrin.h in all i386 builds, would remove the mmx support for lame on many builds, where it is not necessary. Would something like this, extended to all external toolchains, be acceptable? In addition I could add a warning to package/lame/Config.in when gcc-4.9 is activated to inform users that mmx support is broken. Regards, Bernd --- a/toolchain/toolchain-external/Config.in +++ b/toolchain/toolchain-external/Config.in @@ -18,6 +18,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1 + select BR2_GCC_VERSION_4_9_X help Linaro toolchain for the ARM architecture. It uses Linaro GCC 2014.05 (based on gcc 4.9), Linaro GDB 2014.05 (based on