From patchwork Mon Sep 8 21:43:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ANDY KENNEDY X-Patchwork-Id: 387057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 32A7314019C for ; Tue, 9 Sep 2014 07:43:53 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id EA8E4A113F; Mon, 8 Sep 2014 21:43:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tLwBV5VqgX_b; Mon, 8 Sep 2014 21:43:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 29B9DA1046; Mon, 8 Sep 2014 21:43:50 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C097D1C2A99 for ; Mon, 8 Sep 2014 21:43:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BC9BBA0A43 for ; Mon, 8 Sep 2014 21:43:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SDEqHTUCXfXP for ; Mon, 8 Sep 2014 21:43:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from p01c11o141.mxlogic.net (p01c11o141.mxlogic.net [208.65.144.64]) by fraxinus.osuosl.org (Postfix) with ESMTPS id F0FABA0A26 for ; Mon, 8 Sep 2014 21:43:47 +0000 (UTC) Received: from unknown [76.164.174.82] (EHLO ex-hc3.corp.adtran.com) by p01c11o141.mxlogic.net(mxl_mta-8.1.0-0) over TLS secured channel with ESMTP id 2132e045.0.32289.00-343.90876.p01c11o141.mxlogic.net (envelope-from ); Mon, 08 Sep 2014 15:43:48 -0600 (MDT) X-MXL-Hash: 540e231426ba4400-5b79c5ef6fbc34271d216b4aaba72b11be9ae94a Received: from ex-mb3.corp.adtran.com ([fe80::60aa:f95:ad49:a0f1]) by ex-hc3.corp.adtran.com ([fe80::3892:20fa:600f:75c6%15]) with mapi id 14.03.0195.001; Mon, 8 Sep 2014 16:43:46 -0500 From: ANDY KENNEDY To: "buildroot@uclibc.org" Thread-Topic: [PATCH] portmap: fix static linking Thread-Index: Ac/LrfheDMBRhg9nTFiBAi9uLZ/BqQ== Date: Mon, 8 Sep 2014 21:43:45 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.115.180] MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=QeZyv6rv c=1 sm=1 tr=0 a=J+LXdEUA8t8MtBPt16/Qbg==] X-AnalysisOut: [:117 a=J+LXdEUA8t8MtBPt16/Qbg==:17 a=25rLbdZBIi8A:10 a=rMz] X-AnalysisOut: [BvKSDKJcA:10 a=qZHQZMT3apYA:10 a=C3ZOIDTcl6cA:10 a=BLceEmw] X-AnalysisOut: [cHowA:10 a=kj9zAlcOel0A:10 a=xqWC_Br6kY4A:10 a=eJNrpioGAAA] X-AnalysisOut: [A:8 a=YlVTAMxIAAAA:8 a=Bof7_AR7-DAolcdohdsA:9 a=CjuIK1q_8u] X-AnalysisOut: [gA:10 a=DvnSUQUdWHYA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2014090817); S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [76.164.174.82] Subject: [Buildroot] [PATCH] portmap: fix static linking X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap. Signed-off-by: Andy Kennedy Acked-by: Thomas Petazzoni --- buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot diff -Naur a/package/portmap/portmap.mk b/package/portmap/portmap.mk --- a/package/portmap/portmap.mk 2014-02-27 14:51:23.000000000 -0600 +++ b/package/portmap/portmap.mk 2014-09-08 16:39:13.715370478 -0500 @@ -15,8 +15,7 @@ endif define PORTMAP_BUILD_CMDS - CFLAGS="$(TARGET_CFLAGS)" \ - $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS) + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) $(PORTMAP_FLAGS) endef _______________________________________________