From patchwork Thu Mar 14 19:46:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 227790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 90EEC2C00D3 for ; Fri, 15 Mar 2013 06:46:55 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 123E58BFC5; Thu, 14 Mar 2013 19:46:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0R5ZleEm4HcD; Thu, 14 Mar 2013 19:46:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id AB2808B30F; Thu, 14 Mar 2013 19:46:51 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 59B6B8F7A3 for ; Thu, 14 Mar 2013 19:46:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A01938B30F for ; Thu, 14 Mar 2013 19:46:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0jJHqaPhhSpl for ; Thu, 14 Mar 2013 19:46:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6C2D889E7A for ; Thu, 14 Mar 2013 19:46:48 +0000 (UTC) Received: by mail-wi0-f175.google.com with SMTP id l13so4158133wie.14 for ; Thu, 14 Mar 2013 12:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:from:date:message-id:subject:to:cc :content-type; bh=UT7ndMueagZ+uEdMhsOJDQ9frxU5sZUzIB8j1XjlUXU=; b=Jac3amr/Y9z4GfWA22qHaYu/QSzeT0AS3omMKGx1ZGXf8xenveVZDHYwjfwAXNA/Bd sr508KqGfamKPldrA4E4DUXAdhFRq0JiWI00imDx4Am2EajhBuaDV4KjU7FMxT5w3JkS DgNmtbLFpAGNWf1jIitucsjPonc1qMo/8pPjP5TM+HlkIxFKq4pDAJ/B45su4+ZpHvkV 9f/3HrGhe39zpDkrdpF7i0GlAiiBAr7R4y5AjQFgXZDBaRqKgYu/x4WcXHOocLDHTqeR MColNB24+4Bx+54nYswd8QqsYwAE9KWTJK/orOTMHRAnZm8ikR8jbegsEFKz55lujbRh Pn7Q== X-Received: by 10.180.100.10 with SMTP id eu10mr36509546wib.4.1363290406798; Thu, 14 Mar 2013 12:46:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.42.134 with HTTP; Thu, 14 Mar 2013 12:46:26 -0700 (PDT) From: =?UTF-8?B?0JDQu9C10LrRgdC10Lkg0JHRgNC+0LTQutC40L0=?= Date: Thu, 14 Mar 2013 23:46:26 +0400 Message-ID: To: Ismael Luceno Cc: buildroot@busybox.net, thomas.petazzoni@free-electrons.com Subject: [Buildroot] vlc: new package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Ismael, I saw your patch for addition of vlc in Buildroot you posted back in July 2012 here http://patchwork.ozlabs.org/patch/171335/ Since then there were no changes done so patch was not accepted. I've done some minor changes for it to build successfully vlc in buildroot from latest git. You may find my changes in-lined below. And at this point I'm wondering on how to proceed to get vlc support in buildroot finally. I see these options: 1. You may incorporate my changes in your patch and post v7 in mailing list. 2. I may do this re-spin and post v7 on your behalf. 3. Or I may start from scratch based on your patch, split changes on small parts (as was suggested by Thomas earlier) and post them one-by-one. Please let me know if you're still interested in the subject and which way is preferable to you. Regards, Alexey My changes: ================== ================== diff --git a/package/multimedia/vlc/Config.in b/package/multimedia/vlc/Config.in index cdeb751..bf81d5b 100644 --- a/package/multimedia/vlc/Config.in +++ b/package/multimedia/vlc/Config.in @@ -1,5 +1,8 @@ menuconfig BR2_PACKAGE_VLC bool "vlc" + select BR2_PACKAGE_ZLIB + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_USE_WCHAR help VLC is a free and open source cross-platform multimedia player and framework that plays most multimedia files as well as DVD, Audio CD, @@ -111,6 +114,8 @@ config BR2_PACKAGE_VLC_TREMOR config BR2_PACKAGE_VLC_AVCODEC bool "FFmpeg (Many codecs)" + depends on BR2_LARGEFILE + depends on BR2_INET_IPV6 select BR2_PACKAGE_FFMPEG help There is a large number of codecs in FFmpeg/libavcodec. diff --git a/package/multimedia/vlc/vlc.mk b/package/multimedia/vlc/vlc.mk index 6a2a529..1caf709 100644 --- a/package/multimedia/vlc/vlc.mk +++ b/package/multimedia/vlc/vlc.mk @@ -24,6 +24,10 @@ VLC_CONF_OPT += --disable-rpath --enable-run-as-root \ --disable-dc1394 \ --disable-bluray +VLC_CFLAGS = $(TARGET_CFLAGS) +VLC_CFLAGS += -std=gnu99 + + ifeq ($(BR2_PACKAGE_VLC_ALSA),y) VLC_DEPENDENCIES += alsa-lib VLC_CONF_OPT += --enable-alsa @@ -363,4 +367,4 @@ define VLC_FIX_LA_FILES endef VLC_POST_BUILD_HOOKS += VLC_FIX_LA_FILES -$(eval $(call AUTOTARGETS)) +$(eval $(autotools-package))