| Message ID | CABWPoFHO0c4GoBmS0qBFhS=XGEz4qhUMF6+REWwkrngv0ZCbVg@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/libnfc: support pcsc-lite | expand |
Hello,
On Mon, 27 May 2019 10:27:03 +0200
Raul Hidalgo Caballero <deinok@deinok.com> wrote:
>
Here as well: please send with git send-email so that we can do a
proper review.
A few comments though:
- We need you to use your real name as the patch author and for the
Signed-off-by line
- Why are you making pcsc-lite a mandatory dependency of libnfc ?
Since libnfc builds fine today with pcsc-lite, it means it should be
an optional dependency. Either add a sub-option to enable the
different libnfc drivers, or automatically add pcsc-lite to the
dependencies if BR2_PACKAGE_PCSC_LITE=y.
Best regards,
Thomas
Hello Raul, On Mon, 27 May 2019 11:15:50 +0200 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Here as well: please send with git send-email so that we can do a > proper review. > > A few comments though: > > - We need you to use your real name as the patch author and for the > Signed-off-by line > > - Why are you making pcsc-lite a mandatory dependency of libnfc ? > Since libnfc builds fine today with pcsc-lite, it means it should be > an optional dependency. Either add a sub-option to enable the > different libnfc drivers, or automatically add pcsc-lite to the > dependencies if BR2_PACKAGE_PCSC_LITE=y. I just wanted to make sure that you have seen my comments on this patch. I'm marking it as "Changes Requested" in our patch tracking system. Therefore, if you don't send an updated version of the patch, we will forget about it. Thanks! Thomas
From 982bd5c940cc4b513b52df42bfc74ec104813193 Mon Sep 17 00:00:00 2001 From: deinok <deinok@deinok.com> Date: Mon, 27 May 2019 10:25:26 +0200 Subject: [PATCH 1/1] package/libnfc: support pcsc-lite Signed-off-by: deinok <deinok@deinok.com> --- package/libnfc/Config.in | 1 + package/libnfc/libnfc.mk | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package/libnfc/Config.in b/package/libnfc/Config.in index c8fe251459..564e9dfa67 100644 --- a/package/libnfc/Config.in +++ b/package/libnfc/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBNFC depends on BR2_TOOLCHAIN_HAS_THREADS # libusb select BR2_PACKAGE_LIBUSB select BR2_PACKAGE_LIBUSB_COMPAT + select BR2_PACKAGE_PCSC_LITE help Public platform independent Near Field Communication (NFC) library. diff --git a/package/libnfc/libnfc.mk b/package/libnfc/libnfc.mk index b13fd69d82..e1c29273a3 100644 --- a/package/libnfc/libnfc.mk +++ b/package/libnfc/libnfc.mk @@ -12,10 +12,9 @@ LIBNFC_LICENSE_FILES = COPYING LIBNFC_AUTORECONF = YES LIBNFC_INSTALL_STAGING = YES -LIBNFC_DEPENDENCIES = host-pkgconf libusb libusb-compat +LIBNFC_DEPENDENCIES = host-pkgconf libusb libusb-compat pcsc-lite -# N.B. The acr122 driver requires pcsc-lite. -LIBNFC_CONF_OPTS = --with-drivers=arygon,pn53x_usb +LIBNFC_CONF_OPTS = --with-drivers=all ifeq ($(BR2_PACKAGE_LIBNFC_EXAMPLES),y) LIBNFC_CONF_OPTS += --enable-example -- 2.17.1