From patchwork Sun Jan 12 23:44:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 309659 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 8910C2C0092 for ; Mon, 13 Jan 2014 10:45:08 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B434E8B7A1; Sun, 12 Jan 2014 23:45:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tu2-Fw52UDzT; Sun, 12 Jan 2014 23:45:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0642A8B7AA; Sun, 12 Jan 2014 23:45:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E51C81BF841 for ; Sun, 12 Jan 2014 23:44:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DC9148BA87 for ; Sun, 12 Jan 2014 23:44:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ay7zJM37g5fl for ; Sun, 12 Jan 2014 23:44:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by whitealder.osuosl.org (Postfix) with ESMTPS id 130B98BA54 for ; Sun, 12 Jan 2014 23:44:56 +0000 (UTC) Received: by mail-wi0-f172.google.com with SMTP id en1so1555419wid.11 for ; Sun, 12 Jan 2014 15:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=IyqgrAm/TtKdkqLshEqVQwiJfg2f1R1L31enbIeRFSU=; b=wVUKk6p4bSWYUz6JGfTG3Fi7qi3DXdXEP1Alf1kbk9TvYBLRcYEeM9gz436sox5XlG 5A0UjE2mjWNNM0SHpF19E32sbC3vgXaBIS+QUha2LKTe3iRpCtcYMCA/TmV9kySALsrm NjzbdM+WSXSiT+Xi88WqBpEhTKTyzpGWw3AoLnP5XwXVXNVcsAQh7J2H8tVZXL69MOKt ouA7DrQWzGvX6O1W6zae9+tCAarJRgXujd6NLszFuQ4KqJG9rYKUxbiYiXgfTkmdr/Yf WsfhQA30bC53qd+NYqrCmJD2nGj5RWNOCbK8HlCBElT8a20/3T8eRyK/EWWN/NtMlXZo Eu7A== X-Received: by 10.180.87.232 with SMTP id bb8mr12641971wib.48.1389570295632; Sun, 12 Jan 2014 15:44:55 -0800 (PST) Received: from gourin.bzh.lan (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id z2sm14900365wiy.11.2014.01.12.15.44.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 Jan 2014 15:44:55 -0800 (PST) From: "Yann E. MORIN" To: buildroot@busybox.net Date: Mon, 13 Jan 2014 00:44:47 +0100 Message-Id: <894fddeb65b5990ef4926605cfe58f1d19804ec8.1389569992.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: References: Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH 4/6] package infra: DOWNLOAD is never called with two arguments X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: "Yann E. MORIN" Currently, the DOWNLOAD helper accepts one or two arguments: - the source URI - the source filename, if missing, derived from the URI But we have no caller of DOWNLOAD that passes a second argument. Signed-off-by: "Yann E. MORIN" Acked-by: Arnout Vandecappelle (Essensium/Mind) --- package/pkg-download.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 8e6f7a3..f3354d1 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -227,14 +227,13 @@ endef # 3) BR2_BACKUP_SITE if enabled, unless BR2_PRIMARY_SITE_ONLY is set # # Argument 1 is the source location -# Argument 2 is the source filename # # E.G. use like this: -# $(call DOWNLOAD,$(FOO_SITE),$(FOO_SOURCE)) +# $(call DOWNLOAD,$(FOO_SITE)) ################################################################################ define DOWNLOAD - $(call DOWNLOAD_INNER,$(1),$(if $(2),$(2),$(notdir $(1)))) + $(call DOWNLOAD_INNER,$(1),$(notdir $(1))) endef define DOWNLOAD_INNER