From patchwork Thu Mar 6 10:07:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 327368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id EB2272C00B7 for ; Thu, 6 Mar 2014 21:09:08 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5963F9535A; Thu, 6 Mar 2014 10:09:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id efswsR6h81jN; Thu, 6 Mar 2014 10:09:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id C94D3957C8; Thu, 6 Mar 2014 10:09:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 41C7A1C2B3A for ; Thu, 6 Mar 2014 10:08:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3F6BE82BFC for ; Thu, 6 Mar 2014 10:08:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EPiOEEakiKAg for ; Thu, 6 Mar 2014 10:08:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by whitealder.osuosl.org (Postfix) with ESMTPS id 8403A820CA for ; Thu, 6 Mar 2014 10:08:56 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id d49so1000990eek.41 for ; Thu, 06 Mar 2014 02:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:content-transfer-encoding:subject :message-id:in-reply-to:references:user-agent:date:from:to; bh=o5EWTIyzIB1pQUa2xA0vklUDnxl+WJWstpwou+fDjbk=; b=W2NoIGzAHgnpfMr8aVgNRtaaqEqez3MmZoUDZQVwE2lsU9/qA3tMr589LSlAyEnh/F e5YKr1OTBe9nNEUPb4ozl6bJfkwVE0HPbz0xio90+lyiC/4JWeumK2LECvFUnHtH2Heo bN2PyR4FltM12B8+aK+GavL+pHCufP1OO4i5eHHqZSy6KQmxLT6+Oa8bwzbhPEUfaYx5 hY79SRhHM7aFu94tuHusiRB27Cwc9HfXQFWu+s8uGfUw5kG66ucy0W6BFZy3DRFd/6jX 6zaYFIVvtAOKoDNvHRyYZfiFlId4iNveSEwvcDmH+U0LMaU9S6TyUvHc59RbI+jQ1N7y rROQ== X-Received: by 10.14.104.135 with SMTP id i7mr11548119eeg.34.1394100535177; Thu, 06 Mar 2014 02:08:55 -0800 (PST) Received: from [127.0.1.1] (d54C62EEB.access.telenet.be. [84.198.46.235]) by mx.google.com with ESMTPSA id o43sm20094311eef.12.2014.03.06.02.08.53 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 06 Mar 2014 02:08:54 -0800 (PST) MIME-Version: 1.0 X-Mercurial-Node: 6e5a7ccaa13faae6b0993079f717129a229a3c86 Message-Id: <6e5a7ccaa13faae6b099.1394100452@argentina> In-Reply-To: References: User-Agent: Mercurial-patchbomb/2.2.2 Date: Thu, 06 Mar 2014 11:07:32 +0100 From: Thomas De Schampheleire To: buildroot@buildroot.org Subject: [Buildroot] [PATCH 4 of 7] manual: contributing: minor rewording of 'submitting patches' section X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net This patch makes some minor changes to the section about submitting patches. Content-wise there are little changes. Signed-off-by: Thomas De Schampheleire Reviewed-by: "Yann E. MORIN" Acked-by: Samuel Martin --- v2: no changes docs/manual/contribute.txt | 20 +++++++++++--------- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt --- a/docs/manual/contribute.txt +++ b/docs/manual/contribute.txt @@ -164,16 +164,18 @@ Submitting patches _Please, do not attach patches to bugs, send them to the mailing list instead_. -When your changes are done, and committed in your local git view, -_rebase_ your development branch on top of the upstream tree before -generating the patch set. To do so, run: +If you made some changes to Buildroot and you would like to contribute +them to the Buildroot project, proceed as follows. Starting from the +changes committed in your local git view, _rebase_ your development +branch on top of the upstream tree before generating a patch set. To do +so, run: --------------------- $ git fetch --all --tags $ git rebase origin/master --------------------- -Here, you are ready to generate then submit your patch set. +Now, you are ready to generate then submit your patch set. To generate it, run: @@ -185,7 +187,7 @@ This will generate patch files in the +o automatically adding the +Signed-off-by+ line. Once patch files are generated, you can review/edit the commit message -before submitting them using your favorite text editor. +before submitting them, using your favorite text editor. Lastly, send/submit your patch set to the Buildroot mailing list: @@ -196,9 +198,9 @@ Lastly, send/submit your patch set to th Note that +git+ should be configured to use your mail account. To configure +git+, see +man git-send-email+ or google it. -Make sure posted *patches are not line-wrapped*, otherwise they cannot -easily be applied. In such a case, fix your e-mail client, or better, -use +git send-email+ to send your patches. +If you do not use +git send-email+, make sure posted *patches are not +line-wrapped*, otherwise they cannot easily be applied. In such a case, +fix your e-mail client, or better yet, learn to use +git send-email+. Cover letter ~~~~~~~~~~~~ @@ -244,7 +246,7 @@ Hereafter the recommended layout: --------------- Patch title less than 80-character length -Some more paragraph giving some more details. +A paragraph giving more details. And yet another paragraph giving more details.