diff mbox

[11/14] package/mesa3d: with a DRI driver, is a full OpenGL provider

Message ID 6c6c678af9a7ff235f32d25f3bea03670749f41d.1397750571.git.yann.morin.1998@free.fr
State Accepted
Headers show

Commit Message

Yann E. MORIN April 17, 2014, 4:04 p.m. UTC 
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Make mesa3d a provider for full OpenGL, as soon as a DRI driver is enabled.

Full OpenGL is only possible when:
  - a DRI driver is enabled,
  - and X.Org is enabled

Since DRI driver in fact depend on X.Org being enabled in the first place,
we can safely declare mesa3d as a full openGL provider as soon as at least
one DRI driver is enabled.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <berndkuhls@hotmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>
---
 package/mesa3d/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni April 17, 2014, 9:07 p.m. UTC | #1 
Dear Yann E. MORIN,

On Thu, 17 Apr 2014 18:04:23 +0200, Yann E. MORIN wrote:

>  config BR2_PACKAGE_MESA3D_DRI_DRIVER
>  	select BR2_PACKAGE_MESA3D_DRIVER
> +	select BR2_PACKAGE_HAS_LIBGL
>  	bool
>  
> +config BR2_PACKAGE_PROVIDES_LIBGL
> +	default "mesa3d" if BR2_PACKAGE_MESA3D_DRI_DRIVER

I find this a little bit confusing. Wouldn't it make more sense to have
a BR2_PACKAGE_MESA3D_GL option, that gets automatically defined when
mesa3d provides a full OpenGL implementation? I know it appears to
technically be the same as Mesa3D having a DRI driver, but it would
look more logical.

In fact, the Mesa3D situation is so complex that a good fat comment on
top of its Config.in file may be useful to have :)

Thomas
diff mbox

Patch

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index bd7a853..0793b48 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -26,8 +26,12 @@  config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_MESA3D_DRIVER
+	select BR2_PACKAGE_HAS_LIBGL
 	bool
 
+config BR2_PACKAGE_PROVIDES_LIBGL
+	default "mesa3d" if BR2_PACKAGE_MESA3D_DRI_DRIVER
+
 config BR2_PACKAGE_MESA3D_DRIVER
 	bool