diff mbox

qt5base: remove never set QT5BASE_CONFIGURE_ENV

Message ID 68f1652755a14911b5e98255662454f63ddf315f.1432137630.git.baruch@tkos.co.il
State Accepted
Headers show

Commit Message

Baruch Siach May 20, 2015, 4 p.m. UTC
Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
QT5BASE_CONFIGURE_ENV is never set. Remove it.

Cc: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Baruch Siach May 20, 2015, 5:23 p.m. UTC | #1
Hi Buildroot list,

On Wed, May 20, 2015 at 07:00:30PM +0300, Baruch Siach wrote:
> Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
> QT5BASE_CONFIGURE_ENV is never set. Remove it.
> 
> Cc: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Adding Peter's Reviewed-by tag from the other email with a proper In-Reply-To 
header for patchwork:

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Thanks,
baruch

> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 3de824f5424b..e2db5d1e029c 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
>  		PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
>  		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
>  		MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
> -		$(QT5BASE_CONFIGURE_ENV) \
>  		./configure \
>  		-v \
>  		-prefix /usr \
Thomas Petazzoni May 20, 2015, 9:28 p.m. UTC | #2
Dear Baruch Siach,

On Wed, 20 May 2015 19:00:30 +0300, Baruch Siach wrote:
> Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
> QT5BASE_CONFIGURE_ENV is never set. Remove it.
> 
> Cc: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 3de824f5424b..e2db5d1e029c 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -174,7 +174,6 @@  define QT5BASE_CONFIGURE_CMDS
 		PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
 		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 		MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
-		$(QT5BASE_CONFIGURE_ENV) \
 		./configure \
 		-v \
 		-prefix /usr \