diff mbox

[25/30] package/matchbox-common: explicitly disable PDA folders when not selected

Message ID 641cee0951bdc99ad2d26f6a13373ca9c6a3892e.1429725549.git.yann.morin.1998@free.fr
State Changes Requested
Headers show

Commit Message

Yann E. MORIN April 22, 2015, 6:09 p.m. UTC
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/matchbox/matchbox-common/matchbox-common.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Arnout Vandecappelle May 1, 2015, 8:44 p.m. UTC | #1
On 22/04/15 20:09, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Though for an option that is not related to a dependency I think it's less
important to explicitly disable, it's still nice to do the same thing everywhere.

 Regards,
 Arnout

> ---
>  package/matchbox/matchbox-common/matchbox-common.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/matchbox/matchbox-common/matchbox-common.mk b/package/matchbox/matchbox-common/matchbox-common.mk
> index da6bec7..038dd59 100644
> --- a/package/matchbox/matchbox-common/matchbox-common.mk
> +++ b/package/matchbox/matchbox-common/matchbox-common.mk
> @@ -14,6 +14,8 @@ MATCHBOX_COMMON_DEPENDENCIES = matchbox-lib
>  
>  ifeq ($(strip $(BR2_PACKAGE_MATCHBOX_COMMON_PDA)),y)
>  MATCHBOX_COMMON_CONF_OPTS += --enable-pda-folders
> +else
> +MATCHBOX_COMMON_CONF_OPTS += --disable-pda-folders
>  endif
>  
>  $(eval $(autotools-package))
>
diff mbox

Patch

diff --git a/package/matchbox/matchbox-common/matchbox-common.mk b/package/matchbox/matchbox-common/matchbox-common.mk
index da6bec7..038dd59 100644
--- a/package/matchbox/matchbox-common/matchbox-common.mk
+++ b/package/matchbox/matchbox-common/matchbox-common.mk
@@ -14,6 +14,8 @@  MATCHBOX_COMMON_DEPENDENCIES = matchbox-lib
 
 ifeq ($(strip $(BR2_PACKAGE_MATCHBOX_COMMON_PDA)),y)
 MATCHBOX_COMMON_CONF_OPTS += --enable-pda-folders
+else
+MATCHBOX_COMMON_CONF_OPTS += --disable-pda-folders
 endif
 
 $(eval $(autotools-package))