From patchwork Fri Jun 21 11:56:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 253198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 9F14C2C02C2 for ; Fri, 21 Jun 2013 21:57:56 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3E0FF102682; Fri, 21 Jun 2013 11:57:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rc8DgrP5qn0Z; Fri, 21 Jun 2013 11:57:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3618310BFAF; Fri, 21 Jun 2013 11:57:23 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 7713B8F79E for ; Fri, 21 Jun 2013 11:57:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7240B8CE8F for ; Fri, 21 Jun 2013 11:57:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v+aOVugUYY9I for ; Fri, 21 Jun 2013 11:57:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by whitealder.osuosl.org (Postfix) with ESMTPS id EA1D58C4CD for ; Fri, 21 Jun 2013 11:57:18 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id b12so6405394wgh.31 for ; Fri, 21 Jun 2013 04:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=WIWBnaR/Srj3DASEtnuyBesYyHQpFy3ZAzI24qLaE5o=; b=l+wLgHBzeQP8i/LR2rjrLMDVD9jePaJ2fs5dMWlcqiVrnGxqN47ygFyA+fgmpxsq6g JFVpAkT3LgpT1hVwDs7mNqQ9idimKlaxuiOAqlCH3chxY7qqY1ZgbhMkKaf9lcaXME9/ 08RtC83W06OiS4MJZ2Yf3JVjb/tKTokQLYtFxCFwnjRzEbH7KEesGFuKwcNfp+rLAHQJ VZc5I2xG+aS+BvnFErpLXQa8g4zdlQhYwWtEuzDHJo3ZLpZw7A8WBBhhGScS1Z1niOKY oUtjn1L22zy1KKv05MdfVFagsW57zp3U+rcpGGgUL3HdkGQkJV9rHKBzAl+Vw/+fEwSE nzMA== X-Received: by 10.194.179.33 with SMTP id dd1mr8813351wjc.51.1371815837294; Fri, 21 Jun 2013 04:57:17 -0700 (PDT) Received: from lnx-rg.pr (lyon.paratronic.fr. [213.41.177.106]) by mx.google.com with ESMTPSA id fv11sm6698658wic.11.2013.06.21.04.57.15 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Jun 2013 04:57:16 -0700 (PDT) From: richard.genoud@gmail.com To: buildroot@busybox.net Date: Fri, 21 Jun 2013 13:56:57 +0200 Message-Id: <51c43f9c.ebbbb40a.0abf.ffffba07@mx.google.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1371815822-29453-1-git-send-email-y> References: <1371743610-17810-1-git-send-email-richard.genoud@gmail.com> <1371815822-29453-1-git-send-email-y> Cc: Thomas Petazzoni Subject: [Buildroot] [PATCH 1/6] tcl: change BR2_PACKAGE_TCL_SHLIB_ONLY option X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: Richard Genoud It's not convenient to have an option (defaulted to yes) that removes a software. For instance, usb_modeswitching_data needs the tclsh interpreter, so it would have to un-select this option, but select TCL. Having an option that adds the tclsh binary (defaulted to no to keep the same behaviour) is way more convenient. Moreover, it seems that it was intended liked that at the begining because usb_modeswitching_data already selects BR2_PACKAGE_TCL_TCLSH which wasn't declared anywhere. Signed-off-by: Richard Genoud --- package/tcl/Config.in | 11 +++++------ package/tcl/tcl.mk | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/package/tcl/Config.in b/package/tcl/Config.in index 7a4d887..8af7980 100644 --- a/package/tcl/Config.in +++ b/package/tcl/Config.in @@ -16,12 +16,11 @@ config BR2_PACKAGE_TCL_DEL_ENCODINGS It saves approx. 1.4 Mb of space. -config BR2_PACKAGE_TCL_SHLIB_ONLY - bool "install only shared library" - default y +config BR2_PACKAGE_TCL_TCLSH + bool "Install also tclsh binary, not only the shared library" + default n depends on BR2_PACKAGE_TCL help - Install only TCL shared library and not binary tcl - interpreter(tclsh8.4). + Install the TCL interpreter binary file(tclsh8.4). - Saves ~14kb. + Adds ~14kb. diff --git a/package/tcl/tcl.mk b/package/tcl/tcl.mk index 0c8fa33..ad23b80 100644 --- a/package/tcl/tcl.mk +++ b/package/tcl/tcl.mk @@ -27,7 +27,7 @@ define TCL_POST_INSTALL_CLEANUP -if [ "$(BR2_PACKAGE_TCL_DEL_ENCODINGS)" = "y" ]; then \ rm -Rf $(TARGET_DIR)/usr/lib/tcl$(TCL_VERSION_MAJOR)/encoding/*; \ fi - -if [ "$(BR2_PACKAGE_TCL_SHLIB_ONLY)" = "y" ]; then \ + -if [ "$(BR2_PACKAGE_TCL_TCLSH)" != "y" ]; then \ rm -f $(TARGET_DIR)/usr/bin/tclsh$(TCL_VERSION_MAJOR); \ fi endef