From patchwork Thu Jan 10 10:21:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kpa_info@yahoo.fr X-Patchwork-Id: 210971 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id E9D6D2C0291 for ; Thu, 10 Jan 2013 21:21:44 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9E43631153; Thu, 10 Jan 2013 10:21:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H1NRQH0zkHv0; Thu, 10 Jan 2013 10:21:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A345C306DB; Thu, 10 Jan 2013 10:21:41 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 168838F74B for ; Thu, 10 Jan 2013 10:21:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C7E828CD66 for ; Thu, 10 Jan 2013 10:21:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WSQuuHwPckrV for ; Thu, 10 Jan 2013 10:21:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from nm13.bullet.mail.ird.yahoo.com (nm13.bullet.mail.ird.yahoo.com [77.238.189.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 64EBC8CD8D for ; Thu, 10 Jan 2013 10:21:35 +0000 (UTC) Received: from [77.238.189.57] by nm13.bullet.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:21:32 -0000 Received: from [217.146.188.173] by tm10.bullet.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:21:32 -0000 Received: from [127.0.0.1] by smtp141.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:21:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.fr; s=s1024; t=1357813292; bh=lDzUC1vYVt5BRGSpI2nMmEqE2yiK8Hs34/wUFNFYehY=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=SoUhR22gVKTABk9ebmj1pkU6ySZamNkbl8V850GS200MMEGMXO7eHzPy7RlrEBMY+Csw7WaBCsX9DXSAFcMzLaB32QEN/PMNnP+5LYZ+o0V49mGjtRgqStGN8yADNMi/JMQL1sronP/TLdJejyujrGG3PuWZ7FjnY0jp6LfNRao= X-Yahoo-Newman-Id: 396891.69417.bm@smtp141.mail.ird.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 6Dk_icQVM1kW.XYHU9RFCySRQGWpvt0VSa3K.Y.pBNZVUme t_6VWiRthDTdak.wxTlIGNV5gXZJCzCcjkZMcNzrNz2X57fEBW_LjOxALI_c asnZSR_ehle.qDY2PhnJh_x9pgHLk_qk5rPVIb6dhrFgQsrVCViFvN8C4v0u ezlu7odsXs8c2h.62_YtnOB.6gmfQg0PhOh6n.DhI..PsgqpkFEQA89zZ6qC jjs7WiK2R.Ilscy1Y55ZyZaNeIKOq_lkJZ.2yA6qTXye3D592mLOrTP4r3Lk zF5C.hLTwNy0G4aSARhtIZQl6STuGGYgJEqglvVrAgiosVA1cDmfAltS4Kmb 3ZrnAoX6RXNiEJz6kM2Ley2zh2iJ41xkfMeiYbmMRI2IuXo51ZluH5Akndgj V6P_X1vJ7WG79ccD1MNMM8et3F_GBK37mse5bw95F8hxcTVIIh35q9j2EjZw Fau_tgs.hoB5qnPSQZp0fK8W4lpcwR4e88S4Ybxgxn9fdeOas4XdLkZbZloP as2XfVVedLtwnPS3_6H6ED1fzWe7jztT3INsTI.SFvFKCjm6HYBC5.vSve6v fWsK1F.X1BN6HI_WdrMV4FrM9R_mvYJuvYetb3.fznlYIJbhn15UX8NZQrA0 7xWkKVlcgS_LEk829eJVoDd1Fre6Mqr_EOUzMIDHSbEMC.yIZ X-Yahoo-SMTP: gXxkLaeswBDA9gtBSIbQ8XWSflp0 Received: from [10.22.2.59] (kpa_info@46.140.83.238 with plain) by smtp141.mail.ird.yahoo.com with SMTP; 10 Jan 2013 02:21:32 -0800 PST Message-ID: <50EE9625.1080603@yahoo.fr> Date: Thu, 10 Jan 2013 11:21:25 +0100 From: Patrick User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Thomas Petazzoni References: <1357734594-8211-1-git-send-email-kpa_info@yahoo.fr> <20130109165905.1fccde74@skate> In-Reply-To: <20130109165905.1fccde74@skate> Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On 01/09/2013 04:59 PM, Thomas Petazzoni wrote: > Dear kpa_info@yahoo.fr, > > It looks pretty good! I have a few comments below. > > On Wed, 9 Jan 2013 13:29:53 +0100, kpa_info@yahoo.fr wrote: >> From: Patrick Gerber >> >> >> Signed-off-by: Patrick Gerber >> --- >> package/multimedia/Config.in | 1 + >> package/multimedia/yavta/Config.in | 4 ++++ >> package/multimedia/yavta/yavta.mk | 21 +++++++++++++++++++++ >> 3 files changed, 26 insertions(+) >> create mode 100644 package/multimedia/yavta/Config.in >> create mode 100644 package/multimedia/yavta/yavta.mk >> >> diff --git a/package/multimedia/Config.in >> b/package/multimedia/Config.in index 273d9bc..da558ca 100644 >> --- a/package/multimedia/Config.in >> +++ b/package/multimedia/Config.in >> @@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in" >> source "package/multimedia/tidsp-binaries/Config.in" >> source "package/multimedia/vorbis-tools/Config.in" >> source "package/multimedia/wavpack/Config.in" >> +source "package/multimedia/yavta/Config.in" >> endmenu >> diff --git a/package/multimedia/yavta/Config.in >> b/package/multimedia/yavta/Config.in new file mode 100644 >> index 0000000..3cca5c1 >> --- /dev/null >> +++ b/package/multimedia/yavta/Config.in >> @@ -0,0 +1,4 @@ >> +config BR2_PACKAGE_YAVTA >> + bool "yavta" >> + help >> + Yet Another V4L2 Test Application > > Here, we want a empty line, and then the upstream URL of the > corresponding project. > > See > http://buildroot.org/downloads/manual/manual.html#_literal_config_in_literal_file. > > >> +YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238 >> +YAVTA_SITE = git://git.ideasonboard.org/yavta.git >> +YAVTA_LICENSE = GPLv2 >> +YAVTA_LICENSE_FILES = COPYING.GPL >> + >> +define YAVTA_BUILD_CMDS >> +$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)" > > This line could be intended with one tab, and could be written as > follows: > > $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) > > TARGET_CONFIGURE_OPTS contains the proper CC and CFLAGS definitions. > >> +endef >> + >> +define YAVTA_INSTALL_TARGET_CMDS >> +install -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta > > Indentation, and install -> $(INSTALL) > > $(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta > >> +endef >> + >> +$(eval $(generic-package)) > > Otherwise, looks good! > > Thomas > Dear Thomas, Please find below the new version of the patch according to your comments. Patrick From: Patrick Gerber Signed-off-by: Patrick Gerber --- package/multimedia/Config.in | 1 + package/multimedia/yavta/Config.in | 4 ++++ package/multimedia/yavta/yavta.mk | 21 +++++++++++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 package/multimedia/yavta/Config.in create mode 100644 package/multimedia/yavta/yavta.mk -- 1.7.9.5 diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in index 273d9bc..da558ca 100644 --- a/package/multimedia/Config.in +++ b/package/multimedia/Config.in @@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in" source "package/multimedia/tidsp-binaries/Config.in" source "package/multimedia/vorbis-tools/Config.in" source "package/multimedia/wavpack/Config.in" +source "package/multimedia/yavta/Config.in" endmenu diff --git a/package/multimedia/yavta/Config.in b/package/multimedia/yavta/Config.in new file mode 100644 index 0000000..3cca5c1 --- /dev/null +++ b/package/multimedia/yavta/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_YAVTA + bool "yavta" + help + Yet Another V4L2 Test Application + + http://git.ideasonboard.org/yavta.git diff --git a/package/multimedia/yavta/yavta.mk b/package/multimedia/yavta/yavta.mk new file mode 100644 index 0000000..1aa5574 --- /dev/null +++ b/package/multimedia/yavta/yavta.mk @@ -0,0 +1,20 @@ +############################################################# +# +# yavta +# +############################################################# + +YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238 +YAVTA_SITE = git://git.ideasonboard.org/yavta.git +YAVTA_LICENSE = GPLv2 +YAVTA_LICENSE_FILES = COPYING.GPL + +define YAVTA_BUILD_CMDS + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) +endef + +define YAVTA_INSTALL_TARGET_CMDS + $(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta +endef + +$(eval $(generic-package))