From patchwork Fri Oct 5 23:45:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagaert Johan X-Patchwork-Id: 189628 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 2BAEB2C0336 for ; Sat, 6 Oct 2012 09:45:51 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 152638F0EC; Fri, 5 Oct 2012 23:45:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8rDksA7Z4aYL; Fri, 5 Oct 2012 23:45:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 81B4B8F0DF; Fri, 5 Oct 2012 23:45:46 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E1A438F74A for ; Fri, 5 Oct 2012 23:45:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 786D88F0DF for ; Fri, 5 Oct 2012 23:45:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EeuRuEwB77SP for ; Fri, 5 Oct 2012 23:45:42 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mailrelay010.isp.belgacom.be (mailrelay010.isp.belgacom.be [195.238.6.177]) by whitealder.osuosl.org (Postfix) with ESMTP id A34668C8DD for ; Fri, 5 Oct 2012 23:45:41 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag4KAPtvb1BR8Sr0/2dsb2JhbABFvhIDgQqBCYIhAQUIMhwIGw0DAgYDIR4HGRoGDREBAQQTCAOHfrkJiz5hhEhgA41pmDCCbw Received: from 244.42-241-81.adsl-dyn.isp.belgacom.be (HELO JohanW7) ([81.241.42.244]) by relay.skynet.be with ESMTP; 06 Oct 2012 01:45:40 +0200 From: "Sagaert Johan" To: "'Arnout Vandecappelle \(Essensium/Mind\)'" References: 506F6539.2060205@mind.be <1349478193-13673-1-git-send-email-arnout@mind.be> In-Reply-To: <1349478193-13673-1-git-send-email-arnout@mind.be> Date: Sat, 6 Oct 2012 01:45:39 +0200 Message-ID: <4E1BAE3FB98343E3A142EF4D798234F0@JohanW7> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2jUID35Ab0iu+MTWu8ZGQczVez5gAAjkRQ X-MimeOLE: Produced By Microsoft MimeOLE V6.1.7601.17609 Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH] mplayer: fix compilation of NEON assembly in libavcodec X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Hi all Thanks Arnout for the fix. I did some tweaking in the makefile and found disabling the option MPLAYER_CONF_OPTS += --enable-neon yielded an errorfree build, but I lost the optimisation that way. -----Oorspronkelijk bericht----- Van: Arnout Vandecappelle (Essensium/Mind) [mailto:arnout@mind.be] Verzonden: zaterdag 6 oktober 2012 1:03 Aan: buildroot@busybox.net CC: Arnout Vandecappelle (Essensium/Mind); Sagaert Johan Onderwerp: [PATCH] mplayer: fix compilation of NEON assembly in libavcodec Compilation of the NEON assembly fails unless neon is enabled in the compiler options. This is probably not needed for all combinations of gcc/binutils, but at least some need it and it certainly doesn't hurt. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- .../multimedia/mplayer/mplayer-1.1-fix-neon.patch | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) -- tg: (2ba4eed..) t/mplayer-neon (depends on: master) diff --git a/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch b/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch new file mode 100644 index 0000000..38c2adc --- /dev/null +++ b/package/multimedia/mplayer/mplayer-1.1-fix-neon.patch @@ -0,0 +1,19 @@ +Compilation of the NEON assembly fails unless neon is enabled in the +compiler options. This is probably not needed for all combinations of +gcc/binutils, but at least some need it and it certainly doesn't hurt. + +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) +--- +diff -Nrup mplayer-1.1.orig/configure mplayer-1.1/configure +--- mplayer-1.1.orig/configure 2012-10-06 00:31:57.706985824 +0200 ++++ mplayer-1.1/configure 2012-10-06 00:49:32.618948116 +0200 +@@ -2935,6 +2935,9 @@ if arm ; then + inline_asm_check '"vadd.i16 q0, q0, q0"' && neon=yes + fi + echores "$neon" ++ if test $neon = "yes" ; then ++ extra_cflags="$extra_cflags -mfpu=neon -mfloat-abi=softfp" ++ fi + + echocheck "ARM THUMB" + if test $armthumb = "auto" ; then