Message ID | 32219a9dca495a3547a60e749cd90b159e0f792f.1515939400.git.yann.morin.1998@free.fr |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Kviv3UEG"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zKJV94VKJz9sR8 for <incoming@patchwork.ozlabs.org>; Mon, 15 Jan 2018 01:17:53 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4AF9F87A4D; Sun, 14 Jan 2018 14:17:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WSfxiRiyvWbK; Sun, 14 Jan 2018 14:17:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4721787A5E; Sun, 14 Jan 2018 14:17:44 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 916101C14DD for <buildroot@lists.busybox.net>; Sun, 14 Jan 2018 14:17:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8566987A44 for <buildroot@lists.busybox.net>; Sun, 14 Jan 2018 14:17:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aJ5jlbf_IDEt for <buildroot@lists.busybox.net>; Sun, 14 Jan 2018 14:17:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 603D787A37 for <buildroot@buildroot.org>; Sun, 14 Jan 2018 14:17:41 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id e41so8900473wre.9 for <buildroot@buildroot.org>; Sun, 14 Jan 2018 06:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=gnGFMsQBOwbeREugljNKTVrcXls3GcTjkFfxcZA7D1o=; b=Kviv3UEGN0Oj7GZvp1GHM9ybhKDHVW7M/HZu75wG5ckOvXJw2wvyalwkTdQsT7qGk/ mhskWJOdyGLpgRSjo3z6Ub0NJvClsSPu8txIkaUYNjmUDnAEhNRsn/8DowG9Uikh08WJ nvqFqbB1uke3/3hba72hmFPXD5xqNkgvvWF3cBOqk+jfwEjQIoLin0d8Uc4NOGw8LVqj p0ytuJKGzRCYK+sc7PB7gWmU++uu/EK9OnS+/sY2dsvjdNa1mvvJvd1k+NjpF24M4bGc DDwvmsRs3SutSKCU8U3i4lCk6uAl+146fMdhSy4gTB3KXwokoEJo0KhFRed71zP9zJjh KD/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=gnGFMsQBOwbeREugljNKTVrcXls3GcTjkFfxcZA7D1o=; b=HOmRrRv27FzsGKuNMX4TNoKnDNFOQ9Ylb4M12q/N+Pu2UUa7JN00qw45khZqDBkXNp ZMT0l/Rme1SAiGoQ2J0alJ0osbiBwvxisXLrNMFxSFoZuKX0oelXBKBIGhLQa+lMqpY1 2+YGzn8vQNQjNduisi33OHAUe0Hq0VPe52jO3OTgajfcNgLj99ho1fzCe1ZfpoBHiHI4 hRjntjTx8HysE+YPzVMzHGiB/6MJ1yOZZGu9SJn7rsC6Bpfl5DTVm7k7CVXwSK8GIhog xyqZjBhfR1tA7WVk1YJ0myRXI1DS3GSsEqtUUtSKKpuOWPed+477r5fc9FKx4q3wNW0n ExXw== X-Gm-Message-State: AKwxytcVd8LoxGfGgcwyz1sm7aS0TL3M8HPSNnPtJQGHSI330zrxE3Io cOkfzvdol1lONpqqmQz8p0Khxw== X-Google-Smtp-Source: ACJfBotnsky2MCgFAvfyBRYwOfxcYvrBJV5z5GDNBggRYuyEJK8vs14GFfhm+M7KA9tU9syKwXcJjA== X-Received: by 10.223.164.22 with SMTP id d22mr10778888wra.186.1515939459678; Sun, 14 Jan 2018 06:17:39 -0800 (PST) Received: from localhost.localdomain (2a01cb088610730095116638271b1e6e.ipv6.abo.wanadoo.fr. [2a01:cb08:8610:7300:9511:6638:271b:1e6e]) by smtp.gmail.com with ESMTPSA id d63sm3260179wmd.9.2018.01.14.06.17.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 06:17:38 -0800 (PST) From: "Yann E. MORIN" <yann.morin.1998@free.fr> To: buildroot@buildroot.org Date: Sun, 14 Jan 2018 15:17:00 +0100 Message-Id: <32219a9dca495a3547a60e749cd90b159e0f792f.1515939400.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 2.14.1 In-Reply-To: <cover.1515939400.git.yann.morin.1998@free.fr> References: <cover.1515939400.git.yann.morin.1998@free.fr> Subject: [Buildroot] [PATCH 04/17] fs/cpio: don't extend packages' permissions table X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, "Yann E. MORIN" <yann.morin.1998@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
Series |
[01/17] fs: pass EXTRA_ENV to post-fakeroot script
|
expand
|
diff --git a/fs/cpio/cpio.mk b/fs/cpio/cpio.mk index aa4d947fa5..505976512b 100644 --- a/fs/cpio/cpio.mk +++ b/fs/cpio/cpio.mk @@ -15,14 +15,15 @@ endef else # devtmpfs does not get automounted when initramfs is used. # Add a pre-init script to mount it before running init +# We must have /dev/console very early, even before /init runs, so +# that it can at least open its stdin/stdout/stderr filedescriptors. define ROOTFS_CPIO_ADD_INIT if [ ! -e $(TARGET_DIR)/init ]; then \ $(INSTALL) -m 0755 fs/cpio/init $(TARGET_DIR)/init; \ fi + mknod -m 0622 $(TARGET_DIR)/dev/console c 5 1 endef -PACKAGES_PERMISSIONS_TABLE += /dev/console c 622 0 0 5 1 - - -$(sep) - endif # BR2_ROOTFS_DEVICE_CREATION_STATIC ROOTFS_CPIO_PRE_GEN_HOOKS += ROOTFS_CPIO_ADD_INIT
Currently, when we build a cpio filesystem without static devices, we shoehorn the /dev/console node as if it were specified by a package. This means that this device is added for all filesystems as well, not just the cpio. But if we disable cpio, that device is not created for other filesystems. This is not very clean, and may break expectations. Instead, use an explicit mknod as part of the _CMD, as we know it's going to run under fakeroot. This is still visible to all filesystems built after cpio, and not to those built before it, though. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Arnout Vandecappelle <arnout@mind.be> --- fs/cpio/cpio.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)