From patchwork Sun Jun 10 15:44:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 927376 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="t2KtY3sX"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 413gT42L8Rz9rvt for ; Mon, 11 Jun 2018 01:45:12 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 28BB3867A1; Sun, 10 Jun 2018 15:45:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lkndVqz2ARR4; Sun, 10 Jun 2018 15:45:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id ACADE867E8; Sun, 10 Jun 2018 15:45:03 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E0D101CF175 for ; Sun, 10 Jun 2018 15:45:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DE76887F05 for ; Sun, 10 Jun 2018 15:45:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2jkqkbdyntPv for ; Sun, 10 Jun 2018 15:45:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by hemlock.osuosl.org (Postfix) with ESMTPS id DE67787F04 for ; Sun, 10 Jun 2018 15:45:01 +0000 (UTC) Received: by mail-wr0-f177.google.com with SMTP id v13-v6so17831072wrp.13 for ; Sun, 10 Jun 2018 08:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yBBx9TVi5LRevMuetCurP3q3Jv3Lbj5Wq66iYnczkwY=; b=t2KtY3sXrJAvsQCgcoszuvX2QfgV0SxmBxEsxkI5VXlrRuX3UZRu7LfMLAMfx9KnEF sZ5Oo26qvlbVBRA0TeKSBHXKX11Qowsd9LN+xzt0nrEJKkpUGRG33XTQ+ukehwI66OzF v8EROLIN/PqJzmyLA+hbUcprQiwC46r1MeDpmoTfC2chmYOYGsNQYLedGcA8coaetmc6 3zfvWPW1RGDids9WgycyLVgoCQswxoyuXIsJH37NynFK47xj002qEQZ4qC7uCc4B9lDH 1T+FTefc1BLRK47la5IzRbXzbzCvCVsBGz853+1qvc0pU2ANN8xP/TQ3RjCQ2sOBwJNx HrUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yBBx9TVi5LRevMuetCurP3q3Jv3Lbj5Wq66iYnczkwY=; b=FZjg9SqMUCLdrCWNbkF2XV+KsO7O9ZmYfo5/Vc1KvxJ4kDQIhkpJoCE3JEuhXHURSk DnR5aHMNbiYw2/o477jXUQ5UpOUGa5BPWolZMKs+H1fVXsrYKVOTj8K55Bq/ylt5qfaf u8qK41w9stwtMY4mUJavz5pjGi2TsZG8Bx+8EL7cb+QydWubRrbA73zKQtr3lRpGXGWC +ewtL4GwHjTpwcmbe7NpEx+n3vsLKWRGxWnW0P/c3aY8VXnP5qWYRblxF1InXv66+1cp K7QEs1B3BcznHN4S7cRSBSm2DBJAMDA4xDe0wMnTZTBAtmf0QfMuu9nXGQAjhzaZoYrW +IpQ== X-Gm-Message-State: APt69E0zOo/gM8eXe0ytcEiL+Fpgbjs3QaPujifWUo3bgBxx4Hjc8jFi x/3BWghYMcDY+lBKQiluC7jEBg== X-Google-Smtp-Source: ADUXVKKT7umAJoClDkk/bqk+/oPuZRquRkUon5C9WpRjP2hbrWT1bNKrPjxYDNvcUlwM7sdFX+/hGQ== X-Received: by 2002:adf:a032:: with SMTP id k47-v6mr10207053wrk.202.1528645500105; Sun, 10 Jun 2018 08:45:00 -0700 (PDT) Received: from scaer.bzh.lan (2a01cb0886107300951dbdf04211ad4d.ipv6.abo.wanadoo.fr. [2a01:cb08:8610:7300:951d:bdf0:4211:ad4d]) by smtp.gmail.com with ESMTPSA id q17-v6sm32927125wrs.5.2018.06.10.08.44.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jun 2018 08:44:59 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Sun, 10 Jun 2018 17:44:57 +0200 Message-Id: <31dc2172ac9fba9527eec403868e3dc82c6f7ce8.1528645489.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: Subject: [Buildroot] [PATCH 1/2 v3] support/docker: sort the list of installed packages X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Ricardo Martincoski MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" As suggested in the docker best practices [0], order the package list alphabetically, and list only one package per line. This will be much usefull later, we need to update the list of installed packages, like adding new ones for example. [0] https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments Signed-off-by: "Yann E. MORIN" Cc: Ricardo Martincoski Reviewed-by: Ricardo Martincoski --- Changes v2 -> v3: - don't mistakenly drop cmake (Ricardo) Changes v1 -> v2: - don't drop python-pip yet (Ricardo) --- support/docker/Dockerfile | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile index 8c525f7cf1..bebd861dc1 100644 --- a/support/docker/Dockerfile +++ b/support/docker/Dockerfile @@ -22,13 +22,30 @@ COPY apt-sources.list /etc/apt/sources.list RUN dpkg --add-architecture i386 && \ apt-get update -y RUN apt-get install -y --no-install-recommends \ - build-essential cmake libc6:i386 g++-multilib \ - bc ca-certificates file locales rsync \ - cvs bzr git mercurial subversion wget \ - cpio unzip \ + bc \ + build-essential \ + bzr \ + ca-certificates \ + cmake \ + cpio \ + cvs \ + file \ + g++-multilib \ + git \ + libc6:i386 \ libncurses5-dev \ - python-nose2 python-pexpect qemu-system-arm qemu-system-x86 \ - python-pip && \ + locales \ + mercurial \ + python-nose2 \ + python-pexpect \ + python-pip \ + qemu-system-arm \ + qemu-system-x86 \ + rsync \ + subversion \ + unzip \ + wget \ + && \ apt-get -y autoremove && \ apt-get -y clean