diff mbox

Using 2016.11-rc2: external packages and BR2_EXTERNAL ?

Message ID 249201d2546c$f090ac60$d1b20520$@chordia.co.uk
State Not Applicable
Headers show

Commit Message

jerry@chordia.co.uk Dec. 12, 2016, 11:43 a.m. UTC 
Hello Thomas

> With the support for multi-br2-external in 2016.11, things have changed a
bit,
> and BR2_EXTERNAL no longer exists. It's name
> BR2_EXTERNAL_<name_of_your_external>.

Thanks. I'm aware of the multi change. 

One problem is that this now makes it difficult to share packages. I'm
currently building for 3 different targets that share a common set of
packages. I think it would make sense to keep BR2_EXTERNAL as _well_ as the
'external' version to handle this case?

I did try modifying support/scripts/br_external as below but it does not
have the expected effect.

Or is there another/better way to do this? Any suggestions?

MTIA

Jerry.

---------------------------------snip-------------------------------
 
 # Generate the kconfig snippet for the br2-external tree.

Comments

Thomas Petazzoni Dec. 12, 2016, 12:13 p.m. UTC | #1 
Hello,

On Mon, 12 Dec 2016 11:43:21 -0000, jerry@chordia.co.uk wrote:

> One problem is that this now makes it difficult to share packages. I'm

What do you mean by "share packages" ?

Thomas
jerry@chordia.co.uk Dec. 12, 2016, 2:15 p.m. UTC | #2 
Hi Thomas,

> What do you mean by "share packages" ?

Code common to all targets but stored outside of the buildroot installation.


The issue is moot. The new mechanism will work as it stands.
 
Thanks again.

Jerry
diff mbox

Patch

diff --git a/support/scripts/br2-external b/support/scripts/br2-external
index 055dc08..ea23399 100755
--- a/support/scripts/br2-external
+++ b/support/scripts/br2-external
@@ -147,6 +147,9 @@  do_mk() {
         printf 'export BR2_EXTERNAL_%s_PATH = %s\n' "${br2_name}"
"${br2_ext}"
         printf 'export BR2_EXTERNAL_%s_DESC = %s\n' "${br2_name}"
"${br2_desc}"
     done
+
+       # keep so we know the name of 'this' external
+       printf 'export BR2_EXTERNAL = %s\n' "${BR2_EXTERNAL}"
 }