| Message ID | 20240404211228.1979139-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/exim: add libxcrypt optional dependency | expand |
Hi Fabrice, On Thu, 4 Apr 2024 23:12:28 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Fix the following build failure raised since bump of glibc to version > 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97: > > crypt16.c:45:10: fatal error: crypt.h: No such file or directory > 45 | #include <crypt.h> > | ^~~~~~~~~ > > Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97 > - http://autobuild.buildroot.org/results/3c846c763a05f2569db7a019af8b91b0563c8f42 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Thank you for the fix. Indeed libxcrypt was removed from glibc 2.39: https://lists.gnu.org/archive/html/info-gnu/2024-01/msg00017.html Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Fabrice, All, On 2024-04-04 23:12 +0200, Fabrice Fontaine spake thusly: > Fix the following build failure raised since bump of glibc to version > 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97: > > crypt16.c:45:10: fatal error: crypt.h: No such file or directory > 45 | #include <crypt.h> > | ^~~~~~~~~ > > Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97 > - http://autobuild.buildroot.org/results/3c846c763a05f2569db7a019af8b91b0563c8f42 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/exim/Config.in | 1 + > package/exim/exim.mk | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/package/exim/Config.in b/package/exim/Config.in > index 2557251fd1..0d2f5f4999 100644 > --- a/package/exim/Config.in > +++ b/package/exim/Config.in > @@ -7,6 +7,7 @@ config BR2_PACKAGE_EXIM > depends on BR2_TOOLCHAIN_HAS_THREADS > select BR2_PACKAGE_PCRE2 > select BR2_PACKAGE_BERKELEYDB > + select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC > help > Exim is a message transfer agent (MTA) developed at the > University of Cambridge for use on Unix systems connected to > diff --git a/package/exim/exim.mk b/package/exim/exim.mk > index 84fe96218c..d78b95ad15 100644 > --- a/package/exim/exim.mk > +++ b/package/exim/exim.mk > @@ -75,6 +75,10 @@ define EXIM_USE_DEFAULT_CONFIG_FILE_CLAMAV > endef > endif > > +ifeq ($(BR2_PACKAGE_LIBXCRYPT),y) > +EXIM_DEPENDENCIES += libxcrypt > +endif > + > ifeq ($(BR2_PACKAGE_OPENSSL),y) > EXIM_DEPENDENCIES += host-openssl openssl > define EXIM_USE_DEFAULT_CONFIG_FILE_OPENSSL > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/exim/Config.in b/package/exim/Config.in index 2557251fd1..0d2f5f4999 100644 --- a/package/exim/Config.in +++ b/package/exim/Config.in @@ -7,6 +7,7 @@ config BR2_PACKAGE_EXIM depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_PCRE2 select BR2_PACKAGE_BERKELEYDB + select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC help Exim is a message transfer agent (MTA) developed at the University of Cambridge for use on Unix systems connected to diff --git a/package/exim/exim.mk b/package/exim/exim.mk index 84fe96218c..d78b95ad15 100644 --- a/package/exim/exim.mk +++ b/package/exim/exim.mk @@ -75,6 +75,10 @@ define EXIM_USE_DEFAULT_CONFIG_FILE_CLAMAV endef endif +ifeq ($(BR2_PACKAGE_LIBXCRYPT),y) +EXIM_DEPENDENCIES += libxcrypt +endif + ifeq ($(BR2_PACKAGE_OPENSSL),y) EXIM_DEPENDENCIES += host-openssl openssl define EXIM_USE_DEFAULT_CONFIG_FILE_OPENSSL
Fix the following build failure raised since bump of glibc to version 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97: crypt16.c:45:10: fatal error: crypt.h: No such file or directory 45 | #include <crypt.h> | ^~~~~~~~~ Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97 - http://autobuild.buildroot.org/results/3c846c763a05f2569db7a019af8b91b0563c8f42 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/exim/Config.in | 1 + package/exim/exim.mk | 4 ++++ 2 files changed, 5 insertions(+)