| Message ID | 20240206192543.7179-3-ddrokosov@salutedevices.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | package/linux-tools: introduce linux mm tools | expand |
Dmitry, All, On 2024-02-06 22:25 +0300, Dmitry Rokosov spake thusly: > From: Konstantin Menyaev <KAMenyaev@sberdevices.ru> > > - LINUX_TOOLS_MAKE_OPTS option introduced: > allows to override CROSS_COMPILE param What is the rationale for this? How is it supposed to be used? CROSS_COMPILE is already part of LINUX_MAKE_FLAGS, so there is no reason to pass it explicitly either. Otherwise, I am not convinced anout the "multilib" title either, because Buildroot does not do multilib systems anyway, so I am missing the point of the patch... If you feel there really is a nedd, please resubmit with an extended commit log. Thanks! Regards, Yann E. MORIN. > Signed-off-by: Konstantin Menyaev <KAMenyaev@sberdevices.ru> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > package/linux-tools/linux-tool-gpio.mk.in | 2 +- > package/linux-tools/linux-tool-iio.mk.in | 2 +- > package/linux-tools/linux-tool-mm.mk.in | 2 +- > package/linux-tools/linux-tool-pci.mk.in | 2 +- > package/linux-tools/linux-tool-perf.mk.in | 2 +- > package/linux-tools/linux-tool-selftests.mk.in | 2 +- > package/linux-tools/linux-tool-tmon.mk.in | 2 +- > package/linux-tools/linux-tools.mk | 2 ++ > 8 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/package/linux-tools/linux-tool-gpio.mk.in b/package/linux-tools/linux-tool-gpio.mk.in > index e825db1b1127..dcee11002e8c 100644 > --- a/package/linux-tools/linux-tool-gpio.mk.in > +++ b/package/linux-tools/linux-tool-gpio.mk.in > @@ -6,7 +6,7 @@ > > LINUX_TOOLS += gpio > > -GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > +GPIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > define GPIO_BUILD_CMDS > $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \ > diff --git a/package/linux-tools/linux-tool-iio.mk.in b/package/linux-tools/linux-tool-iio.mk.in > index 27ab0ed7ed63..1372faafd1a8 100644 > --- a/package/linux-tools/linux-tool-iio.mk.in > +++ b/package/linux-tools/linux-tool-iio.mk.in > @@ -6,7 +6,7 @@ > > LINUX_TOOLS += iio > > -IIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > +IIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > define IIO_BUILD_CMDS > $(Q)if ! grep install $(LINUX_DIR)/tools/iio/Makefile >/dev/null 2>&1 ; then \ > diff --git a/package/linux-tools/linux-tool-mm.mk.in b/package/linux-tools/linux-tool-mm.mk.in > index 5431e0574b04..51a54026dea4 100644 > --- a/package/linux-tools/linux-tool-mm.mk.in > +++ b/package/linux-tools/linux-tool-mm.mk.in > @@ -7,7 +7,7 @@ > LINUX_TOOLS += mm > > MM_DEPENDENCIES = linux > -MM_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CC="$(TARGET_CC)" > +MM_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) CC="$(TARGET_CC)" > > define MM_BUILD_CMDS > $(Q)if test -f $(LINUX_DIR)/tools/vm/Makefile ; then \ > diff --git a/package/linux-tools/linux-tool-pci.mk.in b/package/linux-tools/linux-tool-pci.mk.in > index 17246f5d7ed2..48c3435a5c8a 100644 > --- a/package/linux-tools/linux-tool-pci.mk.in > +++ b/package/linux-tools/linux-tool-pci.mk.in > @@ -6,7 +6,7 @@ > > LINUX_TOOLS += pci > > -PCI_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > +PCI_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > define PCI_BUILD_CMDS > $(Q)if ! grep install $(LINUX_DIR)/tools/pci/Makefile >/dev/null 2>&1 ; then \ > diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in > index ee308a85dfd1..38910cda7d75 100644 > --- a/package/linux-tools/linux-tool-perf.mk.in > +++ b/package/linux-tools/linux-tool-perf.mk.in > @@ -19,7 +19,7 @@ PERF_ARCH=$(NORMALIZED_ARCH) > endif > > PERF_MAKE_FLAGS = \ > - $(LINUX_MAKE_FLAGS) \ > + $(LINUX_TOOLS_MAKE_OPTS) \ > JOBS=$(PARALLEL_JOBS) \ > ARCH=$(PERF_ARCH) \ > DESTDIR=$(TARGET_DIR) \ > diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in > index e29c7f59debd..144dd6616f2b 100644 > --- a/package/linux-tools/linux-tool-selftests.mk.in > +++ b/package/linux-tools/linux-tool-selftests.mk.in > @@ -22,7 +22,7 @@ SELFTESTS_DEPENDENCIES = \ > $(if $(BR2_PACKAGE_OPENSSL),openssl) > > SELFTESTS_MAKE_FLAGS = \ > - $(LINUX_MAKE_FLAGS) \ > + $(LINUX_TOOLS_MAKE_OPTS) \ > ARCH=$(SELFTESTS_ARCH) > > # O must be redefined here to overwrite the one used by Buildroot for > diff --git a/package/linux-tools/linux-tool-tmon.mk.in b/package/linux-tools/linux-tool-tmon.mk.in > index 56c328c51fd7..7c33915049c2 100644 > --- a/package/linux-tools/linux-tool-tmon.mk.in > +++ b/package/linux-tools/linux-tool-tmon.mk.in > @@ -7,7 +7,7 @@ > LINUX_TOOLS += tmon > > TMON_DEPENDENCIES = host-pkgconf ncurses > -TMON_MAKE_OPTS = $(LINUX_MAKE_FLAGS) \ > +TMON_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) \ > CC=$(TARGET_CC) \ > LDFLAGS="$(TARGET_LDFLAGS)" \ > PKG_CONFIG_PATH=$(STAGING_DIR)/usr/lib/pkgconfig > diff --git a/package/linux-tools/linux-tools.mk b/package/linux-tools/linux-tools.mk > index 81b1fbc17605..38bb2c83966a 100644 > --- a/package/linux-tools/linux-tools.mk > +++ b/package/linux-tools/linux-tools.mk > @@ -26,6 +26,8 @@ LINUX_TOOLS_PATCH_DEPENDENCIES = linux > # may install shared libraries and headers (e.g. cpupower). > LINUX_TOOLS_INSTALL_STAGING = YES > > +LINUX_TOOLS_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CROSS_COMPILE="$(TARGET_CROSS)" > + > LINUX_TOOLS_DEPENDENCIES += $(foreach tool,$(LINUX_TOOLS),\ > $(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\ > $($(call UPPERCASE,$(tool))_DEPENDENCIES))) > -- > 2.43.0 >
Hello Yann, Thank you very much for such a quick response! On Wed, Feb 07, 2024 at 10:07:51AM +0100, Yann E. MORIN wrote: > Dmitry, All, > > On 2024-02-06 22:25 +0300, Dmitry Rokosov spake thusly: > > From: Konstantin Menyaev <KAMenyaev@sberdevices.ru> > > > > - LINUX_TOOLS_MAKE_OPTS option introduced: > > allows to override CROSS_COMPILE param > > What is the rationale for this? How is it supposed to be used? > > CROSS_COMPILE is already part of LINUX_MAKE_FLAGS, so there is no reason > to pass it explicitly either. > > Otherwise, I am not convinced anout the "multilib" title either, because > Buildroot does not do multilib systems anyway, so I am missing the point > of the patch... > > If you feel there really is a nedd, please resubmit with an extended > commit log. Thanks! Okay, we will try to describe it with extra comments and resubmit the patch in the separate email. > > Regards, > Yann E. MORIN. > > > Signed-off-by: Konstantin Menyaev <KAMenyaev@sberdevices.ru> > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > --- > > package/linux-tools/linux-tool-gpio.mk.in | 2 +- > > package/linux-tools/linux-tool-iio.mk.in | 2 +- > > package/linux-tools/linux-tool-mm.mk.in | 2 +- > > package/linux-tools/linux-tool-pci.mk.in | 2 +- > > package/linux-tools/linux-tool-perf.mk.in | 2 +- > > package/linux-tools/linux-tool-selftests.mk.in | 2 +- > > package/linux-tools/linux-tool-tmon.mk.in | 2 +- > > package/linux-tools/linux-tools.mk | 2 ++ > > 8 files changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/package/linux-tools/linux-tool-gpio.mk.in b/package/linux-tools/linux-tool-gpio.mk.in > > index e825db1b1127..dcee11002e8c 100644 > > --- a/package/linux-tools/linux-tool-gpio.mk.in > > +++ b/package/linux-tools/linux-tool-gpio.mk.in > > @@ -6,7 +6,7 @@ > > > > LINUX_TOOLS += gpio > > > > -GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > > +GPIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > > > define GPIO_BUILD_CMDS > > $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \ > > diff --git a/package/linux-tools/linux-tool-iio.mk.in b/package/linux-tools/linux-tool-iio.mk.in > > index 27ab0ed7ed63..1372faafd1a8 100644 > > --- a/package/linux-tools/linux-tool-iio.mk.in > > +++ b/package/linux-tools/linux-tool-iio.mk.in > > @@ -6,7 +6,7 @@ > > > > LINUX_TOOLS += iio > > > > -IIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > > +IIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > > > define IIO_BUILD_CMDS > > $(Q)if ! grep install $(LINUX_DIR)/tools/iio/Makefile >/dev/null 2>&1 ; then \ > > diff --git a/package/linux-tools/linux-tool-mm.mk.in b/package/linux-tools/linux-tool-mm.mk.in > > index 5431e0574b04..51a54026dea4 100644 > > --- a/package/linux-tools/linux-tool-mm.mk.in > > +++ b/package/linux-tools/linux-tool-mm.mk.in > > @@ -7,7 +7,7 @@ > > LINUX_TOOLS += mm > > > > MM_DEPENDENCIES = linux > > -MM_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CC="$(TARGET_CC)" > > +MM_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) CC="$(TARGET_CC)" > > > > define MM_BUILD_CMDS > > $(Q)if test -f $(LINUX_DIR)/tools/vm/Makefile ; then \ > > diff --git a/package/linux-tools/linux-tool-pci.mk.in b/package/linux-tools/linux-tool-pci.mk.in > > index 17246f5d7ed2..48c3435a5c8a 100644 > > --- a/package/linux-tools/linux-tool-pci.mk.in > > +++ b/package/linux-tools/linux-tool-pci.mk.in > > @@ -6,7 +6,7 @@ > > > > LINUX_TOOLS += pci > > > > -PCI_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" > > +PCI_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" > > > > define PCI_BUILD_CMDS > > $(Q)if ! grep install $(LINUX_DIR)/tools/pci/Makefile >/dev/null 2>&1 ; then \ > > diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in > > index ee308a85dfd1..38910cda7d75 100644 > > --- a/package/linux-tools/linux-tool-perf.mk.in > > +++ b/package/linux-tools/linux-tool-perf.mk.in > > @@ -19,7 +19,7 @@ PERF_ARCH=$(NORMALIZED_ARCH) > > endif > > > > PERF_MAKE_FLAGS = \ > > - $(LINUX_MAKE_FLAGS) \ > > + $(LINUX_TOOLS_MAKE_OPTS) \ > > JOBS=$(PARALLEL_JOBS) \ > > ARCH=$(PERF_ARCH) \ > > DESTDIR=$(TARGET_DIR) \ > > diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in > > index e29c7f59debd..144dd6616f2b 100644 > > --- a/package/linux-tools/linux-tool-selftests.mk.in > > +++ b/package/linux-tools/linux-tool-selftests.mk.in > > @@ -22,7 +22,7 @@ SELFTESTS_DEPENDENCIES = \ > > $(if $(BR2_PACKAGE_OPENSSL),openssl) > > > > SELFTESTS_MAKE_FLAGS = \ > > - $(LINUX_MAKE_FLAGS) \ > > + $(LINUX_TOOLS_MAKE_OPTS) \ > > ARCH=$(SELFTESTS_ARCH) > > > > # O must be redefined here to overwrite the one used by Buildroot for > > diff --git a/package/linux-tools/linux-tool-tmon.mk.in b/package/linux-tools/linux-tool-tmon.mk.in > > index 56c328c51fd7..7c33915049c2 100644 > > --- a/package/linux-tools/linux-tool-tmon.mk.in > > +++ b/package/linux-tools/linux-tool-tmon.mk.in > > @@ -7,7 +7,7 @@ > > LINUX_TOOLS += tmon > > > > TMON_DEPENDENCIES = host-pkgconf ncurses > > -TMON_MAKE_OPTS = $(LINUX_MAKE_FLAGS) \ > > +TMON_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) \ > > CC=$(TARGET_CC) \ > > LDFLAGS="$(TARGET_LDFLAGS)" \ > > PKG_CONFIG_PATH=$(STAGING_DIR)/usr/lib/pkgconfig > > diff --git a/package/linux-tools/linux-tools.mk b/package/linux-tools/linux-tools.mk > > index 81b1fbc17605..38bb2c83966a 100644 > > --- a/package/linux-tools/linux-tools.mk > > +++ b/package/linux-tools/linux-tools.mk > > @@ -26,6 +26,8 @@ LINUX_TOOLS_PATCH_DEPENDENCIES = linux > > # may install shared libraries and headers (e.g. cpupower). > > LINUX_TOOLS_INSTALL_STAGING = YES > > > > +LINUX_TOOLS_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CROSS_COMPILE="$(TARGET_CROSS)" > > + > > LINUX_TOOLS_DEPENDENCIES += $(foreach tool,$(LINUX_TOOLS),\ > > $(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\ > > $($(call UPPERCASE,$(tool))_DEPENDENCIES))) > > -- > > 2.43.0 > > > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
diff --git a/package/linux-tools/linux-tool-gpio.mk.in b/package/linux-tools/linux-tool-gpio.mk.in index e825db1b1127..dcee11002e8c 100644 --- a/package/linux-tools/linux-tool-gpio.mk.in +++ b/package/linux-tools/linux-tool-gpio.mk.in @@ -6,7 +6,7 @@ LINUX_TOOLS += gpio -GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" +GPIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" define GPIO_BUILD_CMDS $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \ diff --git a/package/linux-tools/linux-tool-iio.mk.in b/package/linux-tools/linux-tool-iio.mk.in index 27ab0ed7ed63..1372faafd1a8 100644 --- a/package/linux-tools/linux-tool-iio.mk.in +++ b/package/linux-tools/linux-tool-iio.mk.in @@ -6,7 +6,7 @@ LINUX_TOOLS += iio -IIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" +IIO_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" define IIO_BUILD_CMDS $(Q)if ! grep install $(LINUX_DIR)/tools/iio/Makefile >/dev/null 2>&1 ; then \ diff --git a/package/linux-tools/linux-tool-mm.mk.in b/package/linux-tools/linux-tool-mm.mk.in index 5431e0574b04..51a54026dea4 100644 --- a/package/linux-tools/linux-tool-mm.mk.in +++ b/package/linux-tools/linux-tool-mm.mk.in @@ -7,7 +7,7 @@ LINUX_TOOLS += mm MM_DEPENDENCIES = linux -MM_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CC="$(TARGET_CC)" +MM_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) CC="$(TARGET_CC)" define MM_BUILD_CMDS $(Q)if test -f $(LINUX_DIR)/tools/vm/Makefile ; then \ diff --git a/package/linux-tools/linux-tool-pci.mk.in b/package/linux-tools/linux-tool-pci.mk.in index 17246f5d7ed2..48c3435a5c8a 100644 --- a/package/linux-tools/linux-tool-pci.mk.in +++ b/package/linux-tools/linux-tool-pci.mk.in @@ -6,7 +6,7 @@ LINUX_TOOLS += pci -PCI_MAKE_OPTS = $(LINUX_MAKE_FLAGS) LDFLAGS="$(TARGET_LDFLAGS)" +PCI_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) LDFLAGS="$(TARGET_LDFLAGS)" define PCI_BUILD_CMDS $(Q)if ! grep install $(LINUX_DIR)/tools/pci/Makefile >/dev/null 2>&1 ; then \ diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in index ee308a85dfd1..38910cda7d75 100644 --- a/package/linux-tools/linux-tool-perf.mk.in +++ b/package/linux-tools/linux-tool-perf.mk.in @@ -19,7 +19,7 @@ PERF_ARCH=$(NORMALIZED_ARCH) endif PERF_MAKE_FLAGS = \ - $(LINUX_MAKE_FLAGS) \ + $(LINUX_TOOLS_MAKE_OPTS) \ JOBS=$(PARALLEL_JOBS) \ ARCH=$(PERF_ARCH) \ DESTDIR=$(TARGET_DIR) \ diff --git a/package/linux-tools/linux-tool-selftests.mk.in b/package/linux-tools/linux-tool-selftests.mk.in index e29c7f59debd..144dd6616f2b 100644 --- a/package/linux-tools/linux-tool-selftests.mk.in +++ b/package/linux-tools/linux-tool-selftests.mk.in @@ -22,7 +22,7 @@ SELFTESTS_DEPENDENCIES = \ $(if $(BR2_PACKAGE_OPENSSL),openssl) SELFTESTS_MAKE_FLAGS = \ - $(LINUX_MAKE_FLAGS) \ + $(LINUX_TOOLS_MAKE_OPTS) \ ARCH=$(SELFTESTS_ARCH) # O must be redefined here to overwrite the one used by Buildroot for diff --git a/package/linux-tools/linux-tool-tmon.mk.in b/package/linux-tools/linux-tool-tmon.mk.in index 56c328c51fd7..7c33915049c2 100644 --- a/package/linux-tools/linux-tool-tmon.mk.in +++ b/package/linux-tools/linux-tool-tmon.mk.in @@ -7,7 +7,7 @@ LINUX_TOOLS += tmon TMON_DEPENDENCIES = host-pkgconf ncurses -TMON_MAKE_OPTS = $(LINUX_MAKE_FLAGS) \ +TMON_MAKE_OPTS = $(LINUX_TOOLS_MAKE_OPTS) \ CC=$(TARGET_CC) \ LDFLAGS="$(TARGET_LDFLAGS)" \ PKG_CONFIG_PATH=$(STAGING_DIR)/usr/lib/pkgconfig diff --git a/package/linux-tools/linux-tools.mk b/package/linux-tools/linux-tools.mk index 81b1fbc17605..38bb2c83966a 100644 --- a/package/linux-tools/linux-tools.mk +++ b/package/linux-tools/linux-tools.mk @@ -26,6 +26,8 @@ LINUX_TOOLS_PATCH_DEPENDENCIES = linux # may install shared libraries and headers (e.g. cpupower). LINUX_TOOLS_INSTALL_STAGING = YES +LINUX_TOOLS_MAKE_OPTS = $(LINUX_MAKE_FLAGS) CROSS_COMPILE="$(TARGET_CROSS)" + LINUX_TOOLS_DEPENDENCIES += $(foreach tool,$(LINUX_TOOLS),\ $(if $(BR2_PACKAGE_LINUX_TOOLS_$(call UPPERCASE,$(tool))),\ $($(call UPPERCASE,$(tool))_DEPENDENCIES)))