Message ID | 20240118182808.551258-1-francois.perrad@gadz.org |
---|---|
State | Accepted |
Headers | show |
Series | package/autoconf: bump to version 2.72 | expand |
Hello François, On Thu, 18 Jan 2024 19:28:08 +0100 Francois Perrad <fperrad@gmail.com> wrote: > https://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS?h=v2.72 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Thanks for the bump. How much testing did you do after this bump with packages that have AUTORECONF = YES ? It is indeed fairly common for autoconf bumps to break things. We certainly don't need a full testing coverage before merging (we have autobuilders for that), but the testing of a reasonably large configurations of packages that set AUTORECONF = YES would be nice. Thanks a lot! Thomas
Le ven. 19 janv. 2024 à 12:25, Thomas Petazzoni via buildroot < buildroot@buildroot.org> a écrit : > Hello François, > > On Thu, 18 Jan 2024 19:28:08 +0100 > Francois Perrad <fperrad@gmail.com> wrote: > > > https://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS?h=v2.72 > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > Thanks for the bump. How much testing did you do after this bump with > packages that have AUTORECONF = YES ? > > It is indeed fairly common for autoconf bumps to break things. We > certainly don't need a full testing coverage before merging (we have > autobuilders for that), but the testing of a reasonably large > configurations of packages that set AUTORECONF = YES would be nice. > > Hello Thomas, successfully tested with these packages: luasyslog memcached mfoc mini-snmpd minizip-zlib monit mstpd mtr netsnmp ngrep nut octave openntpd openocd openpgm pdbg perftest pixman pkcs11-helper poke powertop pppd privoxy procps-ng psplash ptm2human ptpd2 python3 raptor restclient-cpp rrdtool screen scrub sdl sdl_mixer sedutil shared-mime-info smack sngrep snort socketcand sofia-sip softether sox spi-tools sscep start-stop-daemon stress syslog-ng tftpd tinydtls tinyxml trousers util-linux vtun wolftpm wpan-tools zabbixzyre It seems that this bump will not cause too many breakage. François > Thanks a lot! > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot >
Hello François, On Thu, 18 Jan 2024 19:28:08 +0100 Francois Perrad <fperrad@gmail.com> wrote: > https://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS?h=v2.72 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/autoconf/0001-dont-add-dirty-to-version.patch | 2 +- > package/autoconf/autoconf.hash | 2 +- > package/autoconf/autoconf.mk | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Following your feedback, I applied and pushed your patch to master. Let's watch and see how things go in the autobuilders in the next few days. Thanks! Thomas
On Thu, 18 Jan 2024 19:28:08 +0100 Francois Perrad <fperrad@gmail.com> wrote: > https://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS?h=v2.72 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/autoconf/0001-dont-add-dirty-to-version.patch | 2 +- > package/autoconf/autoconf.hash | 2 +- > package/autoconf/autoconf.mk | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) This version bump broke the build of host-erlang: http://autobuild.buildroot.net/results/cab/cabca5a5ed9bb0874ed33e58a69947b50a6e2318/build-end.log Could you have a look? Perhaps it's just the host-erlang configure machinery that is too strict, and simply their check needs to be relaxed. Thanks! Thomas
diff --git a/package/autoconf/0001-dont-add-dirty-to-version.patch b/package/autoconf/0001-dont-add-dirty-to-version.patch index e8d9f6a29..8df227686 100644 --- a/package/autoconf/0001-dont-add-dirty-to-version.patch +++ b/package/autoconf/0001-dont-add-dirty-to-version.patch @@ -17,7 +17,7 @@ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> diff -Nura autoconf-2.69.orig/build-aux/git-version-gen autoconf-2.69/build-aux/git-version-gen --- autoconf-2.69.orig/build-aux/git-version-gen 2013-06-27 11:31:02.340200154 -0300 +++ autoconf-2.69/build-aux/git-version-gen 2013-06-27 11:31:13.734577033 -0300 -@@ -203,7 +203,7 @@ +@@ -210,7 +210,7 @@ *) # Append the suffix only if there isn't one already. case $v in *-dirty) ;; diff --git a/package/autoconf/autoconf.hash b/package/autoconf/autoconf.hash index de0840dd8..f94b2d9de 100644 --- a/package/autoconf/autoconf.hash +++ b/package/autoconf/autoconf.hash @@ -1,4 +1,4 @@ # Locally calculated after checking pgp signature -sha256 f14c83cfebcc9427f2c3cea7258bd90df972d92eb26752da4ddad81c87a0faa4 autoconf-2.71.tar.xz +sha256 ba885c1319578d6c94d46e9b0dceb4014caafe2490e437a0dbca3f270a223f5a autoconf-2.72.tar.xz sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYINGv3 sha256 1f1cde9fb68b9b3cff18c420894bec5bd4defacd700b7d13df54a887301e5350 COPYING.EXCEPTION diff --git a/package/autoconf/autoconf.mk b/package/autoconf/autoconf.mk index 15ce9d592..48bfc80e7 100644 --- a/package/autoconf/autoconf.mk +++ b/package/autoconf/autoconf.mk @@ -4,7 +4,7 @@ # ################################################################################ -AUTOCONF_VERSION = 2.71 +AUTOCONF_VERSION = 2.72 AUTOCONF_SOURCE = autoconf-$(AUTOCONF_VERSION).tar.xz AUTOCONF_SITE = $(BR2_GNU_MIRROR)/autoconf
https://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS?h=v2.72 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/autoconf/0001-dont-add-dirty-to-version.patch | 2 +- package/autoconf/autoconf.hash | 2 +- package/autoconf/autoconf.mk | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)