| Message ID | 20231118015456.2629144-7-adam.duskett@amarulasolutions.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [PATCH/next,1/7] package/xdg-user-dirs: new package | expand |
Adam, All, On 2023-11-17 18:54 -0700, Adam Duskett spake thusly: > - Don't use relative symlinks. Why not? We do that a bit all over the place already... > - Remove kernel_blob.bin and instead touch a blank one in case an > application checks for kernel_blob.bin. This saves 86M of space! Why is it OK to remove that file? And will there ever be applictions that will require an actual one rather than our dummy empty file? Regards, Yann E. MORIN. > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> > --- > package/flutter-gallery/flutter-gallery.mk | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/package/flutter-gallery/flutter-gallery.mk b/package/flutter-gallery/flutter-gallery.mk > index 5299b18134..492b426510 100644 > --- a/package/flutter-gallery/flutter-gallery.mk > +++ b/package/flutter-gallery/flutter-gallery.mk > @@ -46,10 +46,12 @@ define FLUTTER_GALLERY_INSTALL_TARGET_CMDS > $(INSTALL) -D -m 0755 $(@D)/libapp.so \ > $(FLUTTER_GALLERY_INSTALL_DIR)/lib/libapp.so > > - ln -sf ../../../$(FLUTTER_ENGINE_RUNTIME_MODE)/data/icudtl.dat \ > + ln -sf /usr/share/flutter/$(FLUTTER_ENGINE_RUNTIME_MODE)/data/icudtl.dat \ > $(FLUTTER_GALLERY_INSTALL_DIR)/data/ > > - ln -sf ../../../../../lib/libflutter_engine.so $(FLUTTER_GALLERY_INSTALL_DIR)/lib/ > + ln -sf /usr/lib/libflutter_engine.so $(FLUTTER_GALLERY_INSTALL_DIR)/lib/ > + $(RM) $(FLUTTER_GALLERY_INSTALL_DIR)/data/flutter_assets/kernel_blob.bin > + touch $(FLUTTER_GALLERY_INSTALL_DIR)/data/flutter_assets/kernel_blob.bin > endef > > $(eval $(generic-package)) > -- > 2.42.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/flutter-gallery/flutter-gallery.mk b/package/flutter-gallery/flutter-gallery.mk index 5299b18134..492b426510 100644 --- a/package/flutter-gallery/flutter-gallery.mk +++ b/package/flutter-gallery/flutter-gallery.mk @@ -46,10 +46,12 @@ define FLUTTER_GALLERY_INSTALL_TARGET_CMDS $(INSTALL) -D -m 0755 $(@D)/libapp.so \ $(FLUTTER_GALLERY_INSTALL_DIR)/lib/libapp.so - ln -sf ../../../$(FLUTTER_ENGINE_RUNTIME_MODE)/data/icudtl.dat \ + ln -sf /usr/share/flutter/$(FLUTTER_ENGINE_RUNTIME_MODE)/data/icudtl.dat \ $(FLUTTER_GALLERY_INSTALL_DIR)/data/ - ln -sf ../../../../../lib/libflutter_engine.so $(FLUTTER_GALLERY_INSTALL_DIR)/lib/ + ln -sf /usr/lib/libflutter_engine.so $(FLUTTER_GALLERY_INSTALL_DIR)/lib/ + $(RM) $(FLUTTER_GALLERY_INSTALL_DIR)/data/flutter_assets/kernel_blob.bin + touch $(FLUTTER_GALLERY_INSTALL_DIR)/data/flutter_assets/kernel_blob.bin endef $(eval $(generic-package))
- Don't use relative symlinks. - Remove kernel_blob.bin and instead touch a blank one in case an application checks for kernel_blob.bin. This saves 86M of space! Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> --- package/flutter-gallery/flutter-gallery.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)