| Message ID | 20231026203632.6065-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/libmemcached: force CMAKE_BUILD_TYPE | expand |
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Force CMAKE_BUILD_TYPE to Release to avoid the following build failure > with c-icap or php-memcached raised since bump to version 1.1.4 and > switch to cmake-package in commit > 7205df8a4f3c729b11a5f0c34885e6cf592f24b9: > Fixes: > - http://autobuild.buildroot.org/results/bca84915550a72f1dc89c8661cba2545d6bc96ef > - http://autobuild.buildroot.org/results/b140d225208e7fa44b935a119e74347caf710e55 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/libmemcached/libmemcached.mk | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/package/libmemcached/libmemcached.mk b/package/libmemcached/libmemcached.mk > index bd63d78c97..2c268d4151 100644 > --- a/package/libmemcached/libmemcached.mk > +++ b/package/libmemcached/libmemcached.mk > @@ -14,6 +14,10 @@ LIBMEMCACHED_LICENSE = BSD-3-Clause > LIBMEMCACHED_LICENSE_FILES = LICENSE > LIBMEMCACHED_CPE_ID_VENDOR = awesome > +# Force Release otherwise libraries will be suffixed by -dbg which will raise > +# unexpected build failures with packages that use libmemcached (e.g. c-icap) > +LIBMEMCACHED_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release > + As correctly warned by check-package: Applying: package/libmemcached: force CMAKE_BUILD_TYPE gpackage/libmemcached/libmemcached.mk:19: unconditional override of variable LIBMEMCACHED_CONF_OPTS _CONF_OPTS already get set in line 10, so I changed this to be += and applied, thanks.
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: >> Force CMAKE_BUILD_TYPE to Release to avoid the following build failure >> with c-icap or php-memcached raised since bump to version 1.1.4 and >> switch to cmake-package in commit >> 7205df8a4f3c729b11a5f0c34885e6cf592f24b9: >> Fixes: >> - http://autobuild.buildroot.org/results/bca84915550a72f1dc89c8661cba2545d6bc96ef >> - http://autobuild.buildroot.org/results/b140d225208e7fa44b935a119e74347caf710e55 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> >> --- >> package/libmemcached/libmemcached.mk | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/package/libmemcached/libmemcached.mk b/package/libmemcached/libmemcached.mk >> index bd63d78c97..2c268d4151 100644 >> --- a/package/libmemcached/libmemcached.mk >> +++ b/package/libmemcached/libmemcached.mk >> @@ -14,6 +14,10 @@ LIBMEMCACHED_LICENSE = BSD-3-Clause >> LIBMEMCACHED_LICENSE_FILES = LICENSE >> LIBMEMCACHED_CPE_ID_VENDOR = awesome >> +# Force Release otherwise libraries will be suffixed by -dbg which will raise >> +# unexpected build failures with packages that use libmemcached (e.g. c-icap) >> +LIBMEMCACHED_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release >> + > As correctly warned by check-package: > Applying: package/libmemcached: force CMAKE_BUILD_TYPE > gpackage/libmemcached/libmemcached.mk:19: unconditional override of variable LIBMEMCACHED_CONF_OPTS > _CONF_OPTS already get set in line 10, so I changed this to be += and > applied, thanks. Committed to 2023.08.x, thanks.
diff --git a/package/libmemcached/libmemcached.mk b/package/libmemcached/libmemcached.mk index bd63d78c97..2c268d4151 100644 --- a/package/libmemcached/libmemcached.mk +++ b/package/libmemcached/libmemcached.mk @@ -14,6 +14,10 @@ LIBMEMCACHED_LICENSE = BSD-3-Clause LIBMEMCACHED_LICENSE_FILES = LICENSE LIBMEMCACHED_CPE_ID_VENDOR = awesome +# Force Release otherwise libraries will be suffixed by -dbg which will raise +# unexpected build failures with packages that use libmemcached (e.g. c-icap) +LIBMEMCACHED_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release + ifeq ($(BR2_PACKAGE_LIBEVENT),y) LIBMEMCACHED_DEPENDENCIES += libevent LIBMEMCACHED_CONF_OPTS += -DENABLE_MEMASLAP=ON
Force CMAKE_BUILD_TYPE to Release to avoid the following build failure with c-icap or php-memcached raised since bump to version 1.1.4 and switch to cmake-package in commit 7205df8a4f3c729b11a5f0c34885e6cf592f24b9: Fixes: - http://autobuild.buildroot.org/results/bca84915550a72f1dc89c8661cba2545d6bc96ef - http://autobuild.buildroot.org/results/b140d225208e7fa44b935a119e74347caf710e55 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/libmemcached/libmemcached.mk | 4 ++++ 1 file changed, 4 insertions(+)