| Message ID | 20231026092701.12345-16-adam.duskett@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/python3: bump version to 3.12.0 | expand |
Hi Adam, On 26/10/2023 11:26, Adam Duskett wrote: > Scons is a setuptools package now. > > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> > --- > package/scons/scons.hash | 4 ++-- > package/scons/scons.mk | 7 ++++--- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/package/scons/scons.hash b/package/scons/scons.hash > index a72fbaee5a..48b5077b2e 100644 > --- a/package/scons/scons.hash > +++ b/package/scons/scons.hash > @@ -1,3 +1,3 @@ > # Locally computed: > -sha256 7801f3f62f654528e272df780be10c0e9337e897650b62ddcee9f39fde13f8fb scons-3.1.2.tar.gz > -sha256 72ed889165fb28378cadac14552be4a959f1ebab6b148abb5dd2b49712c3c6f6 LICENSE.txt > +sha256 ce26aac95d350a79a4192196b0beac3cb24f4ccabce0123eb28d3370f576f072 SCons-4.5.2.tar.gz > +sha256 2f6ac9a1fc98394d18b80dba9bedb9d5626006d44db3fecf7cf3e21cff7e8b1c LICENSE The license hash changed. Can you report in the commit message why it changed (i.e., did something change about the license?) > diff --git a/package/scons/scons.mk b/package/scons/scons.mk > index 6b75d3ddca..767cf64b26 100644 > --- a/package/scons/scons.mk > +++ b/package/scons/scons.mk > @@ -4,11 +4,12 @@ > # > ################################################################################ > > -SCONS_VERSION = 3.1.2 > +SCONS_VERSION = 4.5.2 That's a pretty big bump. Have you tested if the scons packages (benejson, gpsd, mongodb) still build? Regards, Arnout > +SCONS_SOURCE = SCons-$(SCONS_VERSION).tar.gz > SCONS_SITE = http://downloads.sourceforge.net/project/scons/scons/$(SCONS_VERSION) > SCONS_LICENSE = MIT > -SCONS_LICENSE_FILES = LICENSE.txt > -SCONS_SETUP_TYPE = distutils > +SCONS_LICENSE_FILES = LICENSE > +SCONS_SETUP_TYPE = setuptools > > HOST_SCONS_INSTALL_OPTS = \ > --install-lib=$(HOST_DIR)/lib/scons-$(SCONS_VERSION)
On 04/11/2023 18:54, Arnout Vandecappelle wrote: > Hi Adam, > > On 26/10/2023 11:26, Adam Duskett wrote: >> Scons is a setuptools package now. >> >> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> >> --- >> package/scons/scons.hash | 4 ++-- >> package/scons/scons.mk | 7 ++++--- >> 2 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/package/scons/scons.hash b/package/scons/scons.hash >> index a72fbaee5a..48b5077b2e 100644 >> --- a/package/scons/scons.hash >> +++ b/package/scons/scons.hash >> @@ -1,3 +1,3 @@ >> # Locally computed: >> -sha256 7801f3f62f654528e272df780be10c0e9337e897650b62ddcee9f39fde13f8fb >> scons-3.1.2.tar.gz >> -sha256 72ed889165fb28378cadac14552be4a959f1ebab6b148abb5dd2b49712c3c6f6 >> LICENSE.txt >> +sha256 ce26aac95d350a79a4192196b0beac3cb24f4ccabce0123eb28d3370f576f072 >> SCons-4.5.2.tar.gz >> +sha256 2f6ac9a1fc98394d18b80dba9bedb9d5626006d44db3fecf7cf3e21cff7e8b1c LICENSE > > The license hash changed. Can you report in the commit message why it changed > (i.e., did something change about the license?) Ideally with `diff -w` output. Regards, Arnout > >> diff --git a/package/scons/scons.mk b/package/scons/scons.mk >> index 6b75d3ddca..767cf64b26 100644 >> --- a/package/scons/scons.mk >> +++ b/package/scons/scons.mk >> @@ -4,11 +4,12 @@ >> # >> ################################################################################ >> -SCONS_VERSION = 3.1.2 >> +SCONS_VERSION = 4.5.2 > > That's a pretty big bump. Have you tested if the scons packages (benejson, > gpsd, mongodb) still build? > > Regards, > Arnout > >> +SCONS_SOURCE = SCons-$(SCONS_VERSION).tar.gz >> SCONS_SITE = >> http://downloads.sourceforge.net/project/scons/scons/$(SCONS_VERSION) >> SCONS_LICENSE = MIT >> -SCONS_LICENSE_FILES = LICENSE.txt >> -SCONS_SETUP_TYPE = distutils >> +SCONS_LICENSE_FILES = LICENSE >> +SCONS_SETUP_TYPE = setuptools >> HOST_SCONS_INSTALL_OPTS = \ >> --install-lib=$(HOST_DIR)/lib/scons-$(SCONS_VERSION)
diff --git a/package/scons/scons.hash b/package/scons/scons.hash index a72fbaee5a..48b5077b2e 100644 --- a/package/scons/scons.hash +++ b/package/scons/scons.hash @@ -1,3 +1,3 @@ # Locally computed: -sha256 7801f3f62f654528e272df780be10c0e9337e897650b62ddcee9f39fde13f8fb scons-3.1.2.tar.gz -sha256 72ed889165fb28378cadac14552be4a959f1ebab6b148abb5dd2b49712c3c6f6 LICENSE.txt +sha256 ce26aac95d350a79a4192196b0beac3cb24f4ccabce0123eb28d3370f576f072 SCons-4.5.2.tar.gz +sha256 2f6ac9a1fc98394d18b80dba9bedb9d5626006d44db3fecf7cf3e21cff7e8b1c LICENSE diff --git a/package/scons/scons.mk b/package/scons/scons.mk index 6b75d3ddca..767cf64b26 100644 --- a/package/scons/scons.mk +++ b/package/scons/scons.mk @@ -4,11 +4,12 @@ # ################################################################################ -SCONS_VERSION = 3.1.2 +SCONS_VERSION = 4.5.2 +SCONS_SOURCE = SCons-$(SCONS_VERSION).tar.gz SCONS_SITE = http://downloads.sourceforge.net/project/scons/scons/$(SCONS_VERSION) SCONS_LICENSE = MIT -SCONS_LICENSE_FILES = LICENSE.txt -SCONS_SETUP_TYPE = distutils +SCONS_LICENSE_FILES = LICENSE +SCONS_SETUP_TYPE = setuptools HOST_SCONS_INSTALL_OPTS = \ --install-lib=$(HOST_DIR)/lib/scons-$(SCONS_VERSION)
Scons is a setuptools package now. Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> --- package/scons/scons.hash | 4 ++-- package/scons/scons.mk | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-)