| Message ID | 20230503185144.13679-2-ps.report@gmx.net |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1,1/2] package/coreutils: fix cross-compile (add gl_cv_macro_MB_CUR_MAX_good=yes) | expand |
Peter, All, On 2023-05-03 20:51 +0200, Peter Seiderer spake thusly: > - remove ac_cv_func_euidaccess=no (no longer used) > - rename ac_cv_func_lstat_dereferences_slashed_symlink=yes to > gl_cv_func_lstat_dereferences_slashed_symlink=yes I did not find this rename in your commit... > - remove ac_cv_func_lstat_empty_string_bug=no (no longer used) > - remove ac_cv_func_strtod=yes (no longer used) > - remove ac_cv_func_working_mktime=yes (no longer used) > - remove gl_cv_func_gettimeofday_clobber=no (no longer used) > - remove gl_cv_func_tzset_clobber=no (no longer used) > - remove gl_getline_needs_run_time_check=no (no longer used) It is a bit sad that core autotools packages like gnulib and coreustils can't natively cross-comple because of AC_TRY_RUN, and needs so much feeding of results... Care to check the rename, and respin, please? Regards, Yann E. MORIN. > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > package/coreutils/coreutils.mk | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk > index cf42a8aff8..7ee729ef48 100644 > --- a/package/coreutils/coreutils.mk > +++ b/package/coreutils/coreutils.mk > @@ -22,18 +22,13 @@ endif > > COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ > ac_cv_func_chown_works=yes \ > - ac_cv_func_euidaccess=no \ > ac_cv_func_fstatat=yes \ > ac_cv_func_getdelim=yes \ > ac_cv_func_getgroups=yes \ > ac_cv_func_getgroups_works=yes \ > ac_cv_func_getloadavg=no \ > - ac_cv_func_lstat_dereferences_slashed_symlink=yes \ > - ac_cv_func_lstat_empty_string_bug=no \ > ac_cv_func_strerror_r_char_p=no \ > ac_cv_func_strnlen_working=yes \ > - ac_cv_func_strtod=yes \ > - ac_cv_func_working_mktime=yes \ > ac_cv_have_decl_strerror_r=yes \ > ac_cv_have_decl_strnlen=yes \ > ac_cv_lib_getloadavg_getloadavg=no \ > @@ -44,15 +39,12 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ > fu_cv_sys_stat_statfs2_bsize=yes \ > gl_cv_func_getcwd_null=yes \ > gl_cv_func_getcwd_path_max=yes \ > - gl_cv_func_gettimeofday_clobber=no \ > gl_cv_func_link_follows_symlink=no \ > gl_cv_func_re_compile_pattern_working=yes \ > gl_cv_func_svid_putenv=yes \ > - gl_cv_func_tzset_clobber=no \ > gl_cv_func_working_mkstemp=yes \ > gl_cv_func_working_utimes=yes \ > gl_cv_macro_MB_CUR_MAX_good=yes \ > - gl_getline_needs_run_time_check=no \ > gl_cv_have_proc_uptime=yes \ > utils_cv_localtime_cache=no \ > PERL=missing \ > -- > 2.40.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Yann, On Thu, 4 May 2023 22:24:13 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > Peter, All, > > On 2023-05-03 20:51 +0200, Peter Seiderer spake thusly: > > - remove ac_cv_func_euidaccess=no (no longer used) > > - rename ac_cv_func_lstat_dereferences_slashed_symlink=yes to > > gl_cv_func_lstat_dereferences_slashed_symlink=yes > > I did not find this rename in your commit... Ups, you are right, seems to get lost..., thanks for careful review! > > > - remove ac_cv_func_lstat_empty_string_bug=no (no longer used) > > - remove ac_cv_func_strtod=yes (no longer used) > > - remove ac_cv_func_working_mktime=yes (no longer used) > > - remove gl_cv_func_gettimeofday_clobber=no (no longer used) > > - remove gl_cv_func_tzset_clobber=no (no longer used) > > - remove gl_getline_needs_run_time_check=no (no longer used) > > It is a bit sad that core autotools packages like gnulib and coreustils > can't natively cross-comple because of AC_TRY_RUN, and needs so much > feeding of results... > > Care to check the rename, and respin, please? Updated patch will follow... Regards, Peter > > Regards, > Yann E. MORIN. > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > package/coreutils/coreutils.mk | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk > > index cf42a8aff8..7ee729ef48 100644 > > --- a/package/coreutils/coreutils.mk > > +++ b/package/coreutils/coreutils.mk > > @@ -22,18 +22,13 @@ endif > > > > COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ > > ac_cv_func_chown_works=yes \ > > - ac_cv_func_euidaccess=no \ > > ac_cv_func_fstatat=yes \ > > ac_cv_func_getdelim=yes \ > > ac_cv_func_getgroups=yes \ > > ac_cv_func_getgroups_works=yes \ > > ac_cv_func_getloadavg=no \ > > - ac_cv_func_lstat_dereferences_slashed_symlink=yes \ > > - ac_cv_func_lstat_empty_string_bug=no \ > > ac_cv_func_strerror_r_char_p=no \ > > ac_cv_func_strnlen_working=yes \ > > - ac_cv_func_strtod=yes \ > > - ac_cv_func_working_mktime=yes \ > > ac_cv_have_decl_strerror_r=yes \ > > ac_cv_have_decl_strnlen=yes \ > > ac_cv_lib_getloadavg_getloadavg=no \ > > @@ -44,15 +39,12 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ > > fu_cv_sys_stat_statfs2_bsize=yes \ > > gl_cv_func_getcwd_null=yes \ > > gl_cv_func_getcwd_path_max=yes \ > > - gl_cv_func_gettimeofday_clobber=no \ > > gl_cv_func_link_follows_symlink=no \ > > gl_cv_func_re_compile_pattern_working=yes \ > > gl_cv_func_svid_putenv=yes \ > > - gl_cv_func_tzset_clobber=no \ > > gl_cv_func_working_mkstemp=yes \ > > gl_cv_func_working_utimes=yes \ > > gl_cv_macro_MB_CUR_MAX_good=yes \ > > - gl_getline_needs_run_time_check=no \ > > gl_cv_have_proc_uptime=yes \ > > utils_cv_localtime_cache=no \ > > PERL=missing \ > > -- > > 2.40.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot >
diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk index cf42a8aff8..7ee729ef48 100644 --- a/package/coreutils/coreutils.mk +++ b/package/coreutils/coreutils.mk @@ -22,18 +22,13 @@ endif COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ ac_cv_func_chown_works=yes \ - ac_cv_func_euidaccess=no \ ac_cv_func_fstatat=yes \ ac_cv_func_getdelim=yes \ ac_cv_func_getgroups=yes \ ac_cv_func_getgroups_works=yes \ ac_cv_func_getloadavg=no \ - ac_cv_func_lstat_dereferences_slashed_symlink=yes \ - ac_cv_func_lstat_empty_string_bug=no \ ac_cv_func_strerror_r_char_p=no \ ac_cv_func_strnlen_working=yes \ - ac_cv_func_strtod=yes \ - ac_cv_func_working_mktime=yes \ ac_cv_have_decl_strerror_r=yes \ ac_cv_have_decl_strnlen=yes \ ac_cv_lib_getloadavg_getloadavg=no \ @@ -44,15 +39,12 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \ fu_cv_sys_stat_statfs2_bsize=yes \ gl_cv_func_getcwd_null=yes \ gl_cv_func_getcwd_path_max=yes \ - gl_cv_func_gettimeofday_clobber=no \ gl_cv_func_link_follows_symlink=no \ gl_cv_func_re_compile_pattern_working=yes \ gl_cv_func_svid_putenv=yes \ - gl_cv_func_tzset_clobber=no \ gl_cv_func_working_mkstemp=yes \ gl_cv_func_working_utimes=yes \ gl_cv_macro_MB_CUR_MAX_good=yes \ - gl_getline_needs_run_time_check=no \ gl_cv_have_proc_uptime=yes \ utils_cv_localtime_cache=no \ PERL=missing \
- remove ac_cv_func_euidaccess=no (no longer used) - rename ac_cv_func_lstat_dereferences_slashed_symlink=yes to gl_cv_func_lstat_dereferences_slashed_symlink=yes - remove ac_cv_func_lstat_empty_string_bug=no (no longer used) - remove ac_cv_func_strtod=yes (no longer used) - remove ac_cv_func_working_mktime=yes (no longer used) - remove gl_cv_func_gettimeofday_clobber=no (no longer used) - remove gl_cv_func_tzset_clobber=no (no longer used) - remove gl_getline_needs_run_time_check=no (no longer used) Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/coreutils/coreutils.mk | 8 -------- 1 file changed, 8 deletions(-)