diff mbox series

[1/1] package/mdadm: install udev rules

Message ID 20230406105412.116596-1-simon.rowe@nutanix.com
State Accepted
Headers show
Series [1/1] package/mdadm: install udev rules | expand

Commit Message

Simon Rowe April 6, 2023, 10:54 a.m. UTC
mdadm contains various udev rules to manage RAID assembly and create
symlinks, install them if udev (or equivalent) is enabled.

Signed-off-by: Simon Rowe <simon.rowe@nutanix.com>
---
 package/mdadm/mdadm.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Arnout Vandecappelle April 9, 2023, 1:44 p.m. UTC | #1
On 06/04/2023 12:54, Simon Rowe wrote:
> mdadm contains various udev rules to manage RAID assembly and create
> symlinks, install them if udev (or equivalent) is enabled.
> 
> Signed-off-by: Simon Rowe <simon.rowe@nutanix.com>
> ---
>   package/mdadm/mdadm.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mdadm/mdadm.mk b/package/mdadm/mdadm.mk
> index 0a2eb4e5bd..a5dfb55168 100644
> --- a/package/mdadm/mdadm.mk
> +++ b/package/mdadm/mdadm.mk
> @@ -27,6 +27,7 @@ endif
>   
>   ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
>   MDADM_DEPENDENCIES += udev
> +MDADM_INSTALL_TARGET_OPTS = install-udev
>   else
>   MDADM_CXFLAGS += -DNO_LIBUDEV
>   endif
> @@ -36,7 +37,7 @@ define MDADM_BUILD_CMDS
>   endef
>   
>   define MDADM_INSTALL_TARGET_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install-bin
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install-bin $(MDADM_INSTALL_TARGET_OPTS)

  I moved the "install-bin" part to MDADM_INSTALL_TARGET_OPTS as well (and 
changed the = to += for install-udev).

  Applied to master, thanks.

  Regards,
  Arnout

>   endef
>   
>   $(eval $(generic-package))
Peter Korsgaard April 22, 2023, 7:59 p.m. UTC | #2
>>>>> "Simon" == Simon Rowe <simon.rowe@nutanix.com> writes:

 > mdadm contains various udev rules to manage RAID assembly and create
 > symlinks, install them if udev (or equivalent) is enabled.

 > Signed-off-by: Simon Rowe <simon.rowe@nutanix.com>

Committed to 2023.02.x, thanks.
diff mbox series

Patch

diff --git a/package/mdadm/mdadm.mk b/package/mdadm/mdadm.mk
index 0a2eb4e5bd..a5dfb55168 100644
--- a/package/mdadm/mdadm.mk
+++ b/package/mdadm/mdadm.mk
@@ -27,6 +27,7 @@  endif
 
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
 MDADM_DEPENDENCIES += udev
+MDADM_INSTALL_TARGET_OPTS = install-udev
 else
 MDADM_CXFLAGS += -DNO_LIBUDEV
 endif
@@ -36,7 +37,7 @@  define MDADM_BUILD_CMDS
 endef
 
 define MDADM_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install-bin
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install-bin $(MDADM_INSTALL_TARGET_OPTS)
 endef
 
 $(eval $(generic-package))