diff mbox series

[3/3] package/freeswitch: security bump version to 1.10.9

Message ID 20230205081617.113018-3-bernd.kuhls@t-online.de
State Accepted
Headers show
Series [1/3] package/libks: bump version to 1.8.2 | expand

Commit Message

Bernd Kuhls Feb. 5, 2023, 8:16 a.m. UTC
Release notes:
https://github.com/signalwire/freeswitch/releases/tag/v1.10.9

Upstream removed zrtp support:
https://github.com/signalwire/freeswitch/pull/1848

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
Upstream release notes declares:
"This is an important release containing security fixes and stability
 improvements." without mentioning any CVEs.

 package/freeswitch/freeswitch.hash |  5 ++---
 package/freeswitch/freeswitch.mk   | 11 +----------
 2 files changed, 3 insertions(+), 13 deletions(-)

Comments

Peter Korsgaard Feb. 5, 2023, 9:01 a.m. UTC | #1
On 05/02/2023 09.16, Bernd Kuhls wrote:
> Release notes:
> https://github.com/signalwire/freeswitch/releases/tag/v1.10.9
> 
> Upstream removed zrtp support:
> https://github.com/signalwire/freeswitch/pull/1848
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Fixed the checkpatch warning and applied, thanks;

package/freeswitch/freeswitch.hash:2: separation does not match 
expectation (http://nightly.buildroot.org/#adding-packages-hash
Yann E. MORIN Feb. 5, 2023, 10:15 a.m. UTC | #2
Peter, All,

On 2023-02-05 10:01 +0100, Peter Korsgaard spake thusly:
> On 05/02/2023 09.16, Bernd Kuhls wrote:
> >Release notes:
> >https://github.com/signalwire/freeswitch/releases/tag/v1.10.9
> >
> >Upstream removed zrtp support:
> >https://github.com/signalwire/freeswitch/pull/1848
> >
> >Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> 
> Fixed the checkpatch warning and applied, thanks;

You only applied this patch 3/3, but patches 1/3 and 2/3 (likbks and
sofia-sip bumps) are marked as being needed first. So I've applied them
now.

Bernd, it would have been nice that the patch bumping freeswitch would
mention that it has a dependency on newer libks and sofia-sip versions.
Indeed, if the freeswitch bump is backported to a maintenance branch,
them the two other bumps will have to be backported too, and if that is
not mentioned in the commit log, that will not be obvious to notice.

Regards,
Yann E. MORIN.

> package/freeswitch/freeswitch.hash:2: separation does not match expectation
> (http://nightly.buildroot.org/#adding-packages-hash
> 
> -- 
> Bye, Peter Korsgaard
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Feb. 5, 2023, 10:53 a.m. UTC | #3
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-02-05 10:01 +0100, Peter Korsgaard spake thusly:
 >> On 05/02/2023 09.16, Bernd Kuhls wrote:
 >> >Release notes:
 >> >https://github.com/signalwire/freeswitch/releases/tag/v1.10.9
 >> >
 >> >Upstream removed zrtp support:
 >> >https://github.com/signalwire/freeswitch/pull/1848
 >> >
 >> >Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 >> 
 >> Fixed the checkpatch warning and applied, thanks;

 > You only applied this patch 3/3, but patches 1/3 and 2/3 (likbks and
 > sofia-sip bumps) are marked as being needed first. So I've applied them
 > now.

Ups, thanks for fixing it!

 > Bernd, it would have been nice that the patch bumping freeswitch would
 > mention that it has a dependency on newer libks and sofia-sip versions.
 > Indeed, if the freeswitch bump is backported to a maintenance branch,
 > them the two other bumps will have to be backported too, and if that is
 > not mentioned in the commit log, that will not be obvious to notice.

Yes please!
diff mbox series

Patch

diff --git a/package/freeswitch/freeswitch.hash b/package/freeswitch/freeswitch.hash
index 18a36ff23c..3518d60b49 100644
--- a/package/freeswitch/freeswitch.hash
+++ b/package/freeswitch/freeswitch.hash
@@ -1,11 +1,10 @@ 
-# From https://files.freeswitch.org/freeswitch-releases/freeswitch-1.10.8.-release.tar.xz.sha256
-sha256  1176b26b2f463de2980e5be953f81ced94d23c784452bd41e086d3933a88be5f  freeswitch-1.10.8.-release.tar.xz
+# From https://files.freeswitch.org/freeswitch-releases/freeswitch-1.10.9.-release.tar.xz.sha256
+sha256  f649d53af7beccb59c1d03864cd8f2d287e4ea26ef652b5c4969d29121ced063 freeswitch-1.10.9.-release.tar.xz
 # Locally computed
 sha256  75c933202f40939cdc3827fce20a1efdaa38291e2b5a65d234eb16e2cffda66a  COPYING
 sha256  c3e3388768dae8bf4edcc4108f95be815b8a05c0b0aef6e4c3d8df81affdfa34  docs/OPENH264_BINARY_LICENSE.txt
 sha256  e8e26b16da14aa3e6ed5c22c705fdc1f45d6225fca461ea9f7314bcdfdc414c4  libs/apr/LICENSE
 sha256  8267348d5af1262c11d1a08de2f5afc77457755f1ac658627dd9acf71011d615  libs/libvpx/LICENSE
 sha256  2b2cc1180c7e6988328ad2033b04b80117419db9c4c584918bbb3cfec7e9364f  libs/libyuv/LICENSE
-sha256  7d72a8aee2c4b1a084200487992a5d86f5df6b535727a14c1874918e99d24600  libs/libzrtp/src/zrtp_legal.c
 sha256  8e19d42a1eec9561f3f347253ddf2e385c55f392f025bb0fd41b88dbf38db5ae  libs/srtp/LICENSE
 sha256  ab00a482b6a3902e40211b43c5d0441962ea99b6cc7c25c0f243fa270b78d482  src/mod/codecs/mod_isac/LICENSE
diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
index 6234dd8e97..7497cc4964 100644
--- a/package/freeswitch/freeswitch.mk
+++ b/package/freeswitch/freeswitch.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-FREESWITCH_VERSION = 1.10.8
+FREESWITCH_VERSION = 1.10.9
 FREESWITCH_SOURCE = freeswitch-$(FREESWITCH_VERSION).-release.tar.xz
 FREESWITCH_SITE = https://files.freeswitch.org/freeswitch-releases
 # External modules need headers/libs from staging
@@ -81,15 +81,6 @@  FREESWITCH_CONF_OPTS = \
 	--without-python \
 	--disable-system-xmlrpc-c
 
-# zrtp supports a limited set of archs, sparc support is also broken due
-# to a broken ld call by gcc, see libs/libzrtp/include/zrtp_config.h
-ifeq ($(BR2_i386)$(BR2_arm)$(BR2_armeb)$(BR2_aarch64)$(BR2_aarch64_be)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpc64le)$(BR2_x86_64),y)
-FREESWITCH_LICENSE_FILES += libs/libzrtp/src/zrtp_legal.c
-FREESWITCH_CONF_OPTS += --enable-zrtp
-else
-FREESWITCH_CONF_OPTS += --disable-zrtp
-endif
-
 # Enable optional modules
 FREESWITCH_ENABLED_MODULES += \
 	applications/mod_avmd \