| Message ID | 20230101233653.487175-7-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | check-package: warn about symbols not recognized by a package infra | expand |
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > While applying [1] the commit "fffbd2c9f7 i2pd: new package" > unintentionally removed completely the post-install hooks, so > I2PD_INSTALL_CONFIGURATION_FILES is declared but never called. > Fix the install of configuration files by adding the defined symbol to > the post-install hooks. > [1] http://patchwork.ozlabs.org/project/buildroot/patch/20180327212401.5173-1-fontaine.fabrice@gmail.com/ > Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Committed, thanks.
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > While applying [1] the commit "fffbd2c9f7 i2pd: new package" > unintentionally removed completely the post-install hooks, so > I2PD_INSTALL_CONFIGURATION_FILES is declared but never called. > Fix the install of configuration files by adding the defined symbol to > the post-install hooks. > [1] http://patchwork.ozlabs.org/project/buildroot/patch/20180327212401.5173-1-fontaine.fabrice@gmail.com/ > Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Committed to 2022.11.x and 2022.02.x, thanks.
diff --git a/package/i2pd/i2pd.mk b/package/i2pd/i2pd.mk index b99212be47..ad268a235c 100644 --- a/package/i2pd/i2pd.mk +++ b/package/i2pd/i2pd.mk @@ -44,6 +44,7 @@ define I2PD_INSTALL_CONFIGURATION_FILES mkdir -p $(TARGET_DIR)/var/lib/i2pd cp -a $(@D)/contrib/certificates $(TARGET_DIR)/var/lib/i2pd endef +I2PD_POST_INSTALL_TARGET_HOOKS += I2PD_INSTALL_CONFIGURATION_FILES define I2PD_USERS i2pd -1 i2pd -1 * /var/lib/i2pd - - I2P Daemon
While applying [1] the commit "fffbd2c9f7 i2pd: new package" unintentionally removed completely the post-install hooks, so I2PD_INSTALL_CONFIGURATION_FILES is declared but never called. Fix the install of configuration files by adding the defined symbol to the post-install hooks. [1] http://patchwork.ozlabs.org/project/buildroot/patch/20180327212401.5173-1-fontaine.fabrice@gmail.com/ Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- Tested using this minimal config: BR2_x86_i686=y BR2_TOOLCHAIN_EXTERNAL=y BR2_PACKAGE_I2PD=y |--- output.before/build/packages-file-list.txt.sorted |+++ output.after/build/packages-file-list.txt.sorted |@@ -15486,0 +15487,2 @@ |+i2pd,./etc/i2pd/i2pd.conf |+i2pd,./etc/i2pd/tunnels.conf |@@ -15491,0 +15494,19 @@ |+i2pd,./var/lib/i2pd/certificates/family/gostcoin.crt |+i2pd,./var/lib/i2pd/certificates/family/i2pd-dev.crt |+i2pd,./var/lib/i2pd/certificates/family/i2p-dev.crt |+i2pd,./var/lib/i2pd/certificates/family/mca2-i2p.crt |+i2pd,./var/lib/i2pd/certificates/family/stormycloud.crt |+i2pd,./var/lib/i2pd/certificates/family/volatile.crt |+i2pd,./var/lib/i2pd/certificates/reseed/acetone_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/creativecowpat_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/echelon3_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/hankhill19580_at_gmail.com.crt |+i2pd,./var/lib/i2pd/certificates/reseed/hiduser0_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/hottuna_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/i2p-reseed_at_mk16.de.crt |+i2pd,./var/lib/i2pd/certificates/reseed/igor_at_novg.net.crt |+i2pd,./var/lib/i2pd/certificates/reseed/lazygravy_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/orignal_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/r4sas-reseed_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/rambler_at_mail.i2p.crt |+i2pd,./var/lib/i2pd/certificates/reseed/reseed_at_diva.exchange.crt --- package/i2pd/i2pd.mk | 1 + 1 file changed, 1 insertion(+)