| Message ID | 20221025065539.4646-1-afshin.nasser@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | python-pycrate: new package | expand |
Hi Nasser, On Tue, Oct 25, 2022 at 8:55 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com> > --- > package/Config.in | 1 + > package/python-pycrate/Config.in | 8 ++++++++ > package/python-pycrate/python-pycrate.hash | 4 ++++ > package/python-pycrate/python-pycrate.mk | 13 +++++++++++++ An entry to the DEVELOPERS file is missing. > 4 files changed, 26 insertions(+) > create mode 100644 package/python-pycrate/Config.in > create mode 100644 package/python-pycrate/python-pycrate.hash > create mode 100644 package/python-pycrate/python-pycrate.mk > > diff --git a/package/Config.in b/package/Config.in > index 56b1a08d8b..2443b7bb27 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -951,6 +951,7 @@ menu "External python modules" > source "package/python-pyasn1-modules/Config.in" > source "package/python-pycli/Config.in" > source "package/python-pycparser/Config.in" > + source "package/python-pycrate/Config.in" > source "package/python-pycrypto/Config.in" > source "package/python-pycryptodomex/Config.in" > source "package/python-pydal/Config.in" > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > new file mode 100644 > index 0000000000..9e2123d4dd > --- /dev/null > +++ b/package/python-pycrate/Config.in > @@ -0,0 +1,8 @@ > +config BR2_PACKAGE_PYTHON_PYCRATE > + bool "python-pycrate" > + help > + It provides basically a runtime for encoding and decoding data structures, > + including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core > + network. > + > + https://github.com/P1sec/pycrate/ > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > new file mode 100644 > index 0000000000..24aa51d8e4 > --- /dev/null > +++ b/package/python-pycrate/python-pycrate.hash > @@ -0,0 +1,4 @@ > +# md5 from https://pypi.python.org/pypi/pycrate/json > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > +# Locally computed > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > new file mode 100644 > index 0000000000..41ce6c18f2 > --- /dev/null > +++ b/package/python-pycrate/python-pycrate.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# python-pycrate > +# > +################################################################################ > + > +PYTHON_PYCRATE_VERSION = 0.5.5 > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > +PYTHON_PYCRATE_SETUP_TYPE = distutils SETUP_TYPE is setuptools. Have you tried this command? ./utils/scanpypi pycrate It will do almost everything you need. The thing that is missing is licensing info because there is no license file in the source archive. Best regards, Yegor > +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later > + > +$(eval $(python-package)) > -- > 2.17.1 >
Hi Yegor, On Wed, Oct 26, 2022 at 08:21:30PM +0200, Yegor Yefremov wrote: > Hi Nasser, > > On Wed, Oct 26, 2022 at 12:23 PM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > Hi Yegor, > > > > Thankyou for taking time to review my patch. > > > > On Tue, Oct 25, 2022 at 10:33:19AM +0200, Yegor Yefremov wrote: > > > Hi Nasser, > > > > > > On Tue, Oct 25, 2022 at 8:55 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > > > > > Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com> > > > > --- > > > > package/Config.in | 1 + > > > > package/python-pycrate/Config.in | 8 ++++++++ > > > > package/python-pycrate/python-pycrate.hash | 4 ++++ > > > > package/python-pycrate/python-pycrate.mk | 13 +++++++++++++ > > > > > > An entry to the DEVELOPERS file is missing. > > > > May you help me to whome this entry should refer? > > You should add yourself as a "maintainer" of the package you add. Just > look at other entries. > I have added myself as a maintainer of this package. Thankyou. > > > > > > > > > 4 files changed, 26 insertions(+) > > > > create mode 100644 package/python-pycrate/Config.in > > > > create mode 100644 package/python-pycrate/python-pycrate.hash > > > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > > > > > diff --git a/package/Config.in b/package/Config.in > > > > index 56b1a08d8b..2443b7bb27 100644 > > > > --- a/package/Config.in > > > > +++ b/package/Config.in > > > > @@ -951,6 +951,7 @@ menu "External python modules" > > > > source "package/python-pyasn1-modules/Config.in" > > > > source "package/python-pycli/Config.in" > > > > source "package/python-pycparser/Config.in" > > > > + source "package/python-pycrate/Config.in" > > > > source "package/python-pycrypto/Config.in" > > > > source "package/python-pycryptodomex/Config.in" > > > > source "package/python-pydal/Config.in" > > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > > > new file mode 100644 > > > > index 0000000000..9e2123d4dd > > > > --- /dev/null > > > > +++ b/package/python-pycrate/Config.in > > > > @@ -0,0 +1,8 @@ > > > > +config BR2_PACKAGE_PYTHON_PYCRATE > > > > + bool "python-pycrate" > > > > + help > > > > + It provides basically a runtime for encoding and decoding data structures, > > > > + including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core > > > > + network. > > > > + > > > > + https://github.com/P1sec/pycrate/ > > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > > new file mode 100644 > > > > index 0000000000..24aa51d8e4 > > > > --- /dev/null > > > > +++ b/package/python-pycrate/python-pycrate.hash > > > > @@ -0,0 +1,4 @@ > > > > +# md5 from https://pypi.python.org/pypi/pycrate/json > > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > > +# Locally computed > > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > > new file mode 100644 > > > > index 0000000000..41ce6c18f2 > > > > --- /dev/null > > > > +++ b/package/python-pycrate/python-pycrate.mk > > > > @@ -0,0 +1,13 @@ > > > > +################################################################################ > > > > +# > > > > +# python-pycrate > > > > +# > > > > +################################################################################ > > > > + > > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > > +PYTHON_PYCRATE_SETUP_TYPE = distutils > > > > > > SETUP_TYPE is setuptools. > > > > > > Have you tried this command? > > > > > > ./utils/scanpypi pycrate > > > > > > It will do almost everything you need. The thing that is missing is > > > licensing info because there is no license file in the source archive. > > > > Thankyou for pointing this out. Now I send a new version, using this > > command and also adding licensing info. > > > > > > Best regards, > > > Yegor > > > > > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later > > > > + > > > > +$(eval $(python-package)) > > > > -- > > > > 2.17.1 > > > > > > > > This is the second version of my patch. > > > > From 979beabd86f1c15d159e37136bc9591fb39b844e Mon Sep 17 00:00:00 2001 > > From: Nasser Afshin <Afshin.Nasser@gmail.com> > > Date: Tue, 25 Oct 2022 16:06:53 +0330 > > Subject: [PATCH v2] python-pycrate: new package > > > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> > > --- > > v1 -> v2: Added licence file and its checksum > > Used ./utils/scanpypi pycrate tool to be consistent with > > others > > > > package/Config.in | 1 + > > package/python-pycrate/Config.in | 6 ++++++ > > package/python-pycrate/python-pycrate.hash | 6 ++++++ > > package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ > > 4 files changed, 27 insertions(+) > > create mode 100644 package/python-pycrate/Config.in > > create mode 100644 package/python-pycrate/python-pycrate.hash > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > diff --git a/package/Config.in b/package/Config.in > > index e3a34d6e97..a6fcc72cc8 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -1168,6 +1168,7 @@ menu "External python modules" > > source "package/python-pycairo/Config.in" > > source "package/python-pycares/Config.in" > > source "package/python-pycparser/Config.in" > > + source "package/python-pycrate/Config.in" > > source "package/python-pycryptodomex/Config.in" > > source "package/python-pycups/Config.in" > > source "package/python-pydal/Config.in" > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > new file mode 100644 > > index 0000000000..193a973f7e > > --- /dev/null > > +++ b/package/python-pycrate/Config.in > > @@ -0,0 +1,6 @@ > > +config BR2_PACKAGE_PYTHON_PYCRATE > > + bool "python-pycrate" > > + help > > + A software suite to handle various data formats. > > + > > + https://github.com/P1sec/pycrate/ > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > new file mode 100644 > > index 0000000000..8ad33370b4 > > --- /dev/null > > +++ b/package/python-pycrate/python-pycrate.hash > > @@ -0,0 +1,6 @@ > > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > +# Locally computed > > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt > > + > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > new file mode 100644 > > index 0000000000..c0da152656 > > --- /dev/null > > +++ b/package/python-pycrate/python-pycrate.mk > > @@ -0,0 +1,14 @@ > > +################################################################################ > > +# > > +# python-pycrate > > +# > > +################################################################################ > > + > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ > > + > > +$(eval $(python-package)) > > The patch looks good now. Thanks. > > Best regards, > Yegor This is the third version of the patch: From de6e28885836a6d9a5347a083a68055098508583 Mon Sep 17 00:00:00 2001 From: Nasser Afshin <Afshin.Nasser@gmail.com> Date: Tue, 25 Oct 2022 16:06:53 +0330 Subject: [PATCH v3] python-pycrate: new package Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> --- v1 -> v2: Added licence file and its checksum Used ./utils/scanpypi pycrate tool to be consistent with others v2 -> v3: Added myself as the maintainer of this package DEVELOPERS | 3 +++ package/Config.in | 1 + package/python-pycrate/Config.in | 6 ++++++ package/python-pycrate/python-pycrate.hash | 6 ++++++ package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ 5 files changed, 30 insertions(+) create mode 100644 package/python-pycrate/Config.in create mode 100644 package/python-pycrate/python-pycrate.hash create mode 100644 package/python-pycrate/python-pycrate.mk diff --git a/DEVELOPERS b/DEVELOPERS index 6e0b765ba1..a1b48fd45c 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2157,6 +2157,9 @@ N: Murat Demirten <mdemirten@yh.com.tr> F: package/jpeg-turbo/ F: package/libgeotiff/ +N: Nasser Afshin <afshin.nasser@gmail.com> +F: package/python-pycrate/ + N: Nathaniel Roach <nroach44@gmail.com> F: package/bandwidthd/ F: package/libgudev/ diff --git a/package/Config.in b/package/Config.in index e3a34d6e97..a6fcc72cc8 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1168,6 +1168,7 @@ menu "External python modules" source "package/python-pycairo/Config.in" source "package/python-pycares/Config.in" source "package/python-pycparser/Config.in" + source "package/python-pycrate/Config.in" source "package/python-pycryptodomex/Config.in" source "package/python-pycups/Config.in" source "package/python-pydal/Config.in" diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in new file mode 100644 index 0000000000..193a973f7e --- /dev/null +++ b/package/python-pycrate/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_PYCRATE + bool "python-pycrate" + help + A software suite to handle various data formats. + + https://github.com/P1sec/pycrate/ diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash new file mode 100644 index 0000000000..8ad33370b4 --- /dev/null +++ b/package/python-pycrate/python-pycrate.hash @@ -0,0 +1,6 @@ +# md5, sha256 from https://pypi.org/pypi/pycrate/json +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz +# Locally computed +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt + diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk new file mode 100644 index 0000000000..c0da152656 --- /dev/null +++ b/package/python-pycrate/python-pycrate.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# python-pycrate +# +################################################################################ + +PYTHON_PYCRATE_VERSION = 0.5.5 +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df +PYTHON_PYCRATE_SETUP_TYPE = setuptools +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ + +$(eval $(python-package))
Hi Nasser, On Sat, Oct 29, 2022 at 10:02 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > Hi Yegor, > > On Wed, Oct 26, 2022 at 08:21:30PM +0200, Yegor Yefremov wrote: > > Hi Nasser, > > > > On Wed, Oct 26, 2022 at 12:23 PM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > > > Hi Yegor, > > > > > > Thankyou for taking time to review my patch. > > > > > > On Tue, Oct 25, 2022 at 10:33:19AM +0200, Yegor Yefremov wrote: > > > > Hi Nasser, > > > > > > > > On Tue, Oct 25, 2022 at 8:55 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > > > > > > > Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com> Best regards, Yegor > > > > > --- > > > > > package/Config.in | 1 + > > > > > package/python-pycrate/Config.in | 8 ++++++++ > > > > > package/python-pycrate/python-pycrate.hash | 4 ++++ > > > > > package/python-pycrate/python-pycrate.mk | 13 +++++++++++++ > > > > > > > > An entry to the DEVELOPERS file is missing. > > > > > > May you help me to whome this entry should refer? > > > > You should add yourself as a "maintainer" of the package you add. Just > > look at other entries. > > > I have added myself as a maintainer of this package. Thankyou. > > > > > > > > > > > > > 4 files changed, 26 insertions(+) > > > > > create mode 100644 package/python-pycrate/Config.in > > > > > create mode 100644 package/python-pycrate/python-pycrate.hash > > > > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > > > > > > > diff --git a/package/Config.in b/package/Config.in > > > > > index 56b1a08d8b..2443b7bb27 100644 > > > > > --- a/package/Config.in > > > > > +++ b/package/Config.in > > > > > @@ -951,6 +951,7 @@ menu "External python modules" > > > > > source "package/python-pyasn1-modules/Config.in" > > > > > source "package/python-pycli/Config.in" > > > > > source "package/python-pycparser/Config.in" > > > > > + source "package/python-pycrate/Config.in" > > > > > source "package/python-pycrypto/Config.in" > > > > > source "package/python-pycryptodomex/Config.in" > > > > > source "package/python-pydal/Config.in" > > > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > > > > new file mode 100644 > > > > > index 0000000000..9e2123d4dd > > > > > --- /dev/null > > > > > +++ b/package/python-pycrate/Config.in > > > > > @@ -0,0 +1,8 @@ > > > > > +config BR2_PACKAGE_PYTHON_PYCRATE > > > > > + bool "python-pycrate" > > > > > + help > > > > > + It provides basically a runtime for encoding and decoding data structures, > > > > > + including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core > > > > > + network. > > > > > + > > > > > + https://github.com/P1sec/pycrate/ > > > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > > > new file mode 100644 > > > > > index 0000000000..24aa51d8e4 > > > > > --- /dev/null > > > > > +++ b/package/python-pycrate/python-pycrate.hash > > > > > @@ -0,0 +1,4 @@ > > > > > +# md5 from https://pypi.python.org/pypi/pycrate/json > > > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > > > +# Locally computed > > > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > > > new file mode 100644 > > > > > index 0000000000..41ce6c18f2 > > > > > --- /dev/null > > > > > +++ b/package/python-pycrate/python-pycrate.mk > > > > > @@ -0,0 +1,13 @@ > > > > > +################################################################################ > > > > > +# > > > > > +# python-pycrate > > > > > +# > > > > > +################################################################################ > > > > > + > > > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > > > +PYTHON_PYCRATE_SETUP_TYPE = distutils > > > > > > > > SETUP_TYPE is setuptools. > > > > > > > > Have you tried this command? > > > > > > > > ./utils/scanpypi pycrate > > > > > > > > It will do almost everything you need. The thing that is missing is > > > > licensing info because there is no license file in the source archive. > > > > > > Thankyou for pointing this out. Now I send a new version, using this > > > command and also adding licensing info. > > > > > > > > Best regards, > > > > Yegor > > > > > > > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later > > > > > + > > > > > +$(eval $(python-package)) > > > > > -- > > > > > 2.17.1 > > > > > > > > > > > This is the second version of my patch. > > > > > > From 979beabd86f1c15d159e37136bc9591fb39b844e Mon Sep 17 00:00:00 2001 > > > From: Nasser Afshin <Afshin.Nasser@gmail.com> > > > Date: Tue, 25 Oct 2022 16:06:53 +0330 > > > Subject: [PATCH v2] python-pycrate: new package > > > > > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> > > > --- > > > v1 -> v2: Added licence file and its checksum > > > Used ./utils/scanpypi pycrate tool to be consistent with > > > others > > > > > > package/Config.in | 1 + > > > package/python-pycrate/Config.in | 6 ++++++ > > > package/python-pycrate/python-pycrate.hash | 6 ++++++ > > > package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ > > > 4 files changed, 27 insertions(+) > > > create mode 100644 package/python-pycrate/Config.in > > > create mode 100644 package/python-pycrate/python-pycrate.hash > > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > > > diff --git a/package/Config.in b/package/Config.in > > > index e3a34d6e97..a6fcc72cc8 100644 > > > --- a/package/Config.in > > > +++ b/package/Config.in > > > @@ -1168,6 +1168,7 @@ menu "External python modules" > > > source "package/python-pycairo/Config.in" > > > source "package/python-pycares/Config.in" > > > source "package/python-pycparser/Config.in" > > > + source "package/python-pycrate/Config.in" > > > source "package/python-pycryptodomex/Config.in" > > > source "package/python-pycups/Config.in" > > > source "package/python-pydal/Config.in" > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > > new file mode 100644 > > > index 0000000000..193a973f7e > > > --- /dev/null > > > +++ b/package/python-pycrate/Config.in > > > @@ -0,0 +1,6 @@ > > > +config BR2_PACKAGE_PYTHON_PYCRATE > > > + bool "python-pycrate" > > > + help > > > + A software suite to handle various data formats. > > > + > > > + https://github.com/P1sec/pycrate/ > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > new file mode 100644 > > > index 0000000000..8ad33370b4 > > > --- /dev/null > > > +++ b/package/python-pycrate/python-pycrate.hash > > > @@ -0,0 +1,6 @@ > > > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > +# Locally computed > > > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt > > > + > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > new file mode 100644 > > > index 0000000000..c0da152656 > > > --- /dev/null > > > +++ b/package/python-pycrate/python-pycrate.mk > > > @@ -0,0 +1,14 @@ > > > +################################################################################ > > > +# > > > +# python-pycrate > > > +# > > > +################################################################################ > > > + > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > > > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ > > > + > > > +$(eval $(python-package)) > > > > The patch looks good now. Thanks. > > > > Best regards, > > Yegor > > This is the third version of the patch: > > From de6e28885836a6d9a5347a083a68055098508583 Mon Sep 17 00:00:00 2001 > From: Nasser Afshin <Afshin.Nasser@gmail.com> > Date: Tue, 25 Oct 2022 16:06:53 +0330 > Subject: [PATCH v3] python-pycrate: new package > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> > --- > v1 -> v2: Added licence file and its checksum > Used ./utils/scanpypi pycrate tool to be consistent with > others > v2 -> v3: Added myself as the maintainer of this package > > DEVELOPERS | 3 +++ > package/Config.in | 1 + > package/python-pycrate/Config.in | 6 ++++++ > package/python-pycrate/python-pycrate.hash | 6 ++++++ > package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ > 5 files changed, 30 insertions(+) > create mode 100644 package/python-pycrate/Config.in > create mode 100644 package/python-pycrate/python-pycrate.hash > create mode 100644 package/python-pycrate/python-pycrate.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index 6e0b765ba1..a1b48fd45c 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -2157,6 +2157,9 @@ N: Murat Demirten <mdemirten@yh.com.tr> > F: package/jpeg-turbo/ > F: package/libgeotiff/ > > +N: Nasser Afshin <afshin.nasser@gmail.com> > +F: package/python-pycrate/ > + > N: Nathaniel Roach <nroach44@gmail.com> > F: package/bandwidthd/ > F: package/libgudev/ > diff --git a/package/Config.in b/package/Config.in > index e3a34d6e97..a6fcc72cc8 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1168,6 +1168,7 @@ menu "External python modules" > source "package/python-pycairo/Config.in" > source "package/python-pycares/Config.in" > source "package/python-pycparser/Config.in" > + source "package/python-pycrate/Config.in" > source "package/python-pycryptodomex/Config.in" > source "package/python-pycups/Config.in" > source "package/python-pydal/Config.in" > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > new file mode 100644 > index 0000000000..193a973f7e > --- /dev/null > +++ b/package/python-pycrate/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_PYTHON_PYCRATE > + bool "python-pycrate" > + help > + A software suite to handle various data formats. > + > + https://github.com/P1sec/pycrate/ > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > new file mode 100644 > index 0000000000..8ad33370b4 > --- /dev/null > +++ b/package/python-pycrate/python-pycrate.hash > @@ -0,0 +1,6 @@ > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > +# Locally computed > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt > + > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > new file mode 100644 > index 0000000000..c0da152656 > --- /dev/null > +++ b/package/python-pycrate/python-pycrate.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# python-pycrate > +# > +################################################################################ > + > +PYTHON_PYCRATE_VERSION = 0.5.5 > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ > + > +$(eval $(python-package)) > -- > 2.17.1 >
Hi, I'm resending the patch again. Ping! On Sun, Oct 30, 2022 at 10:11:56AM +0100, Yegor Yefremov wrote: > Hi Nasser, > > On Sat, Oct 29, 2022 at 10:02 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > Hi Yegor, > > > > On Wed, Oct 26, 2022 at 08:21:30PM +0200, Yegor Yefremov wrote: > > > Hi Nasser, > > > > > > On Wed, Oct 26, 2022 at 12:23 PM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > > > > > Hi Yegor, > > > > > > > > Thankyou for taking time to review my patch. > > > > > > > > On Tue, Oct 25, 2022 at 10:33:19AM +0200, Yegor Yefremov wrote: > > > > > Hi Nasser, > > > > > > > > > > On Tue, Oct 25, 2022 at 8:55 AM Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > > > > > > > > > > Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com> > > Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com> > > Best regards, > Yegor > > > > > > > --- > > > > > > package/Config.in | 1 + > > > > > > package/python-pycrate/Config.in | 8 ++++++++ > > > > > > package/python-pycrate/python-pycrate.hash | 4 ++++ > > > > > > package/python-pycrate/python-pycrate.mk | 13 +++++++++++++ > > > > > > > > > > An entry to the DEVELOPERS file is missing. > > > > > > > > May you help me to whome this entry should refer? > > > > > > You should add yourself as a "maintainer" of the package you add. Just > > > look at other entries. > > > > > I have added myself as a maintainer of this package. Thankyou. > > > > > > > > > > > > > > > > > 4 files changed, 26 insertions(+) > > > > > > create mode 100644 package/python-pycrate/Config.in > > > > > > create mode 100644 package/python-pycrate/python-pycrate.hash > > > > > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > > > > > > > > > diff --git a/package/Config.in b/package/Config.in > > > > > > index 56b1a08d8b..2443b7bb27 100644 > > > > > > --- a/package/Config.in > > > > > > +++ b/package/Config.in > > > > > > @@ -951,6 +951,7 @@ menu "External python modules" > > > > > > source "package/python-pyasn1-modules/Config.in" > > > > > > source "package/python-pycli/Config.in" > > > > > > source "package/python-pycparser/Config.in" > > > > > > + source "package/python-pycrate/Config.in" > > > > > > source "package/python-pycrypto/Config.in" > > > > > > source "package/python-pycryptodomex/Config.in" > > > > > > source "package/python-pydal/Config.in" > > > > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > > > > > new file mode 100644 > > > > > > index 0000000000..9e2123d4dd > > > > > > --- /dev/null > > > > > > +++ b/package/python-pycrate/Config.in > > > > > > @@ -0,0 +1,8 @@ > > > > > > +config BR2_PACKAGE_PYTHON_PYCRATE > > > > > > + bool "python-pycrate" > > > > > > + help > > > > > > + It provides basically a runtime for encoding and decoding data structures, > > > > > > + including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core > > > > > > + network. > > > > > > + > > > > > > + https://github.com/P1sec/pycrate/ > > > > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > > > > new file mode 100644 > > > > > > index 0000000000..24aa51d8e4 > > > > > > --- /dev/null > > > > > > +++ b/package/python-pycrate/python-pycrate.hash > > > > > > @@ -0,0 +1,4 @@ > > > > > > +# md5 from https://pypi.python.org/pypi/pycrate/json > > > > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > > > > +# Locally computed > > > > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > > > > new file mode 100644 > > > > > > index 0000000000..41ce6c18f2 > > > > > > --- /dev/null > > > > > > +++ b/package/python-pycrate/python-pycrate.mk > > > > > > @@ -0,0 +1,13 @@ > > > > > > +################################################################################ > > > > > > +# > > > > > > +# python-pycrate > > > > > > +# > > > > > > +################################################################################ > > > > > > + > > > > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > > > > +PYTHON_PYCRATE_SETUP_TYPE = distutils > > > > > > > > > > SETUP_TYPE is setuptools. > > > > > > > > > > Have you tried this command? > > > > > > > > > > ./utils/scanpypi pycrate > > > > > > > > > > It will do almost everything you need. The thing that is missing is > > > > > licensing info because there is no license file in the source archive. > > > > > > > > Thankyou for pointing this out. Now I send a new version, using this > > > > command and also adding licensing info. > > > > > > > > > > Best regards, > > > > > Yegor > > > > > > > > > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later > > > > > > + > > > > > > +$(eval $(python-package)) > > > > > > -- > > > > > > 2.17.1 > > > > > > > > > > > > > > This is the second version of my patch. > > > > > > > > From 979beabd86f1c15d159e37136bc9591fb39b844e Mon Sep 17 00:00:00 2001 > > > > From: Nasser Afshin <Afshin.Nasser@gmail.com> > > > > Date: Tue, 25 Oct 2022 16:06:53 +0330 > > > > Subject: [PATCH v2] python-pycrate: new package > > > > > > > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> > > > > --- > > > > v1 -> v2: Added licence file and its checksum > > > > Used ./utils/scanpypi pycrate tool to be consistent with > > > > others > > > > > > > > package/Config.in | 1 + > > > > package/python-pycrate/Config.in | 6 ++++++ > > > > package/python-pycrate/python-pycrate.hash | 6 ++++++ > > > > package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ > > > > 4 files changed, 27 insertions(+) > > > > create mode 100644 package/python-pycrate/Config.in > > > > create mode 100644 package/python-pycrate/python-pycrate.hash > > > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > > > > > diff --git a/package/Config.in b/package/Config.in > > > > index e3a34d6e97..a6fcc72cc8 100644 > > > > --- a/package/Config.in > > > > +++ b/package/Config.in > > > > @@ -1168,6 +1168,7 @@ menu "External python modules" > > > > source "package/python-pycairo/Config.in" > > > > source "package/python-pycares/Config.in" > > > > source "package/python-pycparser/Config.in" > > > > + source "package/python-pycrate/Config.in" > > > > source "package/python-pycryptodomex/Config.in" > > > > source "package/python-pycups/Config.in" > > > > source "package/python-pydal/Config.in" > > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > > > new file mode 100644 > > > > index 0000000000..193a973f7e > > > > --- /dev/null > > > > +++ b/package/python-pycrate/Config.in > > > > @@ -0,0 +1,6 @@ > > > > +config BR2_PACKAGE_PYTHON_PYCRATE > > > > + bool "python-pycrate" > > > > + help > > > > + A software suite to handle various data formats. > > > > + > > > > + https://github.com/P1sec/pycrate/ > > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > > new file mode 100644 > > > > index 0000000000..8ad33370b4 > > > > --- /dev/null > > > > +++ b/package/python-pycrate/python-pycrate.hash > > > > @@ -0,0 +1,6 @@ > > > > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > > +# Locally computed > > > > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt > > > > + > > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > > new file mode 100644 > > > > index 0000000000..c0da152656 > > > > --- /dev/null > > > > +++ b/package/python-pycrate/python-pycrate.mk > > > > @@ -0,0 +1,14 @@ > > > > +################################################################################ > > > > +# > > > > +# python-pycrate > > > > +# > > > > +################################################################################ > > > > + > > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > > > > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt > > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ > > > > + > > > > +$(eval $(python-package)) > > > > > > The patch looks good now. Thanks. > > > > > > Best regards, > > > Yegor > > > > This is the third version of the patch: > > > > From de6e28885836a6d9a5347a083a68055098508583 Mon Sep 17 00:00:00 2001 > > From: Nasser Afshin <Afshin.Nasser@gmail.com> > > Date: Tue, 25 Oct 2022 16:06:53 +0330 > > Subject: [PATCH v3] python-pycrate: new package > > > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> > > --- > > v1 -> v2: Added licence file and its checksum > > Used ./utils/scanpypi pycrate tool to be consistent with > > others > > v2 -> v3: Added myself as the maintainer of this package > > > > DEVELOPERS | 3 +++ > > package/Config.in | 1 + > > package/python-pycrate/Config.in | 6 ++++++ > > package/python-pycrate/python-pycrate.hash | 6 ++++++ > > package/python-pycrate/python-pycrate.mk | 14 ++++++++++++++ > > 5 files changed, 30 insertions(+) > > create mode 100644 package/python-pycrate/Config.in > > create mode 100644 package/python-pycrate/python-pycrate.hash > > create mode 100644 package/python-pycrate/python-pycrate.mk > > > > diff --git a/DEVELOPERS b/DEVELOPERS > > index 6e0b765ba1..a1b48fd45c 100644 > > --- a/DEVELOPERS > > +++ b/DEVELOPERS > > @@ -2157,6 +2157,9 @@ N: Murat Demirten <mdemirten@yh.com.tr> > > F: package/jpeg-turbo/ > > F: package/libgeotiff/ > > > > +N: Nasser Afshin <afshin.nasser@gmail.com> > > +F: package/python-pycrate/ > > + > > N: Nathaniel Roach <nroach44@gmail.com> > > F: package/bandwidthd/ > > F: package/libgudev/ > > diff --git a/package/Config.in b/package/Config.in > > index e3a34d6e97..a6fcc72cc8 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -1168,6 +1168,7 @@ menu "External python modules" > > source "package/python-pycairo/Config.in" > > source "package/python-pycares/Config.in" > > source "package/python-pycparser/Config.in" > > + source "package/python-pycrate/Config.in" > > source "package/python-pycryptodomex/Config.in" > > source "package/python-pycups/Config.in" > > source "package/python-pydal/Config.in" > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in > > new file mode 100644 > > index 0000000000..193a973f7e > > --- /dev/null > > +++ b/package/python-pycrate/Config.in > > @@ -0,0 +1,6 @@ > > +config BR2_PACKAGE_PYTHON_PYCRATE > > + bool "python-pycrate" > > + help > > + A software suite to handle various data formats. > > + > > + https://github.com/P1sec/pycrate/ > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > new file mode 100644 > > index 0000000000..8ad33370b4 > > --- /dev/null > > +++ b/package/python-pycrate/python-pycrate.hash > > @@ -0,0 +1,6 @@ > > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > +# Locally computed > > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt > > + > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > new file mode 100644 > > index 0000000000..c0da152656 > > --- /dev/null > > +++ b/package/python-pycrate/python-pycrate.mk > > @@ -0,0 +1,14 @@ > > +################################################################################ > > +# > > +# python-pycrate > > +# > > +################################################################################ > > + > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+ > > + > > +$(eval $(python-package)) > > -- > > 2.17.1 > > Best regards, Nasser Afshin
Hello, On Tue, 8 Nov 2022 12:15:51 +0330 Nasser Afshin <afshin.nasser@gmail.com> wrote: > > > From de6e28885836a6d9a5347a083a68055098508583 Mon Sep 17 00:00:00 2001 > > > From: Nasser Afshin <Afshin.Nasser@gmail.com> > > > Date: Tue, 25 Oct 2022 16:06:53 +0330 > > > Subject: [PATCH v3] python-pycrate: new package > > > > > > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com> Thanks for your contribution. However what you did here when resending a new iteration really wasn't convenient to apply the patch. Next time could you use "git send-email" to send the new iteration as a new-email. Some more comments below. > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash > > > new file mode 100644 > > > index 0000000000..8ad33370b4 > > > --- /dev/null > > > +++ b/package/python-pycrate/python-pycrate.hash > > > @@ -0,0 +1,6 @@ > > > +# md5, sha256 from https://pypi.org/pypi/pycrate/json > > > +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz > > > +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz > > > +# Locally computed > > > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 license.txt This did not match the expected formatting. "make check-package" complains about formatting issues in the hash file. > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk > > > new file mode 100644 > > > index 0000000000..c0da152656 > > > --- /dev/null > > > +++ b/package/python-pycrate/python-pycrate.mk > > > @@ -0,0 +1,14 @@ > > > +################################################################################ > > > +# > > > +# python-pycrate > > > +# > > > +################################################################################ > > > + > > > +PYTHON_PYCRATE_VERSION = 0.5.5 > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df > > > +PYTHON_PYCRATE_SETUP_TYPE = setuptools > > > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt This was not good for three reasons: (1) The license.txt was not listed in PYTHON_PYCRATE_LICENSE_FILES so it was not taken into account (2) The URL from which you download the file does not point to a stable file: it's the file from the master branch, so it can change at any time, breaking the hash check, but also potentially being inconsistent with the license of version 0.5.5 that the package is using (3) The license.txt was not copied into the source directory of the package, making it unaccessible to the legal-info machinery. With these issues fixed, the .mk file looks like this: PYTHON_PYCRATE_VERSION = 0.5.5 PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df PYTHON_PYCRATE_SETUP_TYPE = setuptools PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/$(PYTHON_PYCRATE_VERSION)/license.txt PYTHON_PYCRATE_LICENSE = LGPL-2.1+ PYTHON_PYCRATE_LICENSE_FILES = license.txt define PYTHON_PYCRATE_ADD_LICENSE_FILE cp $(PYTHON_PYCRATE_DL_DIR)/license.txt $(@D) endef PYTHON_PYCRATE_POST_EXTRACT_HOOKS += PYTHON_PYCRATE_ADD_LICENSE_FILE $(eval $(python-package)) I've applied after fixing the different issues. However, one thing that would be really good to add is a runtime test in support/testing/ to make sure that the package is at least minimally working at runtime. You can take a look at all the support/testing/tests/package/test_python* files for examples. Thanks a lot! Thomas
diff --git a/package/Config.in b/package/Config.in index 56b1a08d8b..2443b7bb27 100644 --- a/package/Config.in +++ b/package/Config.in @@ -951,6 +951,7 @@ menu "External python modules" source "package/python-pyasn1-modules/Config.in" source "package/python-pycli/Config.in" source "package/python-pycparser/Config.in" + source "package/python-pycrate/Config.in" source "package/python-pycrypto/Config.in" source "package/python-pycryptodomex/Config.in" source "package/python-pydal/Config.in" diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in new file mode 100644 index 0000000000..9e2123d4dd --- /dev/null +++ b/package/python-pycrate/Config.in @@ -0,0 +1,8 @@ +config BR2_PACKAGE_PYTHON_PYCRATE + bool "python-pycrate" + help + It provides basically a runtime for encoding and decoding data structures, + including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core + network. + + https://github.com/P1sec/pycrate/ diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash new file mode 100644 index 0000000000..24aa51d8e4 --- /dev/null +++ b/package/python-pycrate/python-pycrate.hash @@ -0,0 +1,4 @@ +# md5 from https://pypi.python.org/pypi/pycrate/json +md5 075622d5d573274cd4dbfe268ca52f7f pycrate-0.5.5.tar.gz +# Locally computed +sha256 59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af pycrate-0.5.5.tar.gz diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk new file mode 100644 index 0000000000..41ce6c18f2 --- /dev/null +++ b/package/python-pycrate/python-pycrate.mk @@ -0,0 +1,13 @@ +################################################################################ +# +# python-pycrate +# +################################################################################ + +PYTHON_PYCRATE_VERSION = 0.5.5 +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df +PYTHON_PYCRATE_SETUP_TYPE = distutils +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later + +$(eval $(python-package))
Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com> --- package/Config.in | 1 + package/python-pycrate/Config.in | 8 ++++++++ package/python-pycrate/python-pycrate.hash | 4 ++++ package/python-pycrate/python-pycrate.mk | 13 +++++++++++++ 4 files changed, 26 insertions(+) create mode 100644 package/python-pycrate/Config.in create mode 100644 package/python-pycrate/python-pycrate.hash create mode 100644 package/python-pycrate/python-pycrate.mk