diff mbox series

[v2] package/python-minimalmodbus: new package

Message ID 20221019090309.1410432-1-angelo@amarulasolutions.com
State Superseded
Headers show
Series [v2] package/python-minimalmodbus: new package | expand

Commit Message

Angelo Compagnucci Oct. 19, 2022, 9:03 a.m. UTC 
Easy-to-use Modbus RTU and Modbus ASCII implementation for Python.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
V2:
* Adding me to DEVELOPERS

 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/python-minimalmodbus/Config.in             |  7 +++++++
 .../python-minimalmodbus/python-minimalmodbus.hash |  4 ++++
 .../python-minimalmodbus/python-minimalmodbus.mk   | 14 ++++++++++++++
 5 files changed, 27 insertions(+)
 create mode 100644 package/python-minimalmodbus/Config.in
 create mode 100644 package/python-minimalmodbus/python-minimalmodbus.hash
 create mode 100644 package/python-minimalmodbus/python-minimalmodbus.mk

Comments

Marcus Hoffmann Oct. 19, 2022, 12:56 p.m. UTC | #1 
Thanks,

I've been meaning to submit this as well but didn't get around to it yet.

On 19.10.22 11:03, Angelo Compagnucci wrote:
> Easy-to-use Modbus RTU and Modbus ASCII implementation for Python.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>

One somewhat general question below, but otherwise this looks all good.

Reviewed-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>

> ---
> V2:
> * Adding me to DEVELOPERS
> 
>   DEVELOPERS                                         |  1 +
>   package/Config.in                                  |  1 +
>   package/python-minimalmodbus/Config.in             |  7 +++++++
>   .../python-minimalmodbus/python-minimalmodbus.hash |  4 ++++
>   .../python-minimalmodbus/python-minimalmodbus.mk   | 14 ++++++++++++++
>   5 files changed, 27 insertions(+)
>   create mode 100644 package/python-minimalmodbus/Config.in
>   create mode 100644 package/python-minimalmodbus/python-minimalmodbus.hash
>   create mode 100644 package/python-minimalmodbus/python-minimalmodbus.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index c0e6f8bbef..9eb5400999 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -173,6 +173,7 @@ F:	package/mono-gtksharp3/
>   F:	package/monolite/
>   F:	package/openjpeg/
>   F:	package/python-can/
> +F:	package/python-minimalmodbus/
>   F:	package/python-pillow/
>   F:	package/python-pydal/
>   F:	package/python-spidev/
> diff --git a/package/Config.in b/package/Config.in
> index e3a34d6e97..08574931f8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1112,6 +1112,7 @@ menu "External python modules"
>   	source "package/python-mbstrdecoder/Config.in"
>   	source "package/python-memory-profiler/Config.in"
>   	source "package/python-mimeparse/Config.in"
> +	source "package/python-minimalmodbus/Config.in"
>   	source "package/python-mistune/Config.in"
>   	source "package/python-modbus-tk/Config.in"
>   	source "package/python-more-itertools/Config.in"
> diff --git a/package/python-minimalmodbus/Config.in b/package/python-minimalmodbus/Config.in
> new file mode 100644
> index 0000000000..fd0f33e0d4
> --- /dev/null
> +++ b/package/python-minimalmodbus/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_MINIMALMODBUS
> +	bool "python-minimalmodbus"
> +	select BR2_PACKAGE_PYTHON_SERIAL # runtime
> +	help
> +	  Easy-to-use Modbus RTU and Modbus ASCII implementation.
> +
> +	  https://minimalmodbus.readthedocs.io/
> diff --git a/package/python-minimalmodbus/python-minimalmodbus.hash b/package/python-minimalmodbus/python-minimalmodbus.hash
> new file mode 100644
> index 0000000000..56af3d426b
> --- /dev/null
> +++ b/package/python-minimalmodbus/python-minimalmodbus.hash
> @@ -0,0 +1,4 @@
> +# sha256 locally computed
> +sha256  aa7e3989074d4efba0013c3c50263aec01afae368bd5bd234008b50aea1b7ab4  minimalmodbus-2.0.1.tar.gz
> +# Hash for license file
> +sha256  abe787d472ae2069e935c84eb13fd770518dfb08b92d5f190f3cd7ff6d1f6f32  LICENSE
> diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> new file mode 100644
> index 0000000000..e4e93b4c31
> --- /dev/null
> +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-minimalmodbus
> +#
> +################################################################################
> +
> +PYTHON_MINIMALMODBUS_VERSION = 2.0.1
> +PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> +PYTHON_MINIMALMODBUS_SITE = $(call github,pyhys,minimalmodbus,$(PYTHON_MINIMALMODBUS_VERSION))

I used ./utils/scanpypi and thus have https://files.pythonhosted.org as 
a site. Does buildroot have any preference for which upstream version of 
python packages to prefer if both work?

> +PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> +PYTHON_MINIMALMODBUS_LICENSE = Apache License 2.0
> +PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> + > +$(eval $(python-package))

Best,
Marcus
Angelo Compagnucci Oct. 19, 2022, 1:27 p.m. UTC | #2 
On Wed, Oct 19, 2022 at 2:56 PM Marcus Hoffmann <marcus.hoffmann@othermo.de>
wrote:

> Thanks,
>
> I've been meaning to submit this as well but didn't get around to it yet.
>
> On 19.10.22 11:03, Angelo Compagnucci wrote:
> > Easy-to-use Modbus RTU and Modbus ASCII implementation for Python.
> >
> > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>
> One somewhat general question below, but otherwise this looks all good.
>
> Reviewed-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
>
> > ---
> > V2:
> > * Adding me to DEVELOPERS
> >
> >   DEVELOPERS                                         |  1 +
> >   package/Config.in                                  |  1 +
> >   package/python-minimalmodbus/Config.in             |  7 +++++++
> >   .../python-minimalmodbus/python-minimalmodbus.hash |  4 ++++
> >   .../python-minimalmodbus/python-minimalmodbus.mk   | 14 ++++++++++++++
> >   5 files changed, 27 insertions(+)
> >   create mode 100644 package/python-minimalmodbus/Config.in
> >   create mode 100644
> package/python-minimalmodbus/python-minimalmodbus.hash
> >   create mode 100644 package/python-minimalmodbus/
> python-minimalmodbus.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index c0e6f8bbef..9eb5400999 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -173,6 +173,7 @@ F:        package/mono-gtksharp3/
> >   F:  package/monolite/
> >   F:  package/openjpeg/
> >   F:  package/python-can/
> > +F:   package/python-minimalmodbus/
> >   F:  package/python-pillow/
> >   F:  package/python-pydal/
> >   F:  package/python-spidev/
> > diff --git a/package/Config.in b/package/Config.in
> > index e3a34d6e97..08574931f8 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1112,6 +1112,7 @@ menu "External python modules"
> >       source "package/python-mbstrdecoder/Config.in"
> >       source "package/python-memory-profiler/Config.in"
> >       source "package/python-mimeparse/Config.in"
> > +     source "package/python-minimalmodbus/Config.in"
> >       source "package/python-mistune/Config.in"
> >       source "package/python-modbus-tk/Config.in"
> >       source "package/python-more-itertools/Config.in"
> > diff --git a/package/python-minimalmodbus/Config.in
> b/package/python-minimalmodbus/Config.in
> > new file mode 100644
> > index 0000000000..fd0f33e0d4
> > --- /dev/null
> > +++ b/package/python-minimalmodbus/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_PYTHON_MINIMALMODBUS
> > +     bool "python-minimalmodbus"
> > +     select BR2_PACKAGE_PYTHON_SERIAL # runtime
> > +     help
> > +       Easy-to-use Modbus RTU and Modbus ASCII implementation.
> > +
> > +       https://minimalmodbus.readthedocs.io/
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.hash
> b/package/python-minimalmodbus/python-minimalmodbus.hash
> > new file mode 100644
> > index 0000000000..56af3d426b
> > --- /dev/null
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.hash
> > @@ -0,0 +1,4 @@
> > +# sha256 locally computed
> > +sha256
> aa7e3989074d4efba0013c3c50263aec01afae368bd5bd234008b50aea1b7ab4
> minimalmodbus-2.0.1.tar.gz
> > +# Hash for license file
> > +sha256
> abe787d472ae2069e935c84eb13fd770518dfb08b92d5f190f3cd7ff6d1f6f32  LICENSE
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk
> b/package/python-minimalmodbus/python-minimalmodbus.mk
> > new file mode 100644
> > index 0000000000..e4e93b4c31
> > --- /dev/null
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> > @@ -0,0 +1,14 @@
> >
> +################################################################################
> > +#
> > +# python-minimalmodbus
> > +#
> >
> +################################################################################
> > +
> > +PYTHON_MINIMALMODBUS_VERSION = 2.0.1
> > +PYTHON_MINIMALMODBUS_SOURCE =
> minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> > +PYTHON_MINIMALMODBUS_SITE = $(call
> github,pyhys,minimalmodbus,$(PYTHON_MINIMALMODBUS_VERSION))
>
> I used ./utils/scanpypi and thus have https://files.pythonhosted.org as
> a site. Does buildroot have any preference for which upstream version of
> python packages to prefer if both work?
>

I don't know, honestly. I was using it from git, and it appeared natural to
me to submit that way. Anyway, it is probably better to have it from pypi.
Let me spin around another revision.


> > +PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> > +PYTHON_MINIMALMODBUS_LICENSE = Apache License 2.0
> > +PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> > + > +$(eval $(python-package))
>
> Best,
> Marcus
>
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index c0e6f8bbef..9eb5400999 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -173,6 +173,7 @@  F:	package/mono-gtksharp3/
 F:	package/monolite/
 F:	package/openjpeg/
 F:	package/python-can/
+F:	package/python-minimalmodbus/
 F:	package/python-pillow/
 F:	package/python-pydal/
 F:	package/python-spidev/
diff --git a/package/Config.in b/package/Config.in
index e3a34d6e97..08574931f8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1112,6 +1112,7 @@  menu "External python modules"
 	source "package/python-mbstrdecoder/Config.in"
 	source "package/python-memory-profiler/Config.in"
 	source "package/python-mimeparse/Config.in"
+	source "package/python-minimalmodbus/Config.in"
 	source "package/python-mistune/Config.in"
 	source "package/python-modbus-tk/Config.in"
 	source "package/python-more-itertools/Config.in"
diff --git a/package/python-minimalmodbus/Config.in b/package/python-minimalmodbus/Config.in
new file mode 100644
index 0000000000..fd0f33e0d4
--- /dev/null
+++ b/package/python-minimalmodbus/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_PYTHON_MINIMALMODBUS
+	bool "python-minimalmodbus"
+	select BR2_PACKAGE_PYTHON_SERIAL # runtime
+	help
+	  Easy-to-use Modbus RTU and Modbus ASCII implementation.
+
+	  https://minimalmodbus.readthedocs.io/
diff --git a/package/python-minimalmodbus/python-minimalmodbus.hash b/package/python-minimalmodbus/python-minimalmodbus.hash
new file mode 100644
index 0000000000..56af3d426b
--- /dev/null
+++ b/package/python-minimalmodbus/python-minimalmodbus.hash
@@ -0,0 +1,4 @@ 
+# sha256 locally computed
+sha256  aa7e3989074d4efba0013c3c50263aec01afae368bd5bd234008b50aea1b7ab4  minimalmodbus-2.0.1.tar.gz
+# Hash for license file
+sha256  abe787d472ae2069e935c84eb13fd770518dfb08b92d5f190f3cd7ff6d1f6f32  LICENSE
diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
new file mode 100644
index 0000000000..e4e93b4c31
--- /dev/null
+++ b/package/python-minimalmodbus/python-minimalmodbus.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-minimalmodbus
+#
+################################################################################
+
+PYTHON_MINIMALMODBUS_VERSION = 2.0.1
+PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
+PYTHON_MINIMALMODBUS_SITE = $(call github,pyhys,minimalmodbus,$(PYTHON_MINIMALMODBUS_VERSION))
+PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
+PYTHON_MINIMALMODBUS_LICENSE = Apache License 2.0
+PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))