diff mbox series

[2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package

Message ID 20221017201804.995212-2-giulio.benetti@benettiengineering.com
State Accepted
Headers show
Series [1/2] package/rtl8188eu: bump version to fix build failure with linux >= 6.0.0 | expand

Commit Message

Giulio Benetti Oct. 17, 2022, 8:18 p.m. UTC
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Petr Vorel Oct. 17, 2022, 10:39 p.m. UTC | #1
Hi Giulio,

Thank you!

Kind regards,
Petr
Luca Ceresoli Oct. 18, 2022, 6:59 a.m. UTC | #2
Hi Giulio,

On Mon, 17 Oct 2022 22:18:04 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thank you!

Not sure it makes sense for this kind of patch, but since I discovered
Giulio knows much better than me this package:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Thomas Petazzoni Oct. 30, 2022, 8:04 p.m. UTC | #3
On Mon, 17 Oct 2022 22:18:04 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  DEVELOPERS | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

However, please *always* resend complete patch series. For PATCH 1/2,
you had sent a v2, and then a v3, and for this PATCH 2/2, only a v1 was
there. This is *extremely* confusing for the maintainers.

So when you need to send a new version of one patch in a patch series,
please *always* resend the complete patch series, and mark the entire
previous patch series as Superseded.

Thanks a lot!

Thomas
Giulio Benetti Oct. 30, 2022, 8:39 p.m. UTC | #4
On 30/10/22 21:04, Thomas Petazzoni via buildroot wrote:
> On Mon, 17 Oct 2022 22:18:04 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   DEVELOPERS | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Applied to master, thanks.
> 
> However, please *always* resend complete patch series. For PATCH 1/2,
> you had sent a v2, and then a v3, and for this PATCH 2/2, only a v1 was
> there. This is *extremely* confusing for the maintainers.
> 
> So when you need to send a new version of one patch in a patch series,
> please *always* resend the complete patch series, and mark the entire
> previous patch series as Superseded.

Pardon Thomas, I've lost track of the DEVELOPERS patch while focusing on
the 1/2 patch. I'll pay more attention.

Best regards
Peter Korsgaard Nov. 13, 2022, 3:48 p.m. UTC | #5
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.08.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 1b60dbc11d..c102ddc911 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1154,6 +1154,7 @@  F:	package/nfs-utils/
 F:	package/python-uvloop/
 F:	package/qt5/
 F:	package/rockchip-mali/
+F:	package/rtl8188eu/
 F:	package/rtl8189es/
 F:	package/rtl8723bu/
 F:	package/rtl8723ds/