| Message ID | 20220929111816.497911-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/gitlab-runner: fix forcing openssl | expand |
Forgotten, On 29/09/22 13:18, Giulio Benetti wrote: > BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > accordingly and improve a bit the comment. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr>
Giulio, All, On 2022-09-29 13:18 +0200, Giulio Benetti spake thusly: > BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > accordingly and improve a bit the comment. I've reworded the commit log, and drop the comment change: the symbol name is explicit enough as to what it does. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/gitlab-runner/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in > index 72c2742562..bfa79ac80e 100644 > --- a/package/gitlab-runner/Config.in > +++ b/package/gitlab-runner/Config.in > @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER > select BR2_PACKAGE_LIBCURL_CURL # runtime > select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. > select BR2_PACKAGE_OPENSSL # runtime > - select BR2_PACKAGE_LIBOPENSSL # runtime > + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl > select BR2_PACKAGE_LIBOPENSSL_BIN # runtime > select BR2_PACKAGE_TAR # runtime > help > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Giulio, All, On 2022-09-29 13:20 +0200, Giulio Benetti spake thusly: > Forgotten, > > On 29/09/22 13:18, Giulio Benetti wrote: > >BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > >we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > >accordingly and improve a bit the comment. > > > >Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr> Thanks, I added that, but as a Reported-by tag, because that's a bug that I reported. Regards, Yann E. MORIN. > -- > Giulio Benetti > CEO/CTO@Benetti Engineering sas > > >--- > > package/gitlab-runner/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in > >index 72c2742562..bfa79ac80e 100644 > >--- a/package/gitlab-runner/Config.in > >+++ b/package/gitlab-runner/Config.in > >@@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER > > select BR2_PACKAGE_LIBCURL_CURL # runtime > > select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. > > select BR2_PACKAGE_OPENSSL # runtime > >- select BR2_PACKAGE_LIBOPENSSL # runtime > >+ select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl > > select BR2_PACKAGE_LIBOPENSSL_BIN # runtime > > select BR2_PACKAGE_TAR # runtime > > help > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in index 72c2742562..bfa79ac80e 100644 --- a/package/gitlab-runner/Config.in +++ b/package/gitlab-runner/Config.in @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER select BR2_PACKAGE_LIBCURL_CURL # runtime select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. select BR2_PACKAGE_OPENSSL # runtime - select BR2_PACKAGE_LIBOPENSSL # runtime + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl select BR2_PACKAGE_LIBOPENSSL_BIN # runtime select BR2_PACKAGE_TAR # runtime help
BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify accordingly and improve a bit the comment. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/gitlab-runner/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)