| Message ID | 20220920133224.3290270-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/wilc-driver: fix build failure due to missing Linux options | expand |
On Tue, 2022-09-20 at 15:32 +0200, Giulio Benetti wrote: > Enable Linux options depending on the bus has been chosen, so: > 1) enable by default common Linux options: > CONFIG_NET > CONFIG_WIRELESS > CONFIG_CFG80211 > CONFIG_CRC_ITU_T > CONFIG_CRC7 > 2) enable for SDIO bus: > CONFIG_MMC > 3) enable for SPI bus: > CONFIG_SPI > > Fixes: > http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk > index a89af30e29..a7a902b6db 100644 > --- a/package/wilc-driver/wilc-driver.mk > +++ b/package/wilc-driver/wilc-driver.mk > @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE > ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y) > WILC_DRIVER_MODULE_MAKE_OPTS += \ > CONFIG_WILC_SPI=m > +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS > + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI) > +endef > endif > > ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y) > WILC_DRIVER_MODULE_MAKE_OPTS += \ > CONFIG_WILC_SDIO=m > +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS > + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC) > +endef > endif > > ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y) > @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \ > CONFIG_WILC_HW_OOB_INTR=y > endif > > +define WILC_DRIVER_LINUX_CONFIG_FIXUPS > + $(call KCONFIG_ENABLE_OPT,CONFIG_NET) > + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS) > + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211) > + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T) > + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7) > + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS) > + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS) > +endef > + > $(eval $(kernel-module)) > $(eval $(generic-package)) Reviewed-by: Kris Bahnsen <Kris@embeddedTS.com> Thanks for that! I was not readily aware of that syntax for kernel config fixups. I've also added auto-builds to my filter exception rules so I should be able to more readily look those over in the future. -Kris
Hi Kris, > Il giorno 20 set 2022, alle ore 19:10, Kris Bahnsen <kris@embeddedts.com> ha scritto: > > On Tue, 2022-09-20 at 15:32 +0200, Giulio Benetti wrote: >> Enable Linux options depending on the bus has been chosen, so: >> 1) enable by default common Linux options: >> CONFIG_NET >> CONFIG_WIRELESS >> CONFIG_CFG80211 >> CONFIG_CRC_ITU_T >> CONFIG_CRC7 >> 2) enable for SDIO bus: >> CONFIG_MMC >> 3) enable for SPI bus: >> CONFIG_SPI >> >> Fixes: >> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/ >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk >> index a89af30e29..a7a902b6db 100644 >> --- a/package/wilc-driver/wilc-driver.mk >> +++ b/package/wilc-driver/wilc-driver.mk >> @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE >> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y) >> WILC_DRIVER_MODULE_MAKE_OPTS += \ >> CONFIG_WILC_SPI=m >> +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS >> + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI) >> +endef >> endif >> >> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y) >> WILC_DRIVER_MODULE_MAKE_OPTS += \ >> CONFIG_WILC_SDIO=m >> +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS >> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC) >> +endef >> endif >> >> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y) >> @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \ >> CONFIG_WILC_HW_OOB_INTR=y >> endif >> >> +define WILC_DRIVER_LINUX_CONFIG_FIXUPS >> + $(call KCONFIG_ENABLE_OPT,CONFIG_NET) >> + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS) >> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211) >> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T) >> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7) >> + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS) >> + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS) >> +endef >> + >> $(eval $(kernel-module)) >> $(eval $(generic-package)) > > Reviewed-by: Kris Bahnsen <Kris@embeddedTS.com> > > > Thanks for that! No problem! > I was not readily aware of that syntax for kernel config fixups. They are very helpful and easy to use. > I've also added auto-builds to my filter exception rules so I should be able > to more readily look those over in the future. Awesome :-) Thanks for reviewing and Kind regards — Giulio Benetti Benetti Engineering sas > > -Kris
On Tue, 20 Sep 2022 15:32:24 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Enable Linux options depending on the bus has been chosen, so: > 1) enable by default common Linux options: > CONFIG_NET > CONFIG_WIRELESS > CONFIG_CFG80211 > CONFIG_CRC_ITU_T > CONFIG_CRC7 > 2) enable for SDIO bus: > CONFIG_MMC > 3) enable for SPI bus: > CONFIG_SPI > > Fixes: > http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Applied to master, thanks. Thomas
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes: > Enable Linux options depending on the bus has been chosen, so: > 1) enable by default common Linux options: > CONFIG_NET > CONFIG_WIRELESS > CONFIG_CFG80211 > CONFIG_CRC_ITU_T > CONFIG_CRC7 > 2) enable for SDIO bus: > CONFIG_MMC > 3) enable for SPI bus: > CONFIG_SPI > Fixes: > http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/ > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Committed to 2022.08.x, thanks.
diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk index a89af30e29..a7a902b6db 100644 --- a/package/wilc-driver/wilc-driver.mk +++ b/package/wilc-driver/wilc-driver.mk @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y) WILC_DRIVER_MODULE_MAKE_OPTS += \ CONFIG_WILC_SPI=m +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI) +endef endif ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y) WILC_DRIVER_MODULE_MAKE_OPTS += \ CONFIG_WILC_SDIO=m +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC) +endef endif ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y) @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \ CONFIG_WILC_HW_OOB_INTR=y endif +define WILC_DRIVER_LINUX_CONFIG_FIXUPS + $(call KCONFIG_ENABLE_OPT,CONFIG_NET) + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS) + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211) + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T) + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7) + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS) + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS) +endef + $(eval $(kernel-module)) $(eval $(generic-package))
Enable Linux options depending on the bus has been chosen, so: 1) enable by default common Linux options: CONFIG_NET CONFIG_WIRELESS CONFIG_CFG80211 CONFIG_CRC_ITU_T CONFIG_CRC7 2) enable for SDIO bus: CONFIG_MMC 3) enable for SPI bus: CONFIG_SPI Fixes: http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/ Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)