diff mbox series

[4/4] package/nftables: support libedit cli implementation

Message ID 20220912095540.957477-8-foss+buildroot@0leil.net
State Superseded
Headers show
Series None | expand

Commit Message

Quentin Schulz Sept. 12, 2022, 9:55 a.m. UTC 
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

libedit CLI implementation is supported since commit 9420423900a2
("cli: add libedit support"), nftables v0.9.8. There's an important fix
for Buildroot in v1.0.2, commit 3847fccf0045 ("cli: remove #include
<editline/history.h>").

Also in nftables v1.0.1, libedit/editline cli implementation is made the
default implementation so let's favor libedit implementation over
readline and linenoise if its package is enabled in Buildroot.

Cc: Quentin Schulz <foss+buildroot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 package/nftables/nftables.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/package/nftables/nftables.mk b/package/nftables/nftables.mk
index 56cef56524..9d60736d7f 100644
--- a/package/nftables/nftables.mk
+++ b/package/nftables/nftables.mk
@@ -20,7 +20,11 @@  else
 NFTABLES_CONF_OPTS += --with-mini-gmp
 endif
 
-ifeq ($(BR2_PACKAGE_READLINE),y)
+ifeq ($(BR2_PACKAGE_LIBEDIT),y)
+NFTABLES_CONF_OPTS += --with-cli=editline
+NFTABLES_DEPENDENCIES += libedit
+NFTABLES_LIBS += -lncurses
+else ifeq ($(BR2_PACKAGE_READLINE),y)
 NFTABLES_CONF_OPTS += --with-cli=readline
 NFTABLES_DEPENDENCIES += readline
 NFTABLES_LIBS += -lncurses