| Message ID | 20220814083949.2781340-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/1] package/libvirt: fix libvirtd dependency | expand |
Hello Fabrice, On Sun, 14 Aug 2022 10:39:49 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Add a dependency to BR2_TOOLCHAIN_USES_GLIBC to fix the following > libvirtd build failure raised since commit > f81242ae4fb64ab85af5d38e70246222276552ae: > > Makefile:575: *** libbsd is in the dependency chain of netcat-openbsd that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > > BR2_TOOLCHAIN_USES_GLIBC is only needed by netcat-openbsd, but a > dependency on BR2_TOOLCHAIN_USES_GLIBC || !BR2_PACKAGE_NETCAT_OPENBSD > can't be added as it will create a circular dependency > > An other option would be to revert > f81242ae4fb64ab85af5d38e70246222276552ae and to always mandate C++ even > if it is only needed by nmap-ncat My opinion is that it would make more sense to always mandate C++. Thanks! Thomas
diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in index 5a6b067a0d..f24647bb2d 100644 --- a/package/libvirt/Config.in +++ b/package/libvirt/Config.in @@ -38,6 +38,7 @@ if BR2_PACKAGE_LIBVIRT config BR2_PACKAGE_LIBVIRT_DAEMON bool "libvirtd" default y + depends on BR2_TOOLCHAIN_USES_GLIBC # netcat-openbsd select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS select BR2_PACKAGE_DNSMASQ select BR2_PACKAGE_EBTABLES @@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON Build the libvirt daemon (libvirtd) otherwise build only the utility programs. +comment "libvirtd needs a glibc toolchain" + depends on !BR2_TOOLCHAIN_USES_GLIBC + # Stateful drivers are useful only when building the daemon. if BR2_PACKAGE_LIBVIRT_DAEMON
Add a dependency to BR2_TOOLCHAIN_USES_GLIBC to fix the following libvirtd build failure raised since commit f81242ae4fb64ab85af5d38e70246222276552ae: Makefile:575: *** libbsd is in the dependency chain of netcat-openbsd that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. BR2_TOOLCHAIN_USES_GLIBC is only needed by netcat-openbsd, but a dependency on BR2_TOOLCHAIN_USES_GLIBC || !BR2_PACKAGE_NETCAT_OPENBSD can't be added as it will create a circular dependency An other option would be to revert f81242ae4fb64ab85af5d38e70246222276552ae and to always mandate C++ even if it is only needed by nmap-ncat Fixes: - http://autobuild.buildroot.org/results/aada1d92df6cab0d01e27431b7b7483e3d165e79 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- Changes v1 -> v2 (after review of Yann E. Morin): - Fix patch (rebase on top of current master) package/libvirt/Config.in | 4 ++++ 1 file changed, 4 insertions(+)