| Message ID | 20220804221559.46394-2-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] package/sdl2: be more explicit in disabling optional features | expand |
Thomas, All, On 2022-08-05 00:15 +0200, Thomas Petazzoni via buildroot spake thusly: > In addition to --enable-video-opengles, SDL2 configure script also > looks at --enable-video-opengles1 and --enable-video-opengles2. Since > all OpenGL ES providers in Buildroot provide at least up to OpenGL ES > 2, enable both options when BR2_PACKAGE_SDL2_OPENGLES=y. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/sdl2/sdl2.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/sdl2/sdl2.mk b/package/sdl2/sdl2.mk > index d255112ce9..c5e7968cec 100644 > --- a/package/sdl2/sdl2.mk > +++ b/package/sdl2/sdl2.mk > @@ -155,10 +155,10 @@ SDL2_CONF_OPTS += --disable-video-opengl > endif > > ifeq ($(BR2_PACKAGE_SDL2_OPENGLES),y) > -SDL2_CONF_OPTS += --enable-video-opengles > +SDL2_CONF_OPTS += --enable-video-opengles --enable-video-opengles1 --enable-video-opengles2 > SDL2_DEPENDENCIES += libgles > else > -SDL2_CONF_OPTS += --disable-video-opengles > +SDL2_CONF_OPTS += --disable-video-opengles --disable-video-opengles1 --disable-video-opengles2 > endif > > ifeq ($(BR2_PACKAGE_ALSA_LIB),y) > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/sdl2/sdl2.mk b/package/sdl2/sdl2.mk index d255112ce9..c5e7968cec 100644 --- a/package/sdl2/sdl2.mk +++ b/package/sdl2/sdl2.mk @@ -155,10 +155,10 @@ SDL2_CONF_OPTS += --disable-video-opengl endif ifeq ($(BR2_PACKAGE_SDL2_OPENGLES),y) -SDL2_CONF_OPTS += --enable-video-opengles +SDL2_CONF_OPTS += --enable-video-opengles --enable-video-opengles1 --enable-video-opengles2 SDL2_DEPENDENCIES += libgles else -SDL2_CONF_OPTS += --disable-video-opengles +SDL2_CONF_OPTS += --disable-video-opengles --disable-video-opengles1 --disable-video-opengles2 endif ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
In addition to --enable-video-opengles, SDL2 configure script also looks at --enable-video-opengles1 and --enable-video-opengles2. Since all OpenGL ES providers in Buildroot provide at least up to OpenGL ES 2, enable both options when BR2_PACKAGE_SDL2_OPENGLES=y. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/sdl2/sdl2.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)