diff mbox series

[1/1] package/ecryptfs-utils: add host-pkgconf dependency

Message ID 20220609211454.2939854-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/ecryptfs-utils: add host-pkgconf dependency | expand

Commit Message

Fabrice Fontaine June 9, 2022, 9:14 p.m. UTC
Add host-pkgconf dependency to fix the following build failure (e.g. with
BR2_PER_PACKAGE_DIRECTORIES):

configure: error: OpenSSL not found

As a side-effect, NSS_{CFLAGS,LIBS} can be dropped

Fixes:
 - http://autobuild.buildroot.org/results/ea16957e8f048b713f5d2713aa5f0c157b62f574

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ecryptfs-utils/ecryptfs-utils.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Arnout Vandecappelle June 13, 2022, 8:23 p.m. UTC | #1
On 09/06/2022 23:14, Fabrice Fontaine wrote:
> Add host-pkgconf dependency to fix the following build failure (e.g. with
> BR2_PER_PACKAGE_DIRECTORIES):
> 
> configure: error: OpenSSL not found
> 
> As a side-effect, NSS_{CFLAGS,LIBS} can be dropped
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/ea16957e8f048b713f5d2713aa5f0c157b62f574
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.


> ---
>   package/ecryptfs-utils/ecryptfs-utils.mk | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/package/ecryptfs-utils/ecryptfs-utils.mk b/package/ecryptfs-utils/ecryptfs-utils.mk
> index f087e81a42..737c5b0ebb 100644
> --- a/package/ecryptfs-utils/ecryptfs-utils.mk
> +++ b/package/ecryptfs-utils/ecryptfs-utils.mk
> @@ -11,14 +11,10 @@ ECRYPTFS_UTILS_LICENSE = GPL-2.0+
>   ECRYPTFS_UTILS_LICENSE_FILES = COPYING
>   ECRYPTFS_UTILS_CPE_ID_VENDOR = ecryptfs
>   
> -ECRYPTFS_UTILS_DEPENDENCIES = keyutils libnss host-intltool
> +ECRYPTFS_UTILS_DEPENDENCIES = host-pkgconf keyutils libnss host-intltool

  In the future, it would be nice to take the opportunity to change it to one 
per line and alphabetical.

  Regards,
  Arnout

>   ECRYPTFS_UTILS_CONF_OPTS = --disable-pywrap
>   
> -#Needed for build system to find pk11func.h and libnss3.so
> -ECRYPTFS_UTILS_CONF_ENV = \
> -	ac_cv_path_POD2MAN=true \
> -	NSS_CFLAGS="-I$(STAGING_DIR)/usr/include/nss -I$(STAGING_DIR)/usr/include/nspr" \
> -	NSS_LIBS="-lnss3"
> +ECRYPTFS_UTILS_CONF_ENV = ac_cv_path_POD2MAN=true
>   
>   ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
>   ECRYPTFS_UTILS_CONF_OPTS += --enable-pam
Peter Korsgaard June 19, 2022, 1:44 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Add host-pkgconf dependency to fix the following build failure (e.g. with
 > BR2_PER_PACKAGE_DIRECTORIES):

 > configure: error: OpenSSL not found

 > As a side-effect, NSS_{CFLAGS,LIBS} can be dropped

 > Fixes:
 >  - http://autobuild.buildroot.org/results/ea16957e8f048b713f5d2713aa5f0c157b62f574

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/ecryptfs-utils/ecryptfs-utils.mk b/package/ecryptfs-utils/ecryptfs-utils.mk
index f087e81a42..737c5b0ebb 100644
--- a/package/ecryptfs-utils/ecryptfs-utils.mk
+++ b/package/ecryptfs-utils/ecryptfs-utils.mk
@@ -11,14 +11,10 @@  ECRYPTFS_UTILS_LICENSE = GPL-2.0+
 ECRYPTFS_UTILS_LICENSE_FILES = COPYING
 ECRYPTFS_UTILS_CPE_ID_VENDOR = ecryptfs
 
-ECRYPTFS_UTILS_DEPENDENCIES = keyutils libnss host-intltool
+ECRYPTFS_UTILS_DEPENDENCIES = host-pkgconf keyutils libnss host-intltool
 ECRYPTFS_UTILS_CONF_OPTS = --disable-pywrap
 
-#Needed for build system to find pk11func.h and libnss3.so
-ECRYPTFS_UTILS_CONF_ENV = \
-	ac_cv_path_POD2MAN=true \
-	NSS_CFLAGS="-I$(STAGING_DIR)/usr/include/nss -I$(STAGING_DIR)/usr/include/nspr" \
-	NSS_LIBS="-lnss3"
+ECRYPTFS_UTILS_CONF_ENV = ac_cv_path_POD2MAN=true
 
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 ECRYPTFS_UTILS_CONF_OPTS += --enable-pam