| Message ID | 20220524143239.1050052-1-arnout@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [PATCH/next] package/linux-firmware: install all RTL_RTW88 blobs | expand |
Arnout, All, On 2022-05-24 16:32 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly: > Rather than installing just the three blobs mentioned explicitly in the > .mk file, use a wildcard to install all blobs. At the time of this > writing, this matches the following: > > -rw-r--r-- 1 arnout arnout 29K Mar 9 13:28 rtw8723d_fw.bin > -rw-r--r-- 1 arnout arnout 136K Mar 9 13:28 rtw8821c_fw.bin > -rw-r--r-- 1 arnout arnout 148K Mar 9 13:28 rtw8822b_fw.bin > -rw-r--r-- 1 arnout arnout 198K Mar 9 13:28 rtw8822c_fw.bin > -rw-r--r-- 1 arnout arnout 142K Mar 9 13:28 rtw8822c_wow_fw.bin > > I.e. rtw8821c_fw.bin and rtw8822c_wow_fw.bin were missing. > > Although including all blobs nearly doubles the size, it still totals to > just 660K which wouldn't warrant making more refined sub-options. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Applied to next, thanks. Regards, Yann E. MORIN. > --- > package/linux-firmware/linux-firmware.mk | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk > index 0c725737d0..64d096df14 100644 > --- a/package/linux-firmware/linux-firmware.mk > +++ b/package/linux-firmware/linux-firmware.mk > @@ -154,9 +154,7 @@ endif > # rtw88 > ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_RTW88),y) > LINUX_FIRMWARE_FILES += \ > - rtw88/rtw8723d_fw.bin \ > - rtw88/rtw8822b_fw.bin \ > - rtw88/rtw8822c_fw.bin > + rtw88/rtw*.bin > LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.rtlwifi_firmware.txt > endif > > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk index 0c725737d0..64d096df14 100644 --- a/package/linux-firmware/linux-firmware.mk +++ b/package/linux-firmware/linux-firmware.mk @@ -154,9 +154,7 @@ endif # rtw88 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_RTW88),y) LINUX_FIRMWARE_FILES += \ - rtw88/rtw8723d_fw.bin \ - rtw88/rtw8822b_fw.bin \ - rtw88/rtw8822c_fw.bin + rtw88/rtw*.bin LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.rtlwifi_firmware.txt endif
Rather than installing just the three blobs mentioned explicitly in the .mk file, use a wildcard to install all blobs. At the time of this writing, this matches the following: -rw-r--r-- 1 arnout arnout 29K Mar 9 13:28 rtw8723d_fw.bin -rw-r--r-- 1 arnout arnout 136K Mar 9 13:28 rtw8821c_fw.bin -rw-r--r-- 1 arnout arnout 148K Mar 9 13:28 rtw8822b_fw.bin -rw-r--r-- 1 arnout arnout 198K Mar 9 13:28 rtw8822c_fw.bin -rw-r--r-- 1 arnout arnout 142K Mar 9 13:28 rtw8822c_wow_fw.bin I.e. rtw8821c_fw.bin and rtw8822c_wow_fw.bin were missing. Although including all blobs nearly doubles the size, it still totals to just 660K which wouldn't warrant making more refined sub-options. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- package/linux-firmware/linux-firmware.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)