diff mbox series

[1/1] package/netdata: fix uclibc build without wchar

Message ID 20220412163624.1143941-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/netdata: fix uclibc build without wchar | expand

Commit Message

Fabrice Fontaine April 12, 2022, 4:36 p.m. UTC
Fix the following uclibc build failure without wchar raised since bump
to version 1.33.1 in commit 73dc2eef2dc40b78e732872b26eee0bcea1087d1:

configure: error: Netdata requires a compiler that supports C99 to build

Fixes:
 - http://autobuild.buildroot.org/results/bca4d370ed0553d5f99f1277d0a1e3b49f62b95f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/netdata/netdata.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Arnout Vandecappelle April 21, 2022, 5:56 p.m. UTC | #1
On 12/04/2022 18:36, Fabrice Fontaine wrote:
> Fix the following uclibc build failure without wchar raised since bump
> to version 1.33.1 in commit 73dc2eef2dc40b78e732872b26eee0bcea1087d1:
> 
> configure: error: Netdata requires a compiler that supports C99 to build
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/bca4d370ed0553d5f99f1277d0a1e3b49f62b95f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/netdata/netdata.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
> index d29733d8f6..dade6c625b 100644
> --- a/package/netdata/netdata.mk
> +++ b/package/netdata/netdata.mk
> @@ -18,6 +18,10 @@ NETDATA_CONF_OPTS = \
>   	--disable-unit-tests
>   NETDATA_DEPENDENCIES = libuv util-linux zlib
>   
> +# ac_cv_prog_cc_c99 is required for BR2_USE_WCHAR=n because the C99 test
> +# provided by autoconf relies on wchar_t.
> +NETDATA_CONF_ENV = ac_cv_prog_cc_c99=-std=gnu99
> +
>   ifeq ($(BR2_GCC_ENABLE_LTO),y)
>   NETDATA_CONF_OPTS += --enable-lto
>   else
diff mbox series

Patch

diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
index d29733d8f6..dade6c625b 100644
--- a/package/netdata/netdata.mk
+++ b/package/netdata/netdata.mk
@@ -18,6 +18,10 @@  NETDATA_CONF_OPTS = \
 	--disable-unit-tests
 NETDATA_DEPENDENCIES = libuv util-linux zlib
 
+# ac_cv_prog_cc_c99 is required for BR2_USE_WCHAR=n because the C99 test
+# provided by autoconf relies on wchar_t.
+NETDATA_CONF_ENV = ac_cv_prog_cc_c99=-std=gnu99
+
 ifeq ($(BR2_GCC_ENABLE_LTO),y)
 NETDATA_CONF_OPTS += --enable-lto
 else