| Message ID | 20220405204254.11147-1-ps.report@gmx.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] package/spidev_test: fix version determination (SPI_TX_OCTAL support needs linux headers >= 5.8) | expand |
Peter, All, On 2022-04-05 22:42 +0200, Peter Seiderer spake thusly: > Fixes: > > - http://autobuild.buildroot.net/results/a5c008aaff40f4851ffa36439c7340b6243a4842 > > .../build/spidev_test-5.8/spidev_test.c:132:13: error: 'SPI_TX_OCTAL' undeclared (first use in this function); did you mean 'SPI_TX_DUAL'? > 132 | if (mode & SPI_TX_OCTAL) > | ^~~~~~~~~~~~ > | SPI_TX_DUAL > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/spidev_test/Config.in | 2 +- > package/spidev_test/spidev_test.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in > index 81386adf7a..abfa885b73 100644 > --- a/package/spidev_test/Config.in > +++ b/package/spidev_test/Config.in > @@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST > proper operation of 'spidev_test'. > > The version used is based on your toolchain headers version, > - if it's older than 3.15 then 3.0 is used, up to headers 4.20 > + if it's older than 3.15 then 3.0 is used, up to headers 5.7 > version 4.10 is used and otherwise version 5.8. > This means you won't have quad-pumped SPI support if your > toolchain is too old. > diff --git a/package/spidev_test/spidev_test.mk b/package/spidev_test/spidev_test.mk > index 6c5a9495a4..bd138b0142 100644 > --- a/package/spidev_test/spidev_test.mk > +++ b/package/spidev_test/spidev_test.mk > @@ -10,7 +10,7 @@ > # If you need quad-pumped spi support you need to upgrade your toolchain. > # Note that the location of spidev_test.c changes from v4.5 onwards. > > -ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y) > +ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8),y) > SPIDEV_TEST_VERSION = 5.8 > SPIDEV_TEST_PATH = tools/spi > else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y) > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in index 81386adf7a..abfa885b73 100644 --- a/package/spidev_test/Config.in +++ b/package/spidev_test/Config.in @@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST proper operation of 'spidev_test'. The version used is based on your toolchain headers version, - if it's older than 3.15 then 3.0 is used, up to headers 4.20 + if it's older than 3.15 then 3.0 is used, up to headers 5.7 version 4.10 is used and otherwise version 5.8. This means you won't have quad-pumped SPI support if your toolchain is too old. diff --git a/package/spidev_test/spidev_test.mk b/package/spidev_test/spidev_test.mk index 6c5a9495a4..bd138b0142 100644 --- a/package/spidev_test/spidev_test.mk +++ b/package/spidev_test/spidev_test.mk @@ -10,7 +10,7 @@ # If you need quad-pumped spi support you need to upgrade your toolchain. # Note that the location of spidev_test.c changes from v4.5 onwards. -ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y) +ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8),y) SPIDEV_TEST_VERSION = 5.8 SPIDEV_TEST_PATH = tools/spi else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
Fixes: - http://autobuild.buildroot.net/results/a5c008aaff40f4851ffa36439c7340b6243a4842 .../build/spidev_test-5.8/spidev_test.c:132:13: error: 'SPI_TX_OCTAL' undeclared (first use in this function); did you mean 'SPI_TX_DUAL'? 132 | if (mode & SPI_TX_OCTAL) | ^~~~~~~~~~~~ | SPI_TX_DUAL Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/spidev_test/Config.in | 2 +- package/spidev_test/spidev_test.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)